From 9d9a9dd41313ed5d2e544bb3bcdf08dab6f38a48 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 15 Oct 2010 18:32:46 +0200 Subject: change dd_create API to return dd pointer (no need to dd_init it separately) Signed-off-by: Denys Vlasenko --- src/daemon/abrt-server.c | 6 ++---- src/hooks/abrt-hook-ccpp.cpp | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/daemon/abrt-server.c b/src/daemon/abrt-server.c index 231fc0bd..67978561 100644 --- a/src/daemon/abrt-server.c +++ b/src/daemon/abrt-server.c @@ -115,11 +115,9 @@ static void create_debug_dump() /* No need to check the path length, as all variables used are limited, and dd_create() fails if the path is too long. */ - struct dump_dir *dd = dd_init(); - if (!dd_create(dd, path, client_uid)) + struct dump_dir *dd = dd_create(path, client_uid); + if (!dd) { - dd_delete(dd); - dd_close(dd); error_msg_and_die("Error creating crash dump %s", path); } diff --git a/src/hooks/abrt-hook-ccpp.cpp b/src/hooks/abrt-hook-ccpp.cpp index 279ac5db..146de6e0 100644 --- a/src/hooks/abrt-hook-ccpp.cpp +++ b/src/hooks/abrt-hook-ccpp.cpp @@ -415,8 +415,8 @@ int main(int argc, char** argv) if (path_len >= (sizeof(path) - sizeof("/"FILENAME_COREDUMP))) return 1; - struct dump_dir *dd = dd_init(); - if (dd_create(dd, path, uid)) + struct dump_dir *dd = dd_create(path, uid); + if (dd) { char *cmdline = get_cmdline(pid); /* never NULL */ char *reason = xasprintf("Process %s was killed by signal %s (SIG%s)", executable, signal_str, signame ? signame : signal_str); -- cgit