From 4df13ffe0f3b9952dcd68263fb51cac842b193b1 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Tue, 9 Feb 2010 17:07:44 +0100 Subject: cli: fix trivial error counter bug Signed-off-by: Denys Vlasenko --- src/CLI/report.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/CLI/report.cpp b/src/CLI/report.cpp index 7ef33acf..6a8f9f4c 100644 --- a/src/CLI/report.cpp +++ b/src/CLI/report.cpp @@ -427,12 +427,12 @@ int report(const char *uuid, bool always) // Skip nonReporter plugins. if (0 != strcmp(it->second["Type"].c_str(), "Reporter")) continue; - + map_string_t settings = call_GetPluginSettings(it->first.c_str()); // Login information is missing. - bool loginMissing = settings.find("Login") != settings.end() + bool loginMissing = settings.find("Login") != settings.end() && 0 == strcmp(settings["Login"].c_str(), ""); - bool passwordMissing = settings.find("Password") != settings.end() + bool passwordMissing = settings.find("Password") != settings.end() && 0 == strcmp(settings["Password"].c_str(), ""); if (!loginMissing && !passwordMissing) continue; @@ -461,7 +461,7 @@ int report(const char *uuid, bool always) fgets(answer, sizeof(answer), stdin); if (strlen(answer) > 0) pluginSettings[it->first]["Password"] = answer; - } + } } } @@ -475,7 +475,7 @@ int report(const char *uuid, bool always) vector_string_t &v = it->second; printf("%s: %s\n", it->first.c_str(), v[REPORT_STATUS_IDX_MSG].c_str()); plugins++; - if (v[REPORT_STATUS_IDX_FLAG] != "0") + if (v[REPORT_STATUS_IDX_FLAG] == "0") errors++; it++; } -- cgit