From 0711539d8d6a13e67db9321d9f8295b6e816afbb Mon Sep 17 00:00:00 2001
From: Denys Vlasenko <dvlasenk@redhat.com>
Date: Wed, 9 Mar 2011 18:06:42 +0100
Subject: rename Bugzilla.xml to report_Bugzilla.xml

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
---
 src/plugins/Bugzilla.xml        | 30 ------------------------------
 src/plugins/Makefile.am         |  2 +-
 src/plugins/report_Bugzilla.xml | 30 ++++++++++++++++++++++++++++++
 3 files changed, 31 insertions(+), 31 deletions(-)
 delete mode 100644 src/plugins/Bugzilla.xml
 create mode 100644 src/plugins/report_Bugzilla.xml

(limited to 'src/plugins')

diff --git a/src/plugins/Bugzilla.xml b/src/plugins/Bugzilla.xml
deleted file mode 100644
index bc8e8ecb..00000000
--- a/src/plugins/Bugzilla.xml
+++ /dev/null
@@ -1,30 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" ?>
-<event>
-    <name>Bugzilla</name>
-    <action>Report this problem to the Red Hat bug tracker</action>
-    <description>Reports selected problems to the Red Hat bug tracker</description>
-    <options>
-        <option type="text" name="Bugzilla_BugzillaURL">
-           <label>Bugzilla URL</label>
-           <allow-empty>no</allow-empty>
-           <description>Address of the bugzilla server</description>
-           <property>Address of the bugzilla server</property>
-           <notused1>blahblahblah</notused1>
-       </option>
-       <option type="text" name="Bugzilla_Login">
-           <label>User name</label>
-           <allow-empty>no</allow-empty>
-           <description>Username to use to log into your bugzilla account</description>
-       </option>
-       <option type="password" name="Bugzilla_Password">
-           <label>Password</label>
-           <allow-empty>no</allow-empty>
-           <description>Password for your bugzilla account</description>
-       </option>
-       <option type="bool" name="Bugzilla_SSLVerify">
-           <label>SSL Verify</label>
-           <description>Check the ssl key validity</description>
-       </option>
-    </options>
-</event>
-
diff --git a/src/plugins/Makefile.am b/src/plugins/Makefile.am
index 3c4b37cf..4548c67c 100644
--- a/src/plugins/Makefile.am
+++ b/src/plugins/Makefile.am
@@ -41,7 +41,7 @@ dist_pluginsconf_DATA = \
 eventsdir = $(EVENTS_DIR)
 
 dist_events_DATA = \
-    Bugzilla.xml
+    report_Bugzilla.xml
 
 eventsconfdir = $(EVENTS_CONF_DIR)
 
diff --git a/src/plugins/report_Bugzilla.xml b/src/plugins/report_Bugzilla.xml
new file mode 100644
index 00000000..bc8e8ecb
--- /dev/null
+++ b/src/plugins/report_Bugzilla.xml
@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<event>
+    <name>Bugzilla</name>
+    <action>Report this problem to the Red Hat bug tracker</action>
+    <description>Reports selected problems to the Red Hat bug tracker</description>
+    <options>
+        <option type="text" name="Bugzilla_BugzillaURL">
+           <label>Bugzilla URL</label>
+           <allow-empty>no</allow-empty>
+           <description>Address of the bugzilla server</description>
+           <property>Address of the bugzilla server</property>
+           <notused1>blahblahblah</notused1>
+       </option>
+       <option type="text" name="Bugzilla_Login">
+           <label>User name</label>
+           <allow-empty>no</allow-empty>
+           <description>Username to use to log into your bugzilla account</description>
+       </option>
+       <option type="password" name="Bugzilla_Password">
+           <label>Password</label>
+           <allow-empty>no</allow-empty>
+           <description>Password for your bugzilla account</description>
+       </option>
+       <option type="bool" name="Bugzilla_SSLVerify">
+           <label>SSL Verify</label>
+           <description>Check the ssl key validity</description>
+       </option>
+    </options>
+</event>
+
-- 
cgit 


From d67c6ee3d6b3067d8697ee5e4a131af906789583 Mon Sep 17 00:00:00 2001
From: Denys Vlasenko <dvlasenk@redhat.com>
Date: Thu, 10 Mar 2011 10:03:19 +0100
Subject: abrt-action-install-debuginfo: prevent $PATH attack

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
---
 src/plugins/abrt-action-install-debuginfo.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

(limited to 'src/plugins')

diff --git a/src/plugins/abrt-action-install-debuginfo.c b/src/plugins/abrt-action-install-debuginfo.c
index 39915e59..77cd370b 100644
--- a/src/plugins/abrt-action-install-debuginfo.c
+++ b/src/plugins/abrt-action-install-debuginfo.c
@@ -1,7 +1,8 @@
 #include <unistd.h>
 #include <string.h>
 
-#define EXECUTABLE "abrt-action-install-debuginfo.py"
+// TODO: honor configure --prefix here:
+#define EXECUTABLE "/usr/bin/abrt-action-install-debuginfo.py"
 
 static void error_msg_and_die(const char *msg, const char *arg)
 {
@@ -38,6 +39,10 @@ int main(int argc, char **argv)
             error_msg_and_die("bad option", arg);
     }
 
-    execvp(EXECUTABLE, argv);
+    /* We use full path, and execv instead of execvp in order to
+     * disallow user to execute his own abrt-action-install-debuginfo.py
+     * in his dir by setting up corresponding malicious $PATH.
+     */
+    execv(EXECUTABLE, argv);
     error_msg_and_die("Can't execute", EXECUTABLE);
 }
-- 
cgit