From 3d7e4711921a936688441ea06c4691a67d5809be Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Tue, 17 Aug 2010 18:55:35 +0200 Subject: *: move NLS include and #define _ to abrtlib.h Signed-off-by: Denys Vlasenko --- lib/plugins/RHTSupport.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/plugins/RHTSupport.cpp') diff --git a/lib/plugins/RHTSupport.cpp b/lib/plugins/RHTSupport.cpp index f056056d..0db227b3 100644 --- a/lib/plugins/RHTSupport.cpp +++ b/lib/plugins/RHTSupport.cpp @@ -18,6 +18,9 @@ */ #define _GNU_SOURCE 1 /* for stpcpy */ +#ifdef HAVE_CONFIG_H +# include +#endif #include #include "abrtlib.h" #include "abrt_curl.h" @@ -28,9 +31,6 @@ #include "comm_layer_inner.h" #include "RHTSupport.h" #include "strbuf.h" -#ifdef HAVE_CONFIG_H -# include -#endif using namespace std; -- cgit From 5135bed7aa5b7a5426c273cdf3db6f32536f698e Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Tue, 17 Aug 2010 18:57:56 +0200 Subject: RHTSupport: add a status message to reduce user confusion Signed-off-by: Denys Vlasenko --- lib/plugins/RHTSupport.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'lib/plugins/RHTSupport.cpp') diff --git a/lib/plugins/RHTSupport.cpp b/lib/plugins/RHTSupport.cpp index 0db227b3..313d426d 100644 --- a/lib/plugins/RHTSupport.cpp +++ b/lib/plugins/RHTSupport.cpp @@ -110,6 +110,9 @@ string CReporterRHticket::Report(const map_crash_data_t& pCrashData, const map_plugin_settings_t& pSettings, const char *pArgs) { + /* Gzipping e.g. 0.5gig coredump takes a while. Let client know what we are doing */ + update_client(_("Compressing data")); + string retval; map_plugin_settings_t::const_iterator end = pSettings.end(); -- cgit From 9c2587f867c6d903efdfd001e977b83030bb1a2c Mon Sep 17 00:00:00 2001 From: Nikola Pajkovsky Date: Wed, 18 Aug 2010 10:38:23 +0200 Subject: assignment segfaults if right hand is a NULL pointer Signed-off-by: Nikola Pajkovsky --- lib/plugins/RHTSupport.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/plugins/RHTSupport.cpp') diff --git a/lib/plugins/RHTSupport.cpp b/lib/plugins/RHTSupport.cpp index 313d426d..d13ff467 100644 --- a/lib/plugins/RHTSupport.cpp +++ b/lib/plugins/RHTSupport.cpp @@ -314,9 +314,9 @@ void CReporterRHticket::SetSettings(const map_plugin_settings_t& pSettings) /* Should not be deleted (why?) */ const map_plugin_settings_t& CReporterRHticket::GetSettings() { - m_pSettings["URL"] = m_strata_url; - m_pSettings["Login"] = m_login; - m_pSettings["Password"] = m_password; + m_pSettings["URL"] = (m_strata_url)? m_strata_url: ""; + m_pSettings["Login"] = (m_login)? m_login: ""; + m_pSettings["Password"] = (m_password)? m_password: ""; m_pSettings["SSLVerify"] = m_ssl_verify ? "yes" : "no"; return m_pSettings; -- cgit