From c0ce7860a4bdcefd8a43197d05dca9fd12bb52b1 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Thu, 14 Oct 2010 11:06:45 +0200 Subject: various small fixes to dd usage KerneloopsScanner: dd leak on error path in save_oops_to_debug_dump() dump_dir: remove superfluous exist_file_dir check in dd_opendir, dd_create, delete_file_dir; use perror_msg instead of error_msg; correct some sligtly wrong log/error messages; make delete_file_dir return void, since return value is never checked. Signed-off-by: Denys Vlasenko --- lib/plugins/KerneloopsScanner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/plugins/KerneloopsScanner.cpp') diff --git a/lib/plugins/KerneloopsScanner.cpp b/lib/plugins/KerneloopsScanner.cpp index 0e7d4dc3..9336a7d8 100644 --- a/lib/plugins/KerneloopsScanner.cpp +++ b/lib/plugins/KerneloopsScanner.cpp @@ -143,10 +143,10 @@ int save_oops_to_debug_dump(GList **oopsList) /* Optional, makes generated bz more informative */ strchrnul(second_line, '\n')[0] = '\0'; dd_save_text(dd, FILENAME_REASON, second_line); - dd_close(dd); } else errors++; + dd_close(dd); } return errors; -- cgit