From afb30fe1502e9c45b722da3b5c09e292d589aa7f Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Thu, 4 Mar 2010 16:19:31 +0100 Subject: *: UID:UUID -> crash_id conversion This fixes at least three instances where we did not check whether user is even allowed to report or delete a crash. Also fixes a few cases when root might inadvertently act on (e.g. delete) mote than one crash. Renamed FILENAME_UID to CD_UID - makes more sense this way. Added COL_INFORMALL and CD_INFORMALL. Nuked UID == -1 hacks. Renamed getReport() to start_job on Python side. Dropped a few unused parameters from server -> client dbus signals. Fixed CLI's way of reverencing crashes (see updated help text). Run-tested (GUI and CLI). Signed-off-by: Denys Vlasenko Acked-by: Nikola Pajkovsky --- lib/Plugins/Firefox.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/Plugins/Firefox.cpp') diff --git a/lib/Plugins/Firefox.cpp b/lib/Plugins/Firefox.cpp index 3cb9c938..ac7ab2cd 100644 --- a/lib/Plugins/Firefox.cpp +++ b/lib/Plugins/Firefox.cpp @@ -246,7 +246,7 @@ static void GetBacktrace(const char *pDebugDumpDir, std::string& pBacktrace) CDebugDump dd; dd.Open(pDebugDumpDir); dd.LoadText(FILENAME_EXECUTABLE, executable); - dd.LoadText(FILENAME_UID, UID); + dd.LoadText(CD_UID, UID); } // Workaround for @@ -440,7 +440,7 @@ static std::string run_unstrip_n(const char *pDebugDumpDir) { CDebugDump dd; dd.Open(pDebugDumpDir); - dd.LoadText(FILENAME_UID, UID); + dd.LoadText(CD_UID, UID); } char* args[4]; @@ -884,7 +884,7 @@ void CAnalyzerFirefox::CreateReport(const char *pDebugDumpDir, int force) } dd.LoadText(FILENAME_PACKAGE, package); - dd.LoadText(FILENAME_UID, UID); + dd.LoadText(CD_UID, UID); dd.Close(); /* do not keep dir locked longer than needed */ std::string build_ids; -- cgit