From 0e2f5ab4c66a65ce5c60297cb7915c1ce1a3bd42 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Wed, 1 Dec 2010 22:03:02 +0100 Subject: GHashTable: must use g_hash_table_replace instead of _insert to not leak key Signed-off-by: Denys Vlasenko --- src/cli/report.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cli/report.cpp b/src/cli/report.cpp index 3f2a4902..27e12ac8 100644 --- a/src/cli/report.cpp +++ b/src/cli/report.cpp @@ -530,7 +530,7 @@ static GHashTable *get_reporter_plugin_settings(const vector_string_t& reporters // Copy the received settings as defaults. // Plugins won't work without it, if some value is missing // they use their default values for all fields. - g_hash_table_insert(settings, xstrdup(it->c_str()), (void*)single_plugin_settings); + g_hash_table_replace(settings, xstrdup(it->c_str()), (void*)single_plugin_settings); } /* Second, load user-specific settings, which override @@ -542,8 +542,8 @@ static GHashTable *get_reporter_plugin_settings(const vector_string_t& reporters GHashTableIter iter; gpointer key, value; - g_hash_table_iter_init (&iter, settings); - while (g_hash_table_iter_next (&iter, &key, &value)) + g_hash_table_iter_init(&iter, settings); + while (g_hash_table_iter_next(&iter, &key, &value)) { map_string_t single_plugin_settings; -- cgit