summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* use OPT__HELP macro for help optionNikola Pajkovsky2010-10-084-4/+4
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* Merge branch 'unify-parser'Nikola Pajkovsky2010-10-084-121/+84
|\ | | | | | | | | | | | | | | * unify-parser: abrt-server uses new parser abrt-action-save-package-data uses new parser use a new INTEGER option abrt-action-generate-backtrace uses new parser
| * abrt-server uses new parserNikola Pajkovsky2010-10-071-30/+23
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
| * abrt-action-save-package-data uses new parserNikola Pajkovsky2010-10-071-33/+26
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
| * use a new INTEGER optionNikola Pajkovsky2010-10-071-11/+1
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
| * abrt-action-generate-backtrace uses new parserNikola Pajkovsky2010-10-071-47/+34
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* | add a bit more logging in places. fix typosDenys Vlasenko2010-10-073-4/+6
|/ | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Settings.cpp: avoid double free corruptionNikola Pajkovsky2010-10-061-0/+5
| | | | | | | | | | | | I meant, that settings_free() should not only do free(g_settings_*); but also should do g_settings_* = NULL; Otherwise calling settings_free() twice will cause double-free and likely segfault. Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* report.cpp: split() uses GListNikola Pajkovsky2010-10-062-11/+18
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* Kerneloops*.cpp and dumpoops.cpp uses GListNikola Pajkovsky2010-10-062-9/+19
| | | | | | vector_string_t was replaced by glist in these files Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* Daemon.cpp: FindNewDumps() uses GListNikola Pajkovsky2010-10-061-6/+12
| | | | | | transform vector_string_t to GList Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* dumpoops.cpp: fix indentationNikola Pajkovsky2010-10-061-84/+84
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* report.cpp: fix indentationNikola Pajkovsky2010-10-061-511/+511
| | | | | | no code change Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* Merge branch 'settings'Nikola Pajkovsky2010-10-056-58/+87
|\ | | | | | | | | | | | | | | | | * settings: g_settings_sWatchCrashdumpArchiveDir uses char* g_settings_sDatabase uses char* g_settings_setBlackListedPaths uses GList g_settings_setBlackListedPkgs uses GList g_settings_setOpenGPGPublicKeys uses GList
| * g_settings_sWatchCrashdumpArchiveDir uses char*Nikola Pajkovsky2010-09-243-7/+9
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
| * g_settings_sDatabase uses char*Nikola Pajkovsky2010-09-244-15/+20
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
| * g_settings_setBlackListedPaths uses GListNikola Pajkovsky2010-09-243-33/+10
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
| * g_settings_setBlackListedPkgs uses GListNikola Pajkovsky2010-09-243-6/+39
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
| * g_settings_setOpenGPGPublicKeys uses GListNikola Pajkovsky2010-09-244-7/+19
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* | parse_options.c: add argument helpNikola Pajkovsky2010-10-051-1/+1
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* | Daemon.cpp: remove getopt and use parse_opts insteadNikola Pajkovsky2010-10-041-31/+34
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* | Daemon.cpp: remove unused rpm.hNikola Pajkovsky2010-09-301-1/+0
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* | run-command.cpp: rename to run-command.cNikola Pajkovsky2010-09-273-1/+9
|/ | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* rename abrt-debuginfo-install to abrt-action-install-debuginfoDenys Vlasenko2010-09-232-4/+6
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* remove unused codeNikola Pajkovsky2010-09-232-12/+0
| | | | | | code is run in abrt-action-save-package-data.cpp Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* This patch splits off abrtd's package/component/descriptionDenys Vlasenko2010-09-225-263/+383
| | | | | | | | | | | | | | | | | | | | | | | | | | | | generation into a separate tool: abrt-action-save-package-data: invalid option -- 'z' Usage: abrt-action-save-package-data -d DIR [-vs] Query package database and save package name, component, and description Options: -d DIR Crash dump directory -v Verbose -s Log to syslog This also allows for debugging and regression testing of abrt-action-save-package-data - it can be simply run from command-line. Also it provides a better fault isolation - crash in abrt-action-save-package-data does not take down abrtd. Same goes for isolation of memory leaks - old code actually had leaks on a rarely used error path. New code doesn't, but if it would have, it wouldn't matter, since the process is short-lived. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* add two flags to dd_opendir()Nikola Pajkovsky2010-09-222-39/+21
| | | | | | | | | | | | | | | | | | | DD_CLOSE_ON_OPEN_ERR - free dump_dir structure when opening dump_dir does not exist DD_FAIL_QUIETLY - suppress message when dump directory does not exist VERB1 log(_("Unable to open debug dump '%s'"), pDebugDumpDir); is all removed because there is error_msg("'%s' does not exist", dd->dd_dir); in dd_opendir() which sometimes we don't want to print(DD_FAIL_QUIETLY) example: crash dump directory trimming code running concurrently. Second process may try to delete a directory which is already gone. it should not complain that it is missing. Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* eliminate LoadOpenGPGPublicKey wrapperDenys Vlasenko2010-09-224-11/+4
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* fix a small memory leakDenys Vlasenko2010-09-211-1/+3
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* This patch splits off CCpp's backtrace generation into a separate tool:Denys Vlasenko2010-09-202-1/+447
| | | | | | | | | | | | | | | | | | | | | | | | | | | $ abrt-action-generate-backtrace -z abrt-action-generate-backtrace: invalid option -- 'z' Usage: abrt-action-generate-backtrace -d DIR [-i DIR1:DIR2] [-t SECONDS] [-vs] Generate backtrace, its quality rating, hash, and crashed function Options: -d DIR Crash dump directory -i DIR1:DIR2 Additional debuginfo directories -t SECONDS Kill gdb if it runs for more than SECONDS -v Verbose -s Log to syslog This also allows for debugging and regression testing of abrt-action-generate-backtrace separately - it can be simply run from command-line. Also it provides a better fault isolation - crash in abrt-action-generate-backtrace does not take down abrtd. The code is based on CCpp.cpp. CCpp analyzer is made to spawn a child to do the backtrace generation. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* unhide dump_dir structure from typedefNikola Pajkovsky2010-09-203-10/+10
| | | | | | no other code changes Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* perror has to be used immediately after failed syscallDenys Vlasenko2010-09-161-1/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Pure file rename without changesDenys Vlasenko2010-09-141-0/+0
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* This patch makes abrtd spawn a new process, abrt-server,Denys Vlasenko2010-09-144-488/+371
| | | | | | | | | | | | | | | | | | | | | | | | | for every socket client. This allows for simpler timeout handling using SIGALRM, and makes timers for tracking client timeouts unnecessary. This also allows for debugging and regression testing of abrt-server separately - it can be simply run from command-line and fed commands on stdin. Also it provides a better fault isolation - crash in abrt-server does not take down abrtd. The code is based on dumpsocket.{cpp,h}. Most of dumpsocket.cpp goes to abrt-server.c, a small part goes to Daemon.cpp (i.e. to abrtd). This change will not compile - it does not have dumpsocket.cpp renamed to abrt-server.c, which makes the change easier to read. The next change, which I'll commit after this one, contains only the renaming. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* msg_prefix now doesn't need ": " suffixDenys Vlasenko2010-09-143-6/+6
| | | | | | Contains some other trivial changes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* MiddleWare.cpp: remove unused variablesNikola Pajkovsky2010-09-081-5/+0
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* add forgotten database disconnect on error pathDenys Vlasenko2010-09-081-7/+4
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* SQLite3.cpp: replace std::vector by GListNikola Pajkovsky2010-09-082-41/+72
| | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* DebugDump.* -> dump_dir.*Nikola Pajkovsky2010-09-076-6/+0
| | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Jiri Moskovcak <jmoskovc@redhat.com>
* run_main_loop: allocate GPollFD array dynamicallyDenys Vlasenko2010-09-071-6/+12
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* dumpsocket: removed unused sockaddr param in accept() call; s/perror/error/Denys Vlasenko2010-09-073-10/+8
| | | | | | Also removed unneeded casts and added and fixed comments Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* DebugDump.cpp: lowercase and rename functionsNikola Pajkovsky2010-09-023-27/+27
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2010-09-011-24/+0
|\
| * remove dead codeNikola Pajkovsky2010-09-011-24/+0
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* | Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2010-08-3115-477/+457
|\|
| * get rid of CDebugDump classNikola Pajkovsky2010-08-303-123/+153
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
| * abrtlib.h: include <assert.h> and "strbuf.h"Denys Vlasenko2010-08-304-9/+3
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
| * preparatory patch for dirsize.cpp -> dirsize.c conversionDenys Vlasenko2010-08-301-5/+6
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
| * Use abrtlib.h instead of component header filesDenys Vlasenko2010-08-301-2/+1
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
| * consolidate HAVE_CONFIG_H in abrtlib.hDenys Vlasenko2010-08-306-18/+0
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>