summaryrefslogtreecommitdiffstats
path: root/src/plugins
Commit message (Collapse)AuthorAgeFilesLines
* abrt-action-generate-backtrace: exit with 0 even if the parser failsKarel Klic2011-02-041-1/+6
|
* abrt_rh_support: remove code which looks into Strata-Message: headerDenys Vlasenko2011-02-031-73/+4
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* abrt-cli -r DIR: copy non-writable DIR into $HOME/abrt/spoolDenys Vlasenko2011-02-011-0/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* rhtsupport reads from uninitialized variableNikola Pajkovsky2011-02-011-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | abrt-action-rhtsupport.c: In function ‘main’: abrt-action-rhtsupport.c:231:12: warning: ‘child’ may be used uninitialized in this function [-Wuninitialized] abrt-action-rhtsupport.c:45:11: note: ‘child’ was declared here ... ... pid_t child; ... ... if (!login[0] || !password[0]) { errmsg = _("Empty login or password, please check RHTSupport.conf"); goto ret; } ... ... ret: // Damn, selinux does not allow SIGKILLing our own child! wtf?? //kill(child, SIGKILL); /* just in case */ waitpid(child, NULL, 0); ... ... Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* Increase limit for gdb run, as it was reported that 60 secs is too limiting ↵Karel Klic2011-01-311-1/+2
| | | | on slow machines
* Rating 0 (worst) for backtrace on which the parser fails.Karel Klic2011-01-311-4/+10
|
* Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2011-01-252-14/+16
|\
| * split parse_release() into Bz and RHTS versionsDenys Vlasenko2011-01-251-3/+3
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
| * plug memory leak on error pathsDenys Vlasenko2011-01-251-1/+1
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
| * comment out unused function post_signatureDenys Vlasenko2011-01-251-0/+2
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
| * move block of code to eliminate a gotoDenys Vlasenko2011-01-251-10/+10
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* | don't try to remove the tmp dir if it's not createdJiri Moskovcak2011-01-251-3/+3
|/ | | | | - if no package is found the tmp dir is not created, but we tried to remove it anyway which failed
* add OPT_LIST mechanism to handle multiply occurring optionsDenys Vlasenko2011-01-206-114/+96
| | | | | | | This allowed to convert abrt-action-bugzilla, abrt-action-rhtsupport and abrt-action-kerneloops to parse_opts() Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* make option handling more regular across all toolsDenys Vlasenko2011-01-2011-81/+75
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* introduce and use new helper function list_free_with_freeDenys Vlasenko2011-01-201-3/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* remove old plugin machinery. -10k and -1 library dependence in abrtdDenys Vlasenko2011-01-193-369/+0
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* remove dumpoops and KerneloopsScanner pluginDenys Vlasenko2011-01-178-776/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* replace KerneloopsScanner plugin and dumpoops with abrt-dump-oops, use it in ↵Denys Vlasenko2011-01-172-0/+732
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | abrtd Patch adds new tool: $ abrt-dump-oops Usage: abrt-dump-oops [-vsrdow] FILE Extract oops from syslog/dmesg file -v, --verbose Be verbose -s Log to syslog -r Parse kernel's message buffer before parsing FILE -d Create ABRT dump for every oops found -o Print found oopses on standard output -w Do not exit, watch the file for new oopses It extends dumpoops. Extensions: * it can watch the syslog using -w option (uses inotify) * it can scan dmesg buffer too In this way, it also becomes a replacement for KerneloopsScanner plugin: oops-detecting logic is taken verbatim from KerneloopsScanner source. abrtd is changed to start it if it sees this directive in abrt.conf: [ LogScanners ] abrt-dump-oops = abrt-dump-oops -drw /var/log/messages Default abrt.conf is changed to have such line. Patch doesn't remove KerneloopsScanner plugin and dumpoops binary yet, I will do it in a separate trivial patch. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* trivial: more uniform -v option helpDenys Vlasenko2011-01-133-3/+3
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* move abrt-action-FOO from /usr/libexec to /usr/binDenys Vlasenko2011-01-111-13/+13
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* adding missing extern "C" {}Denys Vlasenko2011-01-061-0/+8
| | | | | | | This fixes the following problem: abrtd: Can't load '/usr/lib64/abrt/libKerneloopsScanner.so': /usr/lib64/abrt/libKerneloopsScanner.so: undefined symbol: _Z14extract_oopsesPP6_GListPcm Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* pass old pattern to ccpp hook and use itDenys Vlasenko2011-01-061-11/+44
| | | | | | | | | | | | | | | | | | | | | | | abrtd: instead of "|/usr/libexec/abrt-ccpp-hook DEBUG_DUMPS_DIR %p %s %u %c", sets coredump handler to "|/usr/libexec/abrt-ccpp-hook DEBUG_DUMPS_DIR %s %c %p %u %g %t %h %e OLD_PATTERN" abrt-ccpp-hook: expands OLD_PATTERN using values of %s %c %p %u %g %t %h %e and uses it as a name of "compat coredump". Patch has a feature which prevents usage of kernel-truncated OLD_PATTERN: it is passed as hex string *with terminating NUL* (encoded as 00). If ccpp hook doesn't see 00, it refuses to use OLD_PATTERN and uses string "core" instead. Run tested. On a new kernel, passes up to 27 char long old pattern. Longer patterns are still truncated. This may be improved in future kernels. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* koops: catch "kernel BUG at" with both small and capital K.Denys Vlasenko2011-01-041-12/+20
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* extend run_event() to run_event_on_dir_name() and run_event_on_crash_data()Denys Vlasenko2010-12-225-5/+5
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* *: rename *crash_dump.* -> *crash_data.*Denys Vlasenko2010-12-226-6/+6
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Rename foo_crash_dump_dir -> foo_dump_dirDenys Vlasenko2010-12-155-5/+5
| | | | | | | | | | | | | To be exact, these three functions are renamed: load_crash_data_from_crash_dump_dir create_crash_dump_dir delete_crash_dump_dir Rationale: data structure is called "struct dump_dir", not "struct crash_dump_dir" Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* rename a few more files from .cpp to .cDenys Vlasenko2010-12-097-18/+23
| | | | | | | | | | | | Renamed files: KerneloopsSysLog.c abrt-action-rhtsupport.c abrt-action-upload.c abrt-action-kerneloops.c abrt-action-mailx.c abrt-action-print.c Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* rename libabrt.so to libreport.soDenys Vlasenko2010-12-091-10/+10
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* create report-libs-devel package; separate out report headersDenys Vlasenko2010-12-091-23/+33
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* add abrt_ prefixes to abrt-internal functions in libabrt.soDenys Vlasenko2010-12-085-5/+5
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* removal of C++isms from libabrt, part 2Denys Vlasenko2010-12-082-14/+7
| | | | | | This patch rewrites a few places where we use C++ strings Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* removal of C++isms from libabrt, part 1Denys Vlasenko2010-12-088-139/+61
| | | | | | | | | | | | | This patch converts libabrt usage of C++ map<string, string> to a glib-based container, GHashTable. It is typedef-ed to map_string_h. We can't typedef it to map_string_t, since other parts of ABRT (daemon, cli) still use that name for C++ container. Also, exceptions are removed everywhere. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* remove unused function parse_args; make a few functions extern "C"Denys Vlasenko2010-12-071-3/+0
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* This patch changes crash data to use C structures.Denys Vlasenko2010-12-066-69/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The smallest data element is: struct crash_item { char *content; unsigned flags; }; where content is, eh, content, and flags is a bit flag field. crash_data_t is a map of crash_item's, implemented as a pointer to heap-allocated GHashTable. vector_of_crash_data_t is a vector of crash_data_t's, implemented as a pointer to heap-allocated GPtrArray. Most operations have light wrappers around them to hide the nature of the containers. For example, to free vector_of_crash_data, you need to use free_vector_of_crash_data(ptr) instead of open-coding g_ptr_array_free. The wrapper is thin. The goal is not so much to hide the implementation, but more to make it easier to use the correct function. dbus (un)marshalling functions convert crash_item to three-element array of strings, in order to keep compatibility with abrt-gui (python). This can be changed later to use native representation. crash_data_t and vector_of_crash_data_t are represented in "natural" way, no funny stuff there. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* new debuginfo install script rewritten in pythonJiri Moskovcak2010-11-293-422/+476
| | | | | | | | - using python alows us to use the yum API, so we can read the progress, file sizes, requires disk space, etc.. and seems to be faster the using yum --whatprovides + yumdownloader - it's easier to translate - we can drop dependency on yum-utils
* fix locking kerneloops conf file when -d not specifiedNikola Pajkovsky2010-11-291-1/+0
| | | | | | | when -c option is specified and -d option is not, keneloops locks his own confing file Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* preparatory patch for future factoring out of headers for reportlibDenys Vlasenko2010-11-266-11/+11
| | | | | | Some files and functions are renamed, no logic changes. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* abrt-action-rhtsupport: fix -c CONFFILE erroneously setting DUMPDIR tooDenys Vlasenko2010-11-261-1/+0
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* reorganize librariesDenys Vlasenko2010-11-267-34/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch does not change any code per se, it renames libABRTfoo -> libabrt_bar and moves a few functions around. After the patch, we are left with the following libs: libabrt - the stuff shared among most of abrt (like xmalloc, logging) libabrt_daemon - only daemon-related things are here (should probably be just moved into daemon - later) libabrt_dbus - daemon, cli and applet use this libabrt_web - abrt-action-foo where foo deals with network/web/ftp/... As a result, we have following reductions in dependent libs: /usr/libexec/abrt-hook-ccpp: linux-vdso.so.1 => () - libABRTUtils.so.0 => /usr/lib64/libABRTUtils.so.0 () + libabrt.so.0 => /usr/lib64/libabrt.so.0 () libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 () - libdbus-1.so.3 => /lib64/libdbus-1.so.3 () - libpthread.so.0 => /lib64/libpthread.so.0 () - librt.so.1 => /lib64/librt.so.1 () - libdl.so.2 => /lib64/libdl.so.2 () /usr/libexec/abrt-action-upload: linux-vdso.so.1 => () libtar.so.1 => /usr/lib64/libtar.so.1 () libcurl.so.4 => /usr/lib64/libcurl.so.4 () - libABRTdUtils.so.0 => /usr/lib64/libABRTdUtils.so.0 () - libABRTUtils.so.0 => /usr/lib64/libABRTUtils.so.0 () + libabrt.so.0 => /usr/lib64/libabrt.so.0 () libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 () - libdbus-1.so.3 => /lib64/libdbus-1.so.3 () Similar savings are in almost every abrt-action-foo. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* taint flag is decimal representation of a bitmaskNikola Pajkovsky2010-11-252-14/+76
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* abrt-action-install-debuginfo: removed generation of MISSING: stringDenys Vlasenko2010-11-241-5/+4
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* remove sqlite DBDenys Vlasenko2010-11-2314-870/+20
| | | | | | | | | | | | | | | | | | | | | | This change removes sqlite database. Database was used to find dump dirs by [UID:]UUID. This patch uses more natural way: dump dirs are addressed by their directory names. DB was also used to produce a list of dump dirs. Now it is done by iterating over the /var/spool/abrt directory. And finally, DB was also used to find duplicate UUIDs. Now it is done by iterating over the /var/spool/abrt directory. Crash count, "inform all" and reporting result message are moved from DB field to a file in dump dir. "Reported" DB field is deleted - if message != "", then this dump was reported. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* rhbz 623142Nikola Pajkovsky2010-11-222-0/+27
| | | | | | | Save tainted flag from /proc/sys/kernel/tainted. When flag is set to 1 TAINED string is added to bugzilla summary. Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* Merge branch 'remove-polkit'Nikola Pajkovsky2010-11-221-1/+0
|\ | | | | | | | | | | * remove-polkit: remove PLUGIN_DYNAMIC_LOAD_UNLOAD remove polkit
| * remove polkitNikola Pajkovsky2010-11-191-1/+0
| | | | | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* | Improve some comments. No code changesDenys Vlasenko2010-11-221-7/+9
| | | | | | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* | fix locking bugzilla conf file when -d not specifiedNikola Pajkovsky2010-11-191-1/+0
|/ | | | | | | when -c option is specified and -d option is not bugzilla locks his own confing file Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* move inc/ and lib/ to src/. No code changesDenys Vlasenko2010-11-151-42/+43
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Removed "old" Kerneloops and Python analyzers. They were emptyDenys Vlasenko2010-11-125-144/+2
| | | | | | Run-tested that python crashes are still caught Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* replace "old" Mailx plugin with new one. This is the last "old" reporter pluginDenys Vlasenko2010-11-124-207/+203
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>