summaryrefslogtreecommitdiffstats
path: root/src/applet
Commit message (Collapse)AuthorAgeFilesLines
* abrt-gtk: make Delete key actually delete the dump dirDenys Vlasenko2011-02-101-1/+0
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* use run_state->children_count == 0 check for "event not conf'd" conditionDenys Vlasenko2011-02-011-1/+1
| | | | | | | | | | | | run_event_on_FOO() was returning -1 when it found that not even one program was run on the requested event. Which is not a very natural return value: in many cases this isn't an error. This change makes it return 0 in this case. It is ok since now we have run_state->children_count member which can be checked for 0 by those callers which want to detect this condition. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* s/QuotaExceed/QuotaExceeded/gDenys Vlasenko2011-01-211-3/+3
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* trivial: more uniform -v option helpDenys Vlasenko2011-01-131-1/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* extend run_event() to run_event_on_dir_name() and run_event_on_crash_data()Denys Vlasenko2010-12-221-2/+2
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* *: rename *crash_dump.* -> *crash_data.*Denys Vlasenko2010-12-221-1/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* create_dump_dir: add base_dir_name parameter.Denys Vlasenko2010-12-161-1/+1
| | | | | | | | This makes python wrappers more usable. src/report-python/test_full demonstrates how pyhton programs can run reporting now. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Rename foo_crash_dump_dir -> foo_dump_dirDenys Vlasenko2010-12-151-2/+2
| | | | | | | | | | | | | To be exact, these three functions are renamed: load_crash_data_from_crash_dump_dir create_crash_dump_dir delete_crash_dump_dir Rationale: data structure is called "struct dump_dir", not "struct crash_dump_dir" Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* convert Applet.cpp to C. Needed only one change: dbus' load_val -> load_charpDenys Vlasenko2010-12-092-14/+14
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* move test app for libreport from c++ to CDenys Vlasenko2010-12-092-3/+4
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* rename libabrt.so to libreport.soDenys Vlasenko2010-12-091-2/+2
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* create report-libs-devel package; separate out report headersDenys Vlasenko2010-12-091-6/+6
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* This patch changes crash data to use C structures.Denys Vlasenko2010-12-061-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The smallest data element is: struct crash_item { char *content; unsigned flags; }; where content is, eh, content, and flags is a bit flag field. crash_data_t is a map of crash_item's, implemented as a pointer to heap-allocated GHashTable. vector_of_crash_data_t is a vector of crash_data_t's, implemented as a pointer to heap-allocated GPtrArray. Most operations have light wrappers around them to hide the nature of the containers. For example, to free vector_of_crash_data, you need to use free_vector_of_crash_data(ptr) instead of open-coding g_ptr_array_free. The wrapper is thin. The goal is not so much to hide the implementation, but more to make it easier to use the correct function. dbus (un)marshalling functions convert crash_item to three-element array of strings, in order to keep compatibility with abrt-gui (python). This can be changed later to use native representation. crash_data_t and vector_of_crash_data_t are represented in "natural" way, no funny stuff there. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* factor out headers so that "report lib" API is separated out of abrt APIDenys Vlasenko2010-12-012-0/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch minimally affects code per se - it adds create_crash_dump_dir() function which takes in-memory representation of the dump (map_crash_data_t object) and creates an on-disk representation. Then it returns pointer to struct dump_dir. With this function, it is possible to run an event on a user-constructed map_crash_data_t: map_crash_data_t cd; add_to_crash_data(cd, "foo", "bar"); struct dump_dir *dd = create_crash_dump_dir(cd); char *dir_name = strdup(dd->dd_dir); dd_close(dd); run_event(run_state, dir_name, event); delete_crash_dump_dir(dir_name); which is, basically, what report library is about. The biggest part of the patch is reshuffling of header files, with the following result: three header files which are not cluttered by other ABRT stuff, and expose the following API each: crash_dump.h - in-memory crash dump data structs and ops dump_dir.h - on-disk crash dump data structs and ops run_event.h - run_event() and friends These is a test application, test_report.cpp.cpp, which demonstrates (and tests) usage of these headers. (grep for "test-report" and enable it in build system if you want it to be built). It creates a temporary dump in /var/run/abrt/tmp-NNNN-NNNNN and runs "report" event. Deleting of temp dump is disabled for testing purposes - you might want to see the contents. Here is how the binary looks like: text data bss dec hex filename 3730 668 48 4446 115e /usr/bin/test-report linux-vdso.so.1 => (0x00007ffffa80f000) libabrt.so.0 => /usr/lib64/libabrt.so.0 (0x00007fad1f35e000) libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 (0x0000003c1f200000) libstdc++.so.6 => /usr/lib64/libstdc++.so.6 (0x0000003c2c200000) libm.so.6 => /lib64/libm.so.6 (0x00007fad1f0da000) libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x0000003c28e00000) libc.so.6 => /lib64/libc.so.6 (0x00007fad1ed5b000) /lib64/ld-linux-x86-64.so.2 (0x00007fad1f570000) Next step would be to clean up the namespace, then rename libabrt.so into libreport.so, then split it into a separate package so that we can install it without installing other two abrt .so files. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* reorganize librariesDenys Vlasenko2010-11-261-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch does not change any code per se, it renames libABRTfoo -> libabrt_bar and moves a few functions around. After the patch, we are left with the following libs: libabrt - the stuff shared among most of abrt (like xmalloc, logging) libabrt_daemon - only daemon-related things are here (should probably be just moved into daemon - later) libabrt_dbus - daemon, cli and applet use this libabrt_web - abrt-action-foo where foo deals with network/web/ftp/... As a result, we have following reductions in dependent libs: /usr/libexec/abrt-hook-ccpp: linux-vdso.so.1 => () - libABRTUtils.so.0 => /usr/lib64/libABRTUtils.so.0 () + libabrt.so.0 => /usr/lib64/libabrt.so.0 () libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 () - libdbus-1.so.3 => /lib64/libdbus-1.so.3 () - libpthread.so.0 => /lib64/libpthread.so.0 () - librt.so.1 => /lib64/librt.so.1 () - libdl.so.2 => /lib64/libdl.so.2 () /usr/libexec/abrt-action-upload: linux-vdso.so.1 => () libtar.so.1 => /usr/lib64/libtar.so.1 () libcurl.so.4 => /usr/lib64/libcurl.so.4 () - libABRTdUtils.so.0 => /usr/lib64/libABRTdUtils.so.0 () - libABRTUtils.so.0 => /usr/lib64/libABRTUtils.so.0 () + libabrt.so.0 => /usr/lib64/libabrt.so.0 () libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 () - libdbus-1.so.3 => /lib64/libdbus-1.so.3 () Similar savings are in almost every abrt-action-foo. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* fixed build against libnotify 0.7Jiri Moskovcak2010-11-251-0/+7
|
* move inc/ and lib/ to src/. No code changesDenys Vlasenko2010-11-151-3/+3
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Added DIR paramented to "Crash" dbus signalDenys Vlasenko2010-11-021-2/+12
| | | | | | Run-tested Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* consolidate HAVE_CONFIG_H in abrtlib.hDenys Vlasenko2010-08-302-6/+0
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* abrt_dbus: preparatory patch for C++ -> c conversionDenys Vlasenko2010-08-301-1/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* CCApplet.cpp -> applet_gtk.cNikola Pajkovsky2010-08-304-3/+11
| | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* remove unused std::map and std::stringNikola Pajkovsky2010-08-302-20/+0
| | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* make some function staticNikola Pajkovsky2010-08-302-179/+165
| | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* lower case variable in struct appletNikola Pajkovsky2010-08-303-84/+84
| | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* get rid of CApplet classNikola Pajkovsky2010-08-303-136/+136
| | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* *: move NLS include and #define _ to abrtlib.hDenys Vlasenko2010-08-172-15/+3
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* lower case direcotry(no code changed)Nikola Pajkovsky2010-08-105-0/+898
Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>