summaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* btparser initial integrationKarel Klic2010-10-146-1688/+0
|
* various small fixes to dd usageDenys Vlasenko2010-10-142-50/+27
| | | | | | | | | | | KerneloopsScanner: dd leak on error path in save_oops_to_debug_dump() dump_dir: remove superfluous exist_file_dir check in dd_opendir, dd_create, delete_file_dir; use perror_msg instead of error_msg; correct some sligtly wrong log/error messages; make delete_file_dir return void, since return value is never checked. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* dump_dir.c: reorder functions within the file without changing them.Denys Vlasenko2010-10-141-64/+61
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* move uuid generation for CCpp to a separate program (abrt-action-analyze-c)Denys Vlasenko2010-10-141-165/+31
| | | | | | | | | | | | | | | | | | | | | | | | | This patch splits off uuid generation for CCpp to a separate program: Usage: abrt-action-analyze-c [-v] -d DIR Calculates and saves UUID -v, --verbose be verbose -d DIR Crash dump directory Run tested. Thus, now entire cycle of coredump processing/reporting consists of external programs: abrt-action-analyze-c abrt-action-save-package-data abrt-action-install-debuginfo abrt-action-generate-backtrace abrt-action-bugzilla Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* trivial cleanupsDenys Vlasenko2010-10-131-1/+0
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* parse_options was not handling long options properly. fix it.Denys Vlasenko2010-10-121-14/+29
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Return a bitmask of found options from parse_opts()Denys Vlasenko2010-10-122-3/+9
| | | | | | | | | | | | | This patch makes it easier to analyze "bool" type options - now they are all just bits in a single return value, no need to have an integer variable for each option. The previous behavior is retained too: it is useful for "cumulative" options like -vvv. The patch also removes all OPT_GROUPs. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* move bugzilla reporting to a separate program (abrt-action-bugzilla)Denys Vlasenko2010-10-113-938/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch splits off Bugzilla plugin's bugzilla submission generation into a separate tool: abrt-action-bugzilla: invalid option -- 'z' Usage: abrt-action-bugzilla -c CONFFILE -d DIR [-vs] Report a crash to Bugzilla Options: -c FILE Configuration file (may be given many times) -d DIR Crash dump directory -v Verbose -s Log to syslog This change is bigger than previous similar patches: I needed to find a way to pass settings to the child and get back reporting result - all without breaking current interface. I decided to pass configuration via -c CONFFILE: (1) it is trivial to pass /etc/abrt/bugzilla.conf to it, and (2) I can use "-c -" to parse config from stdin. abrtd simply write per-reporting settings to child's stdin. The log and reporting result (success/failure) is taken from child's stdout. After a few more such patches, we can remove XMLRPC and HTTP code and library dependencies from abrtd. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* move load_crash_data_from_debug_dump from MiddleWare to CrashTypesDenys Vlasenko2010-10-111-0/+123
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* preparatory patch with trivial changes onlyDenys Vlasenko2010-10-112-2/+2
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* s/CD_DUPHASH/FILENAME_DUPHASH/gDenys Vlasenko2010-10-115-10/+10
| | | | | | | This is needed to make duplicate hash visible for separate programs looking at crash dumps. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* trivial: remove unused option_index'sDenys Vlasenko2010-10-081-2/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Remove arrays in usage text, use a single string insteadDenys Vlasenko2010-10-082-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | Currently, usage is an array of pointers to string. It is meant to support this: usage: foo --bar or: foo --baz or: foo -z The patch removes this and makes usage just a string: usage: foo --bar Why remove this? (1) We can achieve old format by using the usage string with many lines: usage = "foo --bar\n" " or: foo --baz\n" " or: foo -z"; (2) We don't use multi-line usage anyway. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* add --help option in parse_opts(), not at every call site.Denys Vlasenko2010-10-083-18/+26
| | | | | | | This patch removes the need to add --help option to every program. It is added (and handled) by parse_opts(). Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* add more logging about settings, and make it possible to load them from stdinDenys Vlasenko2010-10-071-4/+29
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* add a new helper function, full_write_str(fd,str)Denys Vlasenko2010-10-072-0/+7
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Kerneloops*.cpp and dumpoops.cpp uses GListNikola Pajkovsky2010-10-064-19/+26
| | | | | | vector_string_t was replaced by glist in these files Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* add OPT_GROUP optionNikola Pajkovsky2010-10-052-1/+14
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* add OPT__HELP macroNikola Pajkovsky2010-10-051-0/+1
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* add OPT__VERBOSE macroNikola Pajkovsky2010-10-051-0/+2
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* fix INTEGER optionNikola Pajkovsky2010-10-051-2/+1
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* remove < > around argument helpNikola Pajkovsky2010-10-051-1/+1
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* add INTEGER optionNikola Pajkovsky2010-10-052-0/+7
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* parse_options.c: add argument helpNikola Pajkovsky2010-10-052-2/+13
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* new args parserNikola Pajkovsky2010-10-043-1/+169
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* xfunc.c: add new funtion xcallocNikola Pajkovsky2010-10-041-0/+8
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* rename abrt-debuginfo-install to abrt-action-install-debuginfoDenys Vlasenko2010-09-231-5/+5
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* add two flags to dd_opendir()Nikola Pajkovsky2010-09-226-59/+19
| | | | | | | | | | | | | | | | | | | DD_CLOSE_ON_OPEN_ERR - free dump_dir structure when opening dump_dir does not exist DD_FAIL_QUIETLY - suppress message when dump directory does not exist VERB1 log(_("Unable to open debug dump '%s'"), pDebugDumpDir); is all removed because there is error_msg("'%s' does not exist", dd->dd_dir); in dd_opendir() which sometimes we don't want to print(DD_FAIL_QUIETLY) example: crash dump directory trimming code running concurrently. Second process may try to delete a directory which is already gone. it should not complain that it is missing. Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* This patch splits off CCpp's backtrace generation into a separate tool:Denys Vlasenko2010-09-201-221/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | $ abrt-action-generate-backtrace -z abrt-action-generate-backtrace: invalid option -- 'z' Usage: abrt-action-generate-backtrace -d DIR [-i DIR1:DIR2] [-t SECONDS] [-vs] Generate backtrace, its quality rating, hash, and crashed function Options: -d DIR Crash dump directory -i DIR1:DIR2 Additional debuginfo directories -t SECONDS Kill gdb if it runs for more than SECONDS -v Verbose -s Log to syslog This also allows for debugging and regression testing of abrt-action-generate-backtrace separately - it can be simply run from command-line. Also it provides a better fault isolation - crash in abrt-action-generate-backtrace does not take down abrtd. The code is based on CCpp.cpp. CCpp analyzer is made to spawn a child to do the backtrace generation. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* unhide dump_dir structure from typedefNikola Pajkovsky2010-09-207-27/+27
| | | | | | no other code changes Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* CCpp: better handling of uid and exit condition on bt generationDenys Vlasenko2010-09-161-5/+6
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* CCpp: plug a memory leakDenys Vlasenko2010-09-161-0/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* dump_dir: added TODO comment. no code changesDenys Vlasenko2010-09-151-0/+20
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* fixing two instances of dd->gid which I forgot to convertDenys Vlasenko2010-09-141-2/+2
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* dump_dir: use dd_ prefix on uid/gid fieldsDenys Vlasenko2010-09-141-8/+8
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* I noticed that ->locked and ->opened members are always the sameDenys Vlasenko2010-09-141-80/+18
| | | | | | | | | | | | | (either 0 or 1), and I decided to drop ->opened. And do a few other trivial optimizations/cleanups. While working on it, I noticed that dd_save_binary has "opened" check inverted, and that dd_create and dd_open are leaking dd->dd_dir on error path. So the patch turned from optimization to bugfix. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* CCpp: skip bt generation earlierDenys Vlasenko2010-09-141-18/+18
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* move sha1 to lib/utils; remove small bit of related C++isms in CCpp.cppDenys Vlasenko2010-09-145-49/+27
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* msg_prefix now doesn't need ": " suffixDenys Vlasenko2010-09-141-2/+5
| | | | | | Contains some other trivial changes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* s/NoSSLVerify/SSLVerify/gNikola Pajkovsky2010-09-141-1/+1
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* CCpp: make gdb timeout configurable; raise it to 120 sec in default config fileDenys Vlasenko2010-09-133-10/+19
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* dump_dir: dd_close was freeing unallocated pointer! fix thatDenys Vlasenko2010-09-131-1/+1
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* SQLite3.cpp: get rid of CABRTExceptionNikola Pajkovsky2010-09-101-22/+31
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* fix sigsegvNikola Pajkovsky2010-09-102-3/+32
| | | | | | | copy struct with char* lead to sigsegv. each char* needs to be duplicate. Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* plug a memory leak in trim_debug_dumps()Denys Vlasenko2010-09-101-0/+3
| | | | Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* SQLite3.cpp: replace std::vector by GListNikola Pajkovsky2010-09-085-57/+134
| | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* DebugDump.* -> dump_dir.*Nikola Pajkovsky2010-09-0716-16/+1
| | | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com> Acked-off-by: Jiri Moskovcak <jmoskovc@redhat.com>
* DebugDump.cpp: change error_msg to perror_msgMichal Toman2010-09-071-1/+1
|
* DebugDump.cpp: lower case variablesNikola Pajkovsky2010-09-021-36/+36
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
* DebugDump.cpp: lowercase and rename functionsNikola Pajkovsky2010-09-026-59/+59
| | | | Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>