Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | unify "crash data, "crash info" and "crash report" data types. they are the same | Denys Vlasenko | 2010-01-19 | 1 | -0/+1 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | RunApp: safer chdir. Overhauled "sparn a child and get its output" in general | Denys Vlasenko | 2010-01-11 | 1 | -1/+1 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | moved get_cmdline() and daemon_is_ok() to abrtlib | Karel Klic | 2009-12-18 | 1 | -0/+1 |
| | |||||
* | fix all instances of atoi() usage | Denys Vlasenko | 2009-12-15 | 1 | -0/+1 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | remove std::string usage from class CABRTException. | Denys Vlasenko | 2009-12-06 | 1 | -1/+2 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | build fixes | Jiri Moskovcak | 2009-12-03 | 1 | -4/+5 |
| | |||||
* | hookCCpp: check total dump dir size and delete the largest/oldest one | Denys Vlasenko | 2009-11-26 | 1 | -3/+5 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | split libABRTdUtils from libABRTUtils. This makes hooks _much_ smaller. | Denys Vlasenko | 2009-11-25 | 1 | -5/+24 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | disable compilation of the rest of socket code | Denys Vlasenko | 2009-11-12 | 1 | -1/+1 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | SOSreport.cpp: __gnu_cxx::stdio_filebuf<char> is +8k in code, thanks but no | Denys Vlasenko | 2009-11-12 | 1 | -1/+2 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | Factored ParseArg | Nikola Pajkovsky | 2009-11-12 | 1 | -0/+1 |
| | |||||
* | remove getSettings from most plugins (inherited one is ok) | Denys Vlasenko | 2009-11-10 | 1 | -0/+1 |
| | | | | | | | | | Also move parse_release() to abrtlib, it's shared among Bugzilla and Catcut. Tested Bugzilla and Catcut, both work. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | applied gavin's patch to Catcut. Refactored common xmlrpc code into lib/Utils. | Denys Vlasenko | 2009-11-09 | 1 | -0/+4 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | make_description_xxx: do not report empty fields | Denys Vlasenko | 2009-11-02 | 1 | -1/+1 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | lib/Plugins/Logger: much more sane dump format; fix misdetection of text files | Denys Vlasenko | 2009-10-30 | 1 | -1/+0 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | lib/Plugins/Bugzilla: generate less sparse bug report comments | Denys Vlasenko | 2009-10-30 | 1 | -1/+1 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | simplify base64 conversion | Denys Vlasenko | 2009-10-27 | 1 | -3/+6 |
| | | | | | | | | text data bss dec hexfilename 39575 2016 288 41879 old/libBugzilla.so 38598 1840 288 40726 new/libBugzilla.so Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | add bits of infrastructure needed for xmlprc code. | Denys Vlasenko | 2009-10-26 | 1 | -0/+3 |
| | | | | | | This does not affect existing code in any way. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | Move lib/Utils/DBusClientProxy.* to src/Applet/; do not link rpm to libABRTUtils | Denys Vlasenko | 2009-09-17 | 1 | -11/+8 |
| | | | | | | | | | | | | | | | | | | | | | As a result, we can drop these libs from libABRTUtils: libbz2.so.1 => /lib64/libbz2.so.1 (0x00007ff8934ef000) libdb-4.7.so => /lib64/libdb-4.7.so (0x00007ff8921ae000) libdbus-c++-1.so.0 => /usr/lib64/libdbus-c++-1.so.0 (0x00007ff895276000) libelf.so.1 => /usr/lib64/libelf.so.1 (0x00007ff8930c5000) liblua-5.1.so => /usr/lib64/liblua-5.1.so (0x00007ff892c7a000) liblzma.so.0 => /usr/lib64/liblzma.so.0 (0x00007ff892ea5000) libnspr4.so => /lib64/libnspr4.so (0x00007ff890ec2000) libnss3.so => /lib64/libnss3.so (0x00007ff892948000) libnssutil3.so => /lib64/libnssutil3.so (0x00007ff891505000) libplc4.so => /lib64/libplc4.so (0x00007ff891300000) libplds4.so => /lib64/libplds4.so (0x00007ff8910fd000) libpopt.so.0 => /lib64/libpopt.so.0 (0x00007ff89273f000) librpmio.so.0 => /usr/lib64/librpmio.so.0 (0x00007ff8954a8000) librpm.so.0 => /usr/lib64/librpm.so.0 (0x00007ff8956d9000) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | remove C++ dbus glue in src/CLI; fix a bug in --report | Denys Vlasenko | 2009-09-17 | 1 | -0/+1 |
| | | | | | | | Several kb of code removed. The nly remaining use of C++ glue is desktop applet. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | unify CommLayer, MiddleWare and Utils into Utils | Denys Vlasenko | 2009-09-15 | 1 | -12/+35 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | Polkit moved to Utils (can be used both in daemon and plugins) | dnovotny | 2009-09-14 | 1 | -3/+5 |
| | |||||
* | simplify C/C++ hook | Denys Vlasenko | 2009-08-05 | 1 | -1/+2 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | move huge inlines out-of-line | Denys Vlasenko | 2009-08-05 | 1 | -0/+1 |
| | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | KerneloopsReporter: plug a leak in writefunction | Denys Vlasenko | 2009-07-31 | 1 | -1/+6 |
| | | | | | | Also some preparatory cleanups for future dumpoops patch are included Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | add utility functions | Denys Vlasenko | 2009-07-30 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Logging machinery provided by this patch consists of several functions: +extern void error_msg(const char *s, ...) __attribute__ ((format (printf, 1, 2))); +extern void error_msg_and_die(const char *s, ...) __attribute__ ((noreturn, format (printf, 1, 2))); +extern void perror_msg(const char *s, ...) __attribute__ ((format (printf, 1, 2))); +extern void perror_msg_and_die(const char *s, ...) __attribute__ ((noreturn, format (printf, 1, 2))); +/* This is a macro since it collides with log() from math.h */ +#undef log +#define log(...) error_msg(__VA_ARGS__) They are taking printf-style format strings. perror_msg_xxx functions append an errno string after the message: "xxx xxx xxx: No such file or directory" if errno is != 0. xxx_and_die functions do not return. All functions also ensure that the message ends with "\n", meaning that you do not need to add it into the message, but if you do, an extra "\n" will not be added. All functions ensure that the string is written in a single write() call, thus if two processes output to the same terminal or file, messages don't get intermingled. Ordinarily, messages go to the stderr. By setting global variable "logmode" to LOGMODE_SYSLOG or LOGMODE_NONE, they can be sent to syslog or be suppressed. Standard setting is LOGMODE_STDIO. LOGMODE_STDIO + LOGMODE_SYSLOG works too. Usually it is set by main() as needed, and then you can fearlessly use [p]error_msg[_and_die]() and be sure that message goes to the right place. +enum { + LOGMODE_NONE = 0, + LOGMODE_STDIO = (1 << 0), + LOGMODE_SYSLOG = (1 << 1), + LOGMODE_BOTH = LOGMODE_SYSLOG + LOGMODE_STDIO, +}; +extern int logmode; Exit code of xxx_and_die variants is controlled by the global variable +extern int xfunc_error_retval; By default it is = 1. Logging infrastructure uses a few other functions, which I find useful on their own, and since I discussed them with Zdenek and he thinks that they may be useful too, they are included in the patch also. The first group is "malloc or die" group: +void* malloc_or_warn(size_t size); +void* xmalloc(size_t size); +void* xrealloc(void *ptr, size_t size); +void* xzalloc(size_t size); +char* xstrdup(const char *s); +char* xstrndup(const char *s, int n); They are basically versions of malloc etc which exit on failure. The next group are simple I/O wrappers: +extern ssize_t safe_read(int fd, void *buf, size_t count); +extern ssize_t full_read(int fd, void *buf, size_t count); +extern void xread(int fd, void *buf, size_t count); +extern ssize_t safe_write(int fd, const void *buf, size_t count); +extern ssize_t full_write(int fd, const void *buf, size_t count); safe_xxx deal with the fact that read and write operations may "fail" with EINTR and in many cases we want to just repeat the operation. full_xxx deal with the fact that read and write are not guaranteed to read or write exact amount, they may to transfer less bytes. In this case we need to loop. The next group are the "x functions": +extern void xwrite(int fd, const void *buf, size_t count); +extern void xwrite_str(int fd, const char *str); +void xpipe(int filedes[2]); +void xdup2(int from, int to); +off_t xlseek(int fd, off_t offset, int whence); +void xsetenv(const char *key, const char *value); +int xsocket(int domain, int type, int protocol); +void xbind(int sockfd, struct sockaddr *my_addr, socklen_t addrlen); +void xlisten(int s, int backlog); +ssize_t xsendto(int s, const void *buf, size_t len, const struct sockaddr *to, socklen_t tolen); +void xstat(const char *name, struct stat *stat_buf); +void xmove_fd(int from, int to); +char* xasprintf(const char *format, ...); They are similar to xmalloc in a sense that they exit on the failure. Most of them closely resemble corresponding libc functions. xmove_fd() is a wrapper for typical idiom "if (fd1!=fd2) dup2(fd1,fd2)", with error checking on dup2 failure added. xasprintf() is a "strcat on steroids". It's a printf-like function which returns a malloced string. In my experience, it is surprisingly useful: it makes complex concatenations easy in C. All these functions are declared in a new header, inc/abrtlib.h. It also contains a list of #includes: +#include <ctype.h> +#include <dirent.h> +#include <errno.h> +#include <fcntl.h> +#include <inttypes.h> +#include <setjmp.h> +#include <signal.h> +#include <stdio.h> +#include <stdlib.h> +#include <stdarg.h> +#include <stddef.h> +#include <string.h> +#include <sys/poll.h> +#include <sys/mman.h> +#include <sys/socket.h> +#include <sys/stat.h> +#include <sys/time.h> +#include <sys/types.h> +#include <sys/wait.h> +#include <termios.h> +#include <time.h> +#include <unistd.h> +/* Try to pull in PATH_MAX */ +#include <limits.h> +#include <sys/param.h> +#ifndef PATH_MAX +# define PATH_MAX 256 +#endif +#include <pwd.h> +#include <grp.h> The rationale to do so is that these headers are pretty standard, and by having them included in this one file, we won't need to add #includes into many .c[pp] files later. The slowdown from gcc parsing these headers even if they are not needed is not worth spending time on optimizing out. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> | ||||
* | fixed security issue | Zdenek Prikryl | 2009-06-30 | 1 | -1/+2 |
| | | | | User can read only his debugdump directories | ||||
* | weak reference to commlayerinner | Zdenek Prikryl | 2009-04-29 | 1 | -1/+1 |
| | |||||
* | new commlayerinner interface | Zdenek Prikryl | 2009-04-28 | 1 | -0/+1 |
| | |||||
* | renamed MW library | Zdenek Prikryl | 2009-04-08 | 1 | -4/+4 |
| | | | | | | renamed Utils library added check for plugins init method renamed crash types | ||||
* | added new interface frof settings | Zdenek Prikryl | 2009-04-02 | 1 | -1/+1 |
| | |||||
* | rewritten CDebugDump and CrashTypes | Zdenek Prikryl | 2009-04-01 | 1 | -0/+1 |
| | |||||
* | replaced language and application plugins by analyzer plugin | Zdenek Prikryl | 2009-03-19 | 1 | -1/+1 |
| | | | | | added action plugin simplify plugin iface | ||||
* | removed packagekit | Zdenek Prikryl | 2009-02-19 | 1 | -4/+2 |
| | |||||
* | added rpm stuff | Zdenek Prikryl | 2009-02-12 | 1 | -2/+2 |
| | |||||
* | DebugDump can get package name now | Zdenek Prikryl | 2009-02-05 | 1 | -1/+3 |
| | |||||
* | makefile | Zdenek Prikryl | 2009-02-05 | 1 | -0/+6 |