summaryrefslogtreecommitdiffstats
path: root/lib/Utils/DebugDump.cpp
Commit message (Collapse)AuthorAgeFilesLines
* fix whitespaceDenys Vlasenko2010-05-311-1/+1
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* add ProcessUnpackaged option to abrt.confDenys Vlasenko2010-03-051-17/+17
| | | | | | Based on patch by Pekka Pietikainen <pp@ee.oulu.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* *: UID:UUID -> crash_id conversionDenys Vlasenko2010-03-041-1/+1
| | | | | | | | | | | | | | | | | | | This fixes at least three instances where we did not check whether user is even allowed to report or delete a crash. Also fixes a few cases when root might inadvertently act on (e.g. delete) mote than one crash. Renamed FILENAME_UID to CD_UID - makes more sense this way. Added COL_INFORMALL and CD_INFORMALL. Nuked UID == -1 hacks. Renamed getReport() to start_job on Python side. Dropped a few unused parameters from server -> client dbus signals. Fixed CLI's way of reverencing crashes (see updated help text). Run-tested (GUI and CLI). Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> Acked-by: Nikola Pajkovsky <npajkovs@redhat.com>
* *: remove all usages of C++ streams (-10k in code size)Denys Vlasenko2010-02-071-9/+5
| | | | | | Also add copyright banners to all files which were missing them Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* Fixing /var/cache/abrt/ permissions by allowing users to read, but not to ↵Karel Klic2010-01-121-20/+31
| | | | change their crash data. Adds abrt user, changes abrt-hook-python to use suid instead of sgid bit (uid=abrt), sets /var/cache/abrt and every dump subdirectory to be owned by abrt user. Read access for users and their own crashes is provided by group (/var/cache/abrt/ccpp-xxxx-xx has user's group).
* DebugDump: more consistent logic in setting mode and uid:gid on dump dirDenys Vlasenko2010-01-111-18/+53
| | | | | | | | With comments! yay. Before it, too restrictive mode was preventing python craches to be handled. Signed-off-by: Karel Klic <kklic@redhat.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* *: assorted fixes prompted by security analysis; more to comeDenys Vlasenko2010-01-111-1/+1
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* *: misc fixesDenys Vlasenko2010-01-111-1/+9
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* *: cast pids and uigs to long, not intDenys Vlasenko2010-01-111-3/+3
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* DebugDump: use more restrictive modesDenys Vlasenko2010-01-111-3/+14
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* prevent destructors from throwing exceptions; check curl_easy_init errorsDenys Vlasenko2009-12-161-0/+16
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* abrtd: add comment about ccpp/abrtd raceDenys Vlasenko2009-12-101-1/+1
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* remove std::string usage from class CABRTException.Denys Vlasenko2009-12-061-13/+13
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* hookCCpp: check total dump dir size and delete the largest/oldest oneDenys Vlasenko2009-11-261-17/+30
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* make BZ insert small text attachments inline; move text file detection codeDenys Vlasenko2009-11-191-83/+7
| | | | | | Run-tested Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* add experimental saving of /var/log/Xorg*.log for X crashesDenys Vlasenko2009-11-161-4/+4
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* make IsTextFile more cleverDenys Vlasenko2009-11-091-7/+21
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* continuing s/string&/char*/ bit-by-bitDenys Vlasenko2009-11-091-8/+8
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* mass replace of const string& params by const char*Denys Vlasenko2009-11-061-109/+44
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* const string& -> const char* conversionDenys Vlasenko2009-11-051-14/+11
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* uint64_t changed to int64_tNikola Pajkovsky2009-11-031-1/+1
|
* kerneloop has uid = -1 newNikola Pajkovsky2009-11-031-2/+2
|
* lib/Plugins/CCpp: respect DebugInfoCacheMB settingDenys Vlasenko2009-11-021-11/+0
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* lib/Plugins/Logger: much more sane dump format; fix misdetection of text filesDenys Vlasenko2009-10-301-3/+23
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* Bugzilla: simplify; CCpp, DebugDump: don't add EOL to one-line data filesDenys Vlasenko2009-10-301-0/+3
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* DebugDump: change directory locking code to use symlinks.Denys Vlasenko2009-10-291-12/+52
| | | | | | | closes race window, see https://bugzilla.redhat.com/show_bug.cgi?id=531347 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* fix all instances of dent->d_type == DT_REG checksDenys Vlasenko2009-09-301-10/+4
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* reduce verbosity a bitDenys Vlasenko2009-09-211-2/+2
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* remove a few #include <iostream>'sDenys Vlasenko2009-09-181-1/+0
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* remove a few C++-isms where they did not buy any convenience anywayDenys Vlasenko2009-09-181-6/+1
| | | | | | | | | | | | text data bss dec hex filename 182372 2624 2320 187316 2dbb4 abrt.t2/abrt-0.0.8.5/src/Daemon/.libs/abrtd 180635 2584 1968 185187 2d363 abrt.t3/abrt-0.0.8.5/src/Daemon/.libs/abrtd 34110 1340 768 36218 8d7a abrt.t2/abrt-0.0.8.5/src/CLI/.libs/abrt-cli 30202 1292 224 31718 7be6 abrt.t3/abrt-0.0.8.5/src/CLI/.libs/abrt-cli 22116 1688 376 24180 5e74 abrt.t2/abrt-0.0.8.5/src/Applet/.libs/abrt-applet 21254 1648 88 22990 59ce abrt.t3/abrt-0.0.8.5/src/Applet/.libs/abrt-applet Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* fix the bug where lock file was not removedDenys Vlasenko2009-09-091-0/+9
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* GetAndSetLock: simplify. old code was racyDenys Vlasenko2009-09-091-29/+39
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* remove unnecessary variable from last commitDenys Vlasenko2009-09-091-2/+1
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* eliminate CDebugDump::m_bUnlock, m_nLockfileFD can be used insteadDenys Vlasenko2009-09-091-38/+35
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* make GetNextFile close directory fd when the search is overDenys Vlasenko2009-09-091-20/+21
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* four more more string& -> char* conversions. -2kDenys Vlasenko2009-09-091-5/+5
| | | | | | | | text data bss dec hex filename 188660 2776 2320 193756 2f4dc abrt.t5/abrt-0.0.8.5/src/Daemon/.libs/abrtd 186751 2776 2320 191847 2ed67 abrt.t6/abrt-0.0.8.5/src/Daemon/.libs/abrtd Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* replace one const string& parameter with const char*. almost -1k of code (!)Denys Vlasenko2009-09-091-1/+1
| | | | | | | | text data bss dec hex filename 189533 2776 2320 194629 2f845 abrt.t4/abrt-0.0.8.5/src/Daemon/.libs/abrtd 188660 2776 2320 193756 2f4dc abrt.t6/abrt-0.0.8.5/src/Daemon/.libs/abrtd Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* replace comm_layer_inner_debug() with log() everywhereDenys Vlasenko2009-08-261-18/+8
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* CDebugDump::Create(pDir, pUID): make 2nd param uid_t, not stringDenys Vlasenko2009-08-051-3/+2
|
* do not abort if chown fails, just warnDenys Vlasenko2009-08-051-16/+7
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* made some functions staticDenys Vlasenko2009-08-041-47/+53
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* add error checks on lstat calls; add handling of DT_UNKNOWNDenys Vlasenko2009-08-041-11/+15
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* Merge branch 'master' of git://git.fedorahosted.org/abrtZdenek Prikryl2009-07-241-21/+3
|\
| * remove GetGIDFromUID (two copies): getpwuid does the sameDenys Vlasenko2009-07-241-21/+3
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | proper deinit of libmagicZdenek Prikryl2009-07-241-2/+2
|/
* Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2009-07-221-15/+19
|\
| * fix several resource leaks on error pathsDenys Vlasenko2009-07-221-15/+19
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | Utils: small fixJiri Moskovcak2009-07-221-1/+1
|/
* fixed security issueZdenek Prikryl2009-06-301-4/+39
| | | | User can read only his debugdump directories
* addded removing useless back slashed from debug dump dir nameZdenek Prikryl2009-05-281-9/+19
|