summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* fix compile-time warnings.Denys Vlasenko2009-08-098-17/+29
| | | | | | | One fix (in CCrashWatcher::GetPluginsInfo) needs closer look, others are "trivially correct" Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* style fixes, no code changesDenys Vlasenko2009-08-095-16/+17
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* replace string memebers of plugin_info_t with const char*Denys Vlasenko2009-08-073-68/+72
| | | | | | | | | | Since they are constant, and we never ever want to change them, there is no benefit in having them as strings. This change removes one global data object's constructor and destructor from every applet .so module. 6k less code. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* simplify logging by removing CCommLayerInner classDenys Vlasenko2009-08-075-125/+19
| | | | | | | | It had single use site. The class itself is trivial, it just passed messages down to an CObserver. Now we pass messages directly to an CObserver. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* fix a bug where kerneloops scanner forgets to delete .lock filesDenys Vlasenko2009-08-071-0/+1
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* preparatory cleanupsDenys Vlasenko2009-08-072-10/+10
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* Split real code from lib/MiddleWare/Plugin.h into Plugin.cpp.Denys Vlasenko2009-08-078-94/+106
| | | | | | 30k smaller code. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* fix bug 54: make abrt (without -d) report initialization errorsDenys Vlasenko2009-08-061-6/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example (strace): 10053 17:18:58.384259 close(0) = 0 10053 17:18:58.384293 open("/dev/null", O_RDWR) = 0 child is created: 10053 17:18:58.384354 clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7f50eea1c880) = 10054 parent sleeps, child initializes: 10053 17:18:58.384678 nanosleep({0, 100000000}, <unfinished ...> 10054 17:18:58.384751 setsid() = 10054 10054 17:18:58.384794 close(1) = 0 10054 17:18:58.384828 close(2) = 0 10054 17:18:58.384870 dup(0) = 1 10054 17:18:58.384901 dup(0) = 2 10054 17:18:58.385099 open("/usr/app/abrt-TEST/var/etc/abrt/abrt.conf", O_RDONLY) = 3 ... 10054 17:18:58.449108 inotify_init() = 4 10054 17:18:58.449148 inotify_add_watch(4, "/usr/app/abrt-TEST/var/cache/abrt", IN_CREATE) = 1 10054 17:18:58.449228 fstat(4, {st_mode=S_IFDIR|0600, st_size=0, ...}) = 0 10054 17:18:58.449288 fcntl(4, F_GETFL) = 0 (flags O_RDONLY) child: initialization is done, it signals parent: 10054 17:18:58.449346 getppid() = 10053 10054 17:18:58.449380 kill(10053, SIGTERM) = 0 10054 17:18:58.449427 write(1, "Debug: Running...\n"..., 18 <unfinished ...> 10053 17:18:58.449447 <... nanosleep resumed> 0) = ? ERESTART_RESTARTBLOCK (To be restarted) 10054 17:18:58.449470 <... write resumed> ) = 18 10054 17:18:58.449494 open("/usr/app/abrt-TEST/var/run/abrt.lock", O_RDWR|O_CREAT, 0640 <unfinished ...> 10053 17:18:58.449517 --- SIGTERM (Terminated) @ 0 (0) --- 10054 17:18:58.449565 <... open resumed> ) = 5 10053 17:18:58.449583 rt_sigreturn(0xf <unfinished ...> 10054 17:18:58.449607 fcntl(5, F_SETLK, {type=F_WRLCK, whence=SEEK_CUR, start=0, len=0} <unfinished ...> sleep(100ms) is interrupted: 10053 17:18:58.449629 <... rt_sigreturn resumed> ) = -1 EINTR (Interrupted system call) 10054 17:18:58.449664 <... fcntl resumed> ) = 0 10054 17:18:58.449688 unlink("/usr/app/abrt-TEST/var/run/abrt.pid" <unfinished ...> parent exits 0 because it got TERM which means child is ok: 10053 17:18:58.449713 exit_group(0) = ? ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* silly whitespace fixDenys Vlasenko2009-08-061-1/+1
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* Merge branch 'master' of ssh://vda@git.fedorahosted.org/git/abrtDenys Vlasenko2009-08-069-3/+50
|\
| * Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2009-08-066-2/+2
| |\
| * \ Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2009-08-0648-878/+1274
| |\ \ | | | | | | | | | | | | | | | | Conflicts: lib/CommLayer/DBusServerProxy.h
| * | | DBUS: added method GetPluginsInfo()Jiri Moskovcak2009-08-067-3/+48
| | | |
| * | | PYHOOK: re-raise the exception, so the hook doesn't change the default ↵Jiri Moskovcak2009-08-061-1/+1
| | | | | | | | | | | | | | | | behaviour.
* | | | fix vda's breakage: coredumps should be 644, not 600Denys Vlasenko2009-08-061-1/+5
| |_|/ |/| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | | move lib/MiddleWare/{ABRTPlugin,DynamicLibrary}.* to src/Daemon/Denys Vlasenko2009-08-066-2/+2
| |/ |/|
* | fix a case when we print a warning twice.Denys Vlasenko2009-08-063-13/+16
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | dynamic_cast<> seems to be misbehaving. Disabling it for now.Denys Vlasenko2009-08-061-4/+4
| | | | | | | | | | | | abrt daemon is SEGVing without this Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | move lib/MiddleWare/PluginManager.* -> src/Daemon/PluginManager.*Denys Vlasenko2009-08-064-1/+1
| | | | | | | | | | | | This reduces code size by 14k. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | style cleanups in preparation for PluginManager moveDenys Vlasenko2009-08-063-86/+91
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | move huge inlines out of DBusClientProxy.h to DBusClientProxy.cppDenys Vlasenko2009-08-066-198/+286
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | deinline 2k+ big inlines in DBusServerProxy.h. No logic changesDenys Vlasenko2009-08-063-179/+248
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | forgotten "git add"Denys Vlasenko2009-08-062-0/+964
| |
* | moving MiddleWare.{h,cpp} from lib/MiddleWare/ to src/Daemon/Denys Vlasenko2009-08-064-981/+19
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | prepare makefiles for code movement between dirs. no code changesDenys Vlasenko2009-08-062-15/+33
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | trailing whitespace removal. no code changesDenys Vlasenko2009-08-0627-152/+162
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | CDebugDump::Create(pDir, pUID): make 2nd param uid_t, not stringDenys Vlasenko2009-08-055-11/+10
| |
* | Hooks/CCpp.cpp: don't dump executables with "/abrt" substring in the nameDenys Vlasenko2009-08-053-38/+88
| | | | | | | | | | | | some cleanups and abrtlib work crept in too... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | open with O_CREAT must have 3 args, fixing thatDenys Vlasenko2009-08-051-1/+1
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | do not abort if chown fails, just warnDenys Vlasenko2009-08-051-16/+7
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | forgot to add lib/Utils/copyfd.cppDenys Vlasenko2009-08-051-0/+107
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | simplify C/C++ hookDenys Vlasenko2009-08-053-76/+55
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | move huge inlines out-of-lineDenys Vlasenko2009-08-053-119/+192
|/ | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* made some functions staticDenys Vlasenko2009-08-045-68/+64
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* remove redundant virtual destructors definitionsDenys Vlasenko2009-08-0416-30/+3
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* dumpoops: hopefully fix KerneloopsScanner plugin usageDenys Vlasenko2009-08-043-4/+49
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* typo fix: s/Plugis/Plugins/gDenys Vlasenko2009-08-044-21/+23
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2009-08-042-25/+35
|\
| * add error checks on lstat calls; add handling of DT_UNKNOWNDenys Vlasenko2009-08-042-25/+35
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | SPEC: added *.GTKBuilder files to rpmJiri Moskovcak2009-08-041-0/+4
|/
* GUI: minor fix to center the error dialog on parent.Jiri Moskovcak2009-08-041-1/+2
|
* GUI: added error dialog if creating report fails.Jiri Moskovcak2009-08-041-1/+1
|
* Minor fixes - just to make sources compile.Jiri Moskovcak2009-08-043-13/+13
|
* use vasprintf in SetIconTooltip instead of open-coding itDenys Vlasenko2009-08-041-32/+30
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* abrt-applet: reset SIGCHLD before launching abrt-guiDenys Vlasenko2009-08-041-0/+1
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* abrt-applet: set SIGCHLD to SIG_IGN to prevent zombies from guiDenys Vlasenko2009-08-044-64/+70
| | | | | | | Also, running abrt-gui via popen is definiely wrong. We were leaking a FILE! fixed now. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* lib/Plugins/CCpp.cpp: move functions out of class where appropriate.Denys Vlasenko2009-08-032-33/+17
| | | | | | | | | | | | | | | | | | | I was struggling to read the code where classes have member functions with no apparent reasons to be such: they do not use any members of the class. Having them members of the class have only disadvantages: they need to be declared in the class (thus you need to touch TWO files), they cannot be shared among different classes, they look confusing at callsites - the code falsely suggests that function uses or alters object's state, they also are a bit less efficient. I was hesitating to do so before, but now I was told that there is a plan to gradually move to C implementation... then this change makes it a bit closer to that. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* simplify parameter/return value passing for boolsDenys Vlasenko2009-08-034-4/+4
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* DBus: Many fixes to client -> cli works again, changed JobDone notificationJiri Moskovcak2009-08-0312-56/+124
|
* delete semicolon in "if (expr); stmt;" , autodetect dmesg/syslogDenys Vlasenko2009-07-313-12/+29
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
generated by cgit (git 2.34.1) at 2025-10-02 15:52:22 +0000