diff options
| author | Denys Vlasenko <vda.linux@googlemail.com> | 2010-01-11 12:12:53 +0100 |
|---|---|---|
| committer | Denys Vlasenko <vda.linux@googlemail.com> | 2010-01-11 12:12:53 +0100 |
| commit | 20645ae11a8a9a89cc712896b2f72a25bc62c8db (patch) | |
| tree | d690f80802f03d1895c5dc3a7a04c7ceef0d1518 /src/Hooks | |
| parent | edf6beb585dc38c365ccbdaae85756b2814e1329 (diff) | |
| download | abrt-20645ae11a8a9a89cc712896b2f72a25bc62c8db.tar.gz abrt-20645ae11a8a9a89cc712896b2f72a25bc62c8db.tar.xz abrt-20645ae11a8a9a89cc712896b2f72a25bc62c8db.zip | |
DebugDump: more consistent logic in setting mode and uid:gid on dump dir
With comments! yay.
Before it, too restrictive mode was preventing python craches to be handled.
Signed-off-by: Karel Klic <kklic@redhat.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'src/Hooks')
| -rw-r--r-- | src/Hooks/CCpp.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/Hooks/CCpp.cpp b/src/Hooks/CCpp.cpp index ea08baeb..21fe0be7 100644 --- a/src/Hooks/CCpp.cpp +++ b/src/Hooks/CCpp.cpp @@ -216,6 +216,10 @@ int main(int argc, char** argv) dd.Close(); perror_msg_and_die("can't open '%s'", path); } +//TODO: chown to uid:abrt? +//Currently it is owned by 0:0 but is readable by anyone, so the owner +//of the crashed binary still can access it, as he has +//r-x access to the dump dir. core_size = copyfd_eof(STDIN_FILENO, core_fd); if (core_size < 0 || fsync(core_fd) != 0) { |