lib/Plugins/CCpp: respect DebugInfoCacheMB setting

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

7 files changed, 116 insertions, 30 deletions

diff --git a/lib/Plugins/CCpp.conf b/lib/Plugins/CCpp.conf
index 2139274a..988ddf32 100644
--- a/lib/Plugins/CCpp.conf
+++ b/lib/Plugins/CCpp.conf
@@ -8,9 +8,10 @@ MemoryMap = no
 ## (IGNORED FOR NOW)
 DebugInfo = install
 
-## (IGNORED FOR NOW)
-DebugInfoCacheMB = 4000
+# If this option is set to "yes",
+# debuginfos will be installed to @@LOCALSTATEDIR@@/cache/abrt-di
+InstallDebugInfo = yes
 
-# With this option set to "yes"
-# will be installed debuginfo
-InstallDebuginfo = yes
+# Keep @@LOCALSTATEDIR@@/cache/abrt-di
+# from growing out-of-bounds.
+DebugInfoCacheMB = 4000
diff --git a/lib/Plugins/CCpp.cpp b/lib/Plugins/CCpp.cpp
index 1d5b79d1..2fc8f0ad 100644
--- a/lib/Plugins/CCpp.cpp
+++ b/lib/Plugins/CCpp.cpp
@@ -33,16 +33,18 @@
 #include "CommLayerInner.h"
 #include "Polkit.h"
 
-#define CORE_PATTERN_IFACE "/proc/sys/kernel/core_pattern"
-#define CORE_PATTERN "|"CCPP_HOOK_PATH" "DEBUG_DUMPS_DIR" %p %s %u"
+#define CORE_PATTERN_IFACE      "/proc/sys/kernel/core_pattern"
+#define CORE_PATTERN            "|"CCPP_HOOK_PATH" "DEBUG_DUMPS_DIR" %p %s %u"
 
 #define FILENAME_COREDUMP       "coredump"
 #define FILENAME_BACKTRACE      "backtrace"
 #define FILENAME_MEMORYMAP      "memorymap"
 
+#define DEBUGINFO_CACHE_DIR     LOCALSTATEDIR"/cache/abrt-di"
+
 CAnalyzerCCpp::CAnalyzerCCpp() :
     m_bMemoryMap(false),
-    m_bInstallDebuginfo(true),
+    m_bInstallDebugInfo(true),
     m_nDebugInfoCacheMB(4000)
 {}
 
@@ -245,7 +247,7 @@ static void GetBacktrace(const std::string& pDebugDumpDir, std::string& pBacktra
     // when/if gdb supports it:
     // (https://bugzilla.redhat.com/show_bug.cgi?id=528668):
     args[2] = (char*)"-ex";
-    args[3] = (char*)"set debug-file-directory /usr/lib/debug:" LOCALSTATEDIR"/cache/abrt-di/usr/lib/debug";
+    args[3] = (char*)"set debug-file-directory /usr/lib/debug:" DEBUGINFO_CACHE_DIR"/usr/lib/debug";
     /*
      * Unfortunately, "file BINARY_FILE" doesn't work well if BINARY_FILE
      * was deleted (as often happens during system updates):
@@ -675,8 +677,8 @@ static void InstallDebugInfos(const std::string& pDebugDumpDir, std::string& bui
         /* SELinux guys are not happy with /tmp, using /var/run/abrt */
         char *tempdir = xasprintf(LOCALSTATEDIR"/run/abrt/tmp-%u-%lu", (int)getpid(), (long)time(NULL));
         /* log() goes to stderr/syslog, it's ok to use it here */
-        VERB1 log("Executing: %s %s %s %s", "abrt-debuginfo-install", coredump, tempdir, LOCALSTATEDIR"/cache/abrt-di");
-        execlp("abrt-debuginfo-install", "abrt-debuginfo-install", coredump, tempdir, LOCALSTATEDIR"/cache/abrt-di", NULL);
+        VERB1 log("Executing: %s %s %s %s", "abrt-debuginfo-install", coredump, tempdir, DEBUGINFO_CACHE_DIR);
+        execlp("abrt-debuginfo-install", "abrt-debuginfo-install", coredump, tempdir, DEBUGINFO_CACHE_DIR, NULL);
         exit(1);
     }
 
@@ -722,9 +724,67 @@ static void InstallDebugInfos(const std::string& pDebugDumpDir, std::string& bui
     wait(NULL);
 }
 
+static double get_dir_size(const char *dirname, std::string *worst_file, double *maxsz)
+{
+    DIR *dp = opendir(dirname);
+    if (dp == NULL)
+        return 0;
+
+    struct dirent *ep;
+    struct stat stats;
+    double size = 0;
+    while ((ep = readdir(dp)) != NULL)
+    {
+        if (dot_or_dotdot(ep->d_name))
+            continue;
+        std::string dname = concat_path_file(dirname, ep->d_name);
+        if (lstat(dname.c_str(), &stats) != 0)
+            continue;
+        if (S_ISDIR(stats.st_mode))
+        {
+            double sz = get_dir_size(dname.c_str(), worst_file, maxsz);
+            size += sz;
+        }
+        else if (S_ISREG(stats.st_mode))
+        {
+            double sz = stats.st_size;
+            size += sz;
+
+            if (worst_file)
+            {
+                /* Calculate "weighted" size and age
+                 * w = sz_kbytes * age_mins */
+                sz /= 1024;
+                long age = (time(NULL) - stats.st_mtime) / 60;
+                if (age > 0)
+                    sz *= age;
+
+                if (sz > *maxsz)
+                {
+                    *maxsz = sz;
+                    *worst_file = dname;
+                }
+            }
+        }
+    }
+    closedir(dp);
+    return size;
+}
+
 static void trim_debuginfo_cache(unsigned max_mb)
 {
-    // TODO
+    while (1)
+    {
+        std::string worst_file;
+        double maxsz = 0;
+        double cache_sz = get_dir_size(DEBUGINFO_CACHE_DIR, &worst_file, &maxsz);
+        if (cache_sz / (1024 * 1024) < max_mb)
+            break;
+        VERB1 log("%s is %.0f bytes (over %u MB), deleting '%s'",
+                DEBUGINFO_CACHE_DIR, cache_sz, max_mb, worst_file.c_str());
+        if (unlink(worst_file.c_str()) != 0)
+            perror_msg("Can't unlink '%s'");
+    }
 }
 
 std::string CAnalyzerCCpp::GetLocalUUID(const std::string& pDebugDumpDir)
@@ -816,7 +876,7 @@ void CAnalyzerCCpp::CreateReport(const std::string& pDebugDumpDir, int force)
     dd.Close(); /* do not keep dir locked longer than needed */
 
     std::string build_ids;
-    if (m_bInstallDebuginfo && DebuginfoCheckPolkit(atoi(UID.c_str()))) {
+    if (m_bInstallDebugInfo && DebuginfoCheckPolkit(atoi(UID.c_str()))) {
 	if (m_nDebugInfoCacheMB > 0)
             trim_debuginfo_cache(m_nDebugInfoCacheMB);
         InstallDebugInfos(pDebugDumpDir, build_ids);
@@ -905,10 +965,12 @@ void CAnalyzerCCpp::SetSettings(const map_plugin_settings_t& pSettings)
     {
         m_nDebugInfoCacheMB = atoi(it->second.c_str());
     }
-    it = pSettings.find("InstallDebuginfo");
+    it = pSettings.find("InstallDebugInfo");
+    if (it == end) //compat, remove after 0.0.11
+        it = pSettings.find("InstallDebuginfo");
     if (it != end)
     {
-        m_bInstallDebuginfo = it->second == "yes";
+        m_bInstallDebugInfo = it->second == "yes";
     }
 }
 
@@ -919,7 +981,7 @@ map_plugin_settings_t CAnalyzerCCpp::GetSettings()
     ret["MemoryMap"] = m_bMemoryMap ? "yes" : "no";
     ret["DebugInfo"] = m_sDebugInfo;
     ret["DebugInfoCacheMB"] = to_string(m_nDebugInfoCacheMB);
-    ret["InstallDebuginfo"] = m_bInstallDebuginfo ? "yes" : "no";
+    ret["InstallDebugInfo"] = m_bInstallDebugInfo ? "yes" : "no";
 
     return ret;
 }
diff --git a/lib/Plugins/CCpp.h b/lib/Plugins/CCpp.h
index 70601c20..f3f911ef 100644
--- a/lib/Plugins/CCpp.h
+++ b/lib/Plugins/CCpp.h
@@ -31,7 +31,7 @@ class CAnalyzerCCpp : public CAnalyzer
 {
     private:
         bool m_bMemoryMap;
-        bool m_bInstallDebuginfo;
+        bool m_bInstallDebugInfo;
         unsigned m_nDebugInfoCacheMB;
         std::string m_sOldCorePattern;
         std::string m_sDebugInfo;
diff --git a/lib/Plugins/FileTransfer.cpp b/lib/Plugins/FileTransfer.cpp
index 0573c511..66427585 100644
--- a/lib/Plugins/FileTransfer.cpp
+++ b/lib/Plugins/FileTransfer.cpp
@@ -222,7 +222,7 @@ static void create_targz(const char * archive_name, const char * directory)
     if (gz == NULL)
     {
         fclose(f);
-	free(name_without_gz);
+        free(name_without_gz);
         return;
     }
 
diff --git a/lib/Plugins/Logger.cpp b/lib/Plugins/Logger.cpp
index 81787940..716d3a92 100644
--- a/lib/Plugins/Logger.cpp
+++ b/lib/Plugins/Logger.cpp
@@ -73,7 +73,7 @@ std::string CLogger::Report(const map_crash_report_t& pCrashReport,
 
     if (fOut)
     {
-	fputs(description.c_str(), fOut);
+        fputs(description.c_str(), fOut);
         fclose(fOut);
         return "file://" + m_sLogPath;
     }
diff --git a/lib/Utils/DebugDump.cpp b/lib/Utils/DebugDump.cpp
index 5017d868..f5c73190 100644
--- a/lib/Utils/DebugDump.cpp
+++ b/lib/Utils/DebugDump.cpp
@@ -29,17 +29,6 @@
 #include "ABRTException.h"
 #include "CommLayerInner.h"
 
-/* Is it "." or ".."? */
-/* abrtlib candidate */
-static bool dot_or_dotdot(const char *filename)
-{
-    if (filename[0] != '.') return false;
-    if (filename[1] == '\0') return true;
-    if (filename[1] != '.') return false;
-    if (filename[2] == '\0') return true;
-    return false;
-}
-
 static bool isdigit_str(const char *str)
 {
     do
diff --git a/lib/Utils/xfuncs.cpp b/lib/Utils/xfuncs.cpp
index 9c8b0f12..533fbfa8 100644
--- a/lib/Utils/xfuncs.cpp
+++ b/lib/Utils/xfuncs.cpp
@@ -321,3 +321,37 @@ int is_regular_file(struct dirent *dent, const char *dirname)
 
         return r == 0 && S_ISREG(statbuf.st_mode);
 }
+
+/* Is it "." or ".."? */
+/* abrtlib candidate */
+bool dot_or_dotdot(const char *filename)
+{
+    if (filename[0] != '.') return false;
+    if (filename[1] == '\0') return true;
+    if (filename[1] != '.') return false;
+    if (filename[2] == '\0') return true;
+    return false;
+}
+
+/* Find out if the last character of a string matches the one given.
+ * Don't underrun the buffer if the string length is 0.
+ */
+char *last_char_is(const char *s, int c)
+{
+	if (s && *s) {
+		s += strlen(s) - 1;
+		if ((unsigned char)*s == c)
+			return (char*)s;
+	}
+	return NULL;
+}
+
+std::string concat_path_file(const char *path, const char *filename)
+{
+	char *lc;
+
+	while (*filename == '/')
+		filename++;
+	lc = last_char_is(path, '/');
+	return ssprintf("%s%s%s", path, (lc==NULL ? "/" : ""), filename);
+}