summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2009-09-08 15:43:18 +0200
committerDenys Vlasenko <vda.linux@googlemail.com>2009-09-08 15:43:18 +0200
commit8198cd06195f4217fd6b1afb675f3a316c951a1e (patch)
tree49982be2144bfdc57d4e975e90d9e86983a593c5 /lib
parent08393f2509642009829f9de09a463e7d3e364a58 (diff)
downloadabrt-8198cd06195f4217fd6b1afb675f3a316c951a1e.tar.gz
abrt-8198cd06195f4217fd6b1afb675f3a316c951a1e.tar.xz
abrt-8198cd06195f4217fd6b1afb675f3a316c951a1e.zip
style fixes, trivial code changes only
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'lib')
-rw-r--r--lib/MiddleWare/Database.h4
-rw-r--r--lib/Plugins/SQLite3.cpp73
-rw-r--r--lib/Plugins/SQLite3.h7
3 files changed, 41 insertions, 43 deletions
diff --git a/lib/MiddleWare/Database.h b/lib/MiddleWare/Database.h
index ce29f18b..0fc31ee7 100644
--- a/lib/MiddleWare/Database.h
+++ b/lib/MiddleWare/Database.h
@@ -111,7 +111,7 @@ class CDatabase : public CPlugin
* @param pUID An UID of an user.
* @return A vector of matched rows.
*/
- virtual const vector_database_rows_t GetUIDData(const std::string& pUID) = 0;
+ virtual vector_database_rows_t GetUIDData(const std::string& pUID) = 0;
/**
* A method, which returns one row accordind to UUID of a crash and
* UID of an user. If there are no row, empty row is returned.
@@ -119,7 +119,7 @@ class CDatabase : public CPlugin
* @param pUID An UID of an user.
* @return A matched row.
*/
- virtual const database_row_t GetUUIDData(const std::string& pUUID,
+ virtual database_row_t GetUUIDData(const std::string& pUUID,
const std::string& pUID) = 0;
};
diff --git a/lib/Plugins/SQLite3.cpp b/lib/Plugins/SQLite3.cpp
index a57da240..700ac913 100644
--- a/lib/Plugins/SQLite3.cpp
+++ b/lib/Plugins/SQLite3.cpp
@@ -1,6 +1,5 @@
/*
- DebugDump.h - header file for the library caring of writing new reports
- to the specific directory
+ SQLite3.cpp
Copyright (C) 2009 Zdenek Prikryl (zprikryl@redhat.com)
Copyright (C) 2009 RedHat inc.
@@ -33,7 +32,7 @@
#define ABRT_TABLE "abrt_v"ABRT_TABLE_VERSION_STR
#define SQLITE3_MASTER_TABLE "sqlite_master"
-// afret a while, we can drom a support for update, so a table can stay in
+// after a while, we can drop support for update, so a table can stay in
// normal limits
static const char* upate_sql_commands[][ABRT_TABLE_VERSION + 1] = {
// v0 -> *
@@ -100,9 +99,9 @@ bool CSQLite3::Exist(const std::string& pUUID, const std::string& pUID)
GetTable("SELECT "DATABASE_COLUMN_REPORTED" FROM "ABRT_TABLE" WHERE "
DATABASE_COLUMN_UUID" = '"+pUUID+"' AND "
DATABASE_COLUMN_UID" = '"+pUID+"';", table);
- if(table.empty())
+ if (table.empty())
{
- return false;
+ return false;
}
return true;
}
@@ -113,7 +112,7 @@ void CSQLite3::Exec(const std::string& pCommand)
int ret = sqlite3_exec(m_pDB, pCommand.c_str(), 0, 0, &err);
if (ret != SQLITE_OK)
{
- throw CABRTException(EXCEP_PLUGIN, "SQLite3::Exec(): Error on: " + pCommand + " " + err);
+ throw CABRTException(EXCEP_PLUGIN, "SQLite3::Exec(): Error on: " + pCommand + " " + err);
}
}
@@ -211,7 +210,7 @@ bool CSQLite3::CheckTable()
int ret = sqlite3_get_table(m_pDB, command.c_str(), &table, &nrow, &ncol, &err);
if (ret != SQLITE_OK)
{
- throw CABRTException(EXCEP_PLUGIN, "SQLite3::GetTable(): Error on: " + command + " " + err);
+ throw CABRTException(EXCEP_PLUGIN, "SQLite3::GetTable(): Error on: " + command + " " + err);
}
if (!nrow || !nrow)
{
@@ -281,24 +280,24 @@ void CSQLite3::Insert(const std::string& pUUID,
{
if (!Exist(pUUID, pUID))
{
- Exec("INSERT INTO "ABRT_TABLE"("
- DATABASE_COLUMN_UUID","
- DATABASE_COLUMN_UID","
- DATABASE_COLUMN_DEBUG_DUMP_PATH","
- DATABASE_COLUMN_TIME")"
- " VALUES ('"+pUUID+"',"
- "'"+pUID+"',"
- "'"+pDebugDumpPath+"',"
- "'"+pTime+"'"
- ");");
+ Exec("INSERT INTO "ABRT_TABLE"("
+ DATABASE_COLUMN_UUID","
+ DATABASE_COLUMN_UID","
+ DATABASE_COLUMN_DEBUG_DUMP_PATH","
+ DATABASE_COLUMN_TIME")"
+ " VALUES ('"+pUUID+"',"
+ "'"+pUID+"',"
+ "'"+pDebugDumpPath+"',"
+ "'"+pTime+"'"
+ ");");
}
else
{
- Exec("UPDATE "ABRT_TABLE" "
- "SET "DATABASE_COLUMN_COUNT" = "DATABASE_COLUMN_COUNT" + 1, "
- DATABASE_COLUMN_TIME" = '"+pTime+"' "
- "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"' "
- "AND "DATABASE_COLUMN_UID" = '"+pUID+"';");
+ Exec("UPDATE "ABRT_TABLE" "
+ "SET "DATABASE_COLUMN_COUNT" = "DATABASE_COLUMN_COUNT" + 1, "
+ DATABASE_COLUMN_TIME" = '"+pTime+"' "
+ "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"' "
+ "AND "DATABASE_COLUMN_UID" = '"+pUID+"';");
}
}
@@ -306,14 +305,14 @@ void CSQLite3::Delete(const std::string& pUUID, const std::string& pUID)
{
if (pUID == "0")
{
- Exec("DELETE FROM "ABRT_TABLE" "
- "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"';");
+ Exec("DELETE FROM "ABRT_TABLE" "
+ "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"';");
}
else if (Exist(pUUID, pUID))
{
- Exec("DELETE FROM "ABRT_TABLE" "
- "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"' "
- "AND "DATABASE_COLUMN_UID" = '"+pUID+"';");
+ Exec("DELETE FROM "ABRT_TABLE" "
+ "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"' "
+ "AND "DATABASE_COLUMN_UID" = '"+pUID+"';");
}
else
{
@@ -325,14 +324,14 @@ void CSQLite3::SetReported(const std::string& pUUID, const std::string& pUID, co
{
if (Exist(pUUID, pUID))
{
- Exec("UPDATE "ABRT_TABLE" "
- "SET "DATABASE_COLUMN_REPORTED" = 1 "
- "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"' "
- "AND "DATABASE_COLUMN_UID" = '"+pUID+"';");
- Exec("UPDATE "ABRT_TABLE" "
- "SET "DATABASE_COLUMN_MESSAGE" = '" + pMessage + "' "
- "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"' "
- "AND "DATABASE_COLUMN_UID" = '"+pUID+"';");
+ Exec("UPDATE "ABRT_TABLE" "
+ "SET "DATABASE_COLUMN_REPORTED" = 1 "
+ "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"' "
+ "AND "DATABASE_COLUMN_UID" = '"+pUID+"';");
+ Exec("UPDATE "ABRT_TABLE" "
+ "SET "DATABASE_COLUMN_MESSAGE" = '" + pMessage + "' "
+ "WHERE "DATABASE_COLUMN_UUID" = '"+pUUID+"' "
+ "AND "DATABASE_COLUMN_UID" = '"+pUID+"';");
}
else
{
@@ -340,7 +339,7 @@ void CSQLite3::SetReported(const std::string& pUUID, const std::string& pUID, co
}
}
-const vector_database_rows_t CSQLite3::GetUIDData(const std::string& pUID)
+vector_database_rows_t CSQLite3::GetUIDData(const std::string& pUID)
{
vector_database_rows_t table;
if (pUID == "0")
@@ -356,7 +355,7 @@ const vector_database_rows_t CSQLite3::GetUIDData(const std::string& pUID)
return table;
}
-const database_row_t CSQLite3::GetUUIDData(const std::string& pUUID, const std::string& pUID)
+database_row_t CSQLite3::GetUUIDData(const std::string& pUUID, const std::string& pUID)
{
vector_database_rows_t table;
diff --git a/lib/Plugins/SQLite3.h b/lib/Plugins/SQLite3.h
index 1604d3be..e7ca8ae2 100644
--- a/lib/Plugins/SQLite3.h
+++ b/lib/Plugins/SQLite3.h
@@ -1,6 +1,5 @@
/*
- DebugDump.h - header file for the library caring of writing new reports
- to the specific directory
+ SQLite3.h
Copyright (C) 2009 Zdenek Prikryl (zprikryl@redhat.com)
Copyright (C) 2009 RedHat inc.
@@ -55,8 +54,8 @@ class CSQLite3 : public CDatabase
virtual void Delete(const std::string& pUUID, const std::string& pUID);
virtual void SetReported(const std::string& pUUID, const std::string& pUID, const std::string& pMessage);
- virtual const vector_database_rows_t GetUIDData(const std::string& pUID);
- virtual const database_row_t GetUUIDData(const std::string& pUUID, const std::string& pUID);
+ virtual vector_database_rows_t GetUIDData(const std::string& pUID);
+ virtual database_row_t GetUUIDData(const std::string& pUUID, const std::string& pUID);
virtual void SetSettings(const map_plugin_settings_t& pSettings);
virtual map_plugin_settings_t GetSettings();