GUI: don't require the rating for all reporters

- some reporters (logger, RHTSupport) doesn't require a good
  backtrace (so far only bz does) so gui shouldn't force user
  to have a good backtrace everytime

3 files changed, 16 insertions, 3 deletions

diff --git a/lib/Plugins/Bugzilla.cpp b/lib/Plugins/Bugzilla.cpp
index 94fd3838..b14c28fa 100644
--- a/lib/Plugins/Bugzilla.cpp
+++ b/lib/Plugins/Bugzilla.cpp
@@ -580,7 +580,8 @@ static map_plugin_settings_t parse_settings(const map_plugin_settings_t& pSettin
 CReporterBugzilla::CReporterBugzilla() :
     m_bNoSSLVerify(false),
     m_sBugzillaURL("https://bugzilla.redhat.com"),
-    m_sBugzillaXMLRPC("https://bugzilla.redhat.com"XML_RPC_SUFFIX)
+    m_sBugzillaXMLRPC("https://bugzilla.redhat.com"XML_RPC_SUFFIX),
+    m_bRatingRequired(true)
 {}
 
 CReporterBugzilla::~CReporterBugzilla()
@@ -854,6 +855,7 @@ const map_plugin_settings_t& CReporterBugzilla::GetSettings()
     m_pSettings["Login"] = m_sLogin;
     m_pSettings["Password"] = m_sPassword;
     m_pSettings["NoSSLVerify"] = m_bNoSSLVerify ? "yes" : "no";
+    m_pSettings["RatingRequired"] = m_bRatingRequired ? "yes" : "no";
 
     return m_pSettings;
 }
diff --git a/lib/Plugins/Bugzilla.h b/lib/Plugins/Bugzilla.h
index cad00ef5..1c9a06e3 100644
--- a/lib/Plugins/Bugzilla.h
+++ b/lib/Plugins/Bugzilla.h
@@ -30,6 +30,7 @@ class CReporterBugzilla : public CReporter
         std::string m_sBugzillaXMLRPC;
         std::string m_sLogin;
         std::string m_sPassword;
+        bool m_bRatingRequired;
 
     public:
         CReporterBugzilla();
diff --git a/src/Gui/CReporterAssistant.py b/src/Gui/CReporterAssistant.py
index 10d68662..a87cdf5d 100644
--- a/src/Gui/CReporterAssistant.py
+++ b/src/Gui/CReporterAssistant.py
@@ -267,6 +267,16 @@ class ReporterAssistant():
         SendBacktrace = send_toggle.get_active()
         send = True
         error_msgs = []
+        rating_required = False
+
+        for reporter in self.selected_reporters:
+            if "RatingRequired" in reporter.Settings.keys():
+                if reporter.Settings["RatingRequired"] == "yes":
+                    rating_required = True
+                    log1(_("Rating is required by %s plugin") % reporter)
+        if not rating_required:
+            log1(_("Rating is not required by any plugin, skipping the check.."))
+
         try:
             rating = int(self.report.get_rating())
         except Exception, ex:
@@ -278,7 +288,7 @@ class ReporterAssistant():
             error_msgs.append(_("You should check backtrace for sensitive data"))
             error_msgs.append(_("You must agree with sending the backtrace"))
         # we have both SendBacktrace and rating
-        if rating != None:
+        if rating_required and rating != None:
             try:
                 package = self.result[FILENAME_PACKAGE][CD_CONTENT]
             # if we don't have package for some reason
@@ -800,7 +810,7 @@ class ReporterAssistant():
         page.show_all()
 
     def __del__(self):
-        print "wizard: about to be deleted"
+        log1("wizard: about to be deleted")
 
     def on_analyze_complete_cb(self, daemon, result, pBarWindow):
         try: