summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2009-09-02 14:43:40 +0200
committerDenys Vlasenko <vda.linux@googlemail.com>2009-09-02 14:43:40 +0200
commit0d2e1ac467cce6b8577dc58ef58053a42a3a48d8 (patch)
treef1a284595d801f5f018c5f5e2478beaca9fd999f
parent5b79533ec48b0ec9eb2cdd5cafc705160a486888 (diff)
downloadabrt-0d2e1ac467cce6b8577dc58ef58053a42a3a48d8.tar.gz
abrt-0d2e1ac467cce6b8577dc58ef58053a42a3a48d8.tar.xz
abrt-0d2e1ac467cce6b8577dc58ef58053a42a3a48d8.zip
fix my mixup of int64/uint64 in dbus
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--src/Daemon/CommLayerServerDBus.cpp15
1 files changed, 7 insertions, 8 deletions
diff --git a/src/Daemon/CommLayerServerDBus.cpp b/src/Daemon/CommLayerServerDBus.cpp
index 1d3cdc25..0994a1ce 100644
--- a/src/Daemon/CommLayerServerDBus.cpp
+++ b/src/Daemon/CommLayerServerDBus.cpp
@@ -225,10 +225,10 @@ static bool load_vector(DBusMessageIter* iter, std::vector<E>& val)
DBusMessageIter sub_iter;
dbus_message_iter_recurse(iter, &sub_iter);
- type = dbus_message_iter_get_arg_type(&sub_iter);
- /* here "type" is the element's type */
bool next_exists;
//int cnt = 0;
+ //type = dbus_message_iter_get_arg_type(&sub_iter);
+ /* here "type" is the element's type, and it will be checked by load_val */
// if (type != DBUS_TYPE_INVALID) - not needed?
do {
E elem;
@@ -342,7 +342,7 @@ void CCommLayerServerDBus::JobDone(const std::string &pDest, uint64_t job_id)
const char* c_dest = pDest.c_str();
dbus_message_append_args(msg,
DBUS_TYPE_STRING, &c_dest,
- DBUS_TYPE_INT64, &job_id,
+ DBUS_TYPE_UINT64, &job_id,
DBUS_TYPE_INVALID);
send_flush_and_unref(msg);
}
@@ -353,7 +353,7 @@ void CCommLayerServerDBus::JobStarted(const std::string &pDest, uint64_t job_id)
const char* c_dest = pDest.c_str();
dbus_message_append_args(msg,
DBUS_TYPE_STRING, &c_dest,
- DBUS_TYPE_INT64, &job_id,
+ DBUS_TYPE_UINT64, &job_id,
DBUS_TYPE_INVALID);
send_flush_and_unref(msg);
}
@@ -374,7 +374,7 @@ void CCommLayerServerDBus::Update(const std::string& pMessage, uint64_t job_id)
const char* c_message = pMessage.c_str();
dbus_message_append_args(msg,
DBUS_TYPE_STRING, &c_message,
- DBUS_TYPE_INT64, &job_id,
+ DBUS_TYPE_UINT64, &job_id,
DBUS_TYPE_INVALID);
send_flush_and_unref(msg);
}
@@ -395,7 +395,7 @@ void CCommLayerServerDBus::Warning(const std::string& pMessage, uint64_t job_id)
const char* c_message = pMessage.c_str();
dbus_message_append_args(msg,
DBUS_TYPE_STRING, &c_message,
- DBUS_TYPE_INT64, &job_id,
+ DBUS_TYPE_UINT64, &job_id,
DBUS_TYPE_INVALID);
send_flush_and_unref(msg);
}
@@ -518,8 +518,7 @@ static void handle_DeleteDebugDump(DBusMessage* call, DBusMessage* reply)
static void handle_GetJobResult(DBusMessage* call, DBusMessage* reply)
{
-//?! load_val definitely sees DBUS_TYPE_INT64, not UINT! ('x', not 't')
- /*u*/ int64_t job_id;
+ uint64_t job_id;
DBusMessageIter in_iter;
if (!dbus_message_iter_init(call, &in_iter))
error_msg_and_die("dbus call error: no parameters");