summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2009-08-04 17:28:23 +0200
committerDenys Vlasenko <vda.linux@googlemail.com>2009-08-04 17:28:23 +0200
commit26904c7faff196b91c1ad50574f725cd1a033094 (patch)
treede6eca67cd3c7f855f6494994bca97209b3c3586
parentf1b08b8295fa46c805f223079284dd4330d329c6 (diff)
downloadabrt-26904c7faff196b91c1ad50574f725cd1a033094.tar.gz
abrt-26904c7faff196b91c1ad50574f725cd1a033094.tar.xz
abrt-26904c7faff196b91c1ad50574f725cd1a033094.zip
remove redundant virtual destructors definitions
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--lib/MiddleWare/Action.h4
-rw-r--r--lib/MiddleWare/Analyzer.h4
-rw-r--r--lib/MiddleWare/Database.h4
-rw-r--r--lib/MiddleWare/Reporter.h4
-rw-r--r--lib/Plugins/CCpp.h1
-rw-r--r--lib/Plugins/FileTransfer.h1
-rw-r--r--lib/Plugins/Kerneloops.h1
-rw-r--r--lib/Plugins/KerneloopsReporter.h1
-rw-r--r--lib/Plugins/KerneloopsScanner.h1
-rw-r--r--lib/Plugins/Logger.h1
-rw-r--r--lib/Plugins/Mailx.h1
-rw-r--r--lib/Plugins/Python.h1
-rw-r--r--lib/Plugins/RunApp.h1
-rw-r--r--lib/Plugins/SOSreport.h1
-rw-r--r--lib/Plugins/SQLite3.h1
-rw-r--r--src/Hooks/dumpoops.cpp6
16 files changed, 3 insertions, 30 deletions
diff --git a/lib/MiddleWare/Action.h b/lib/MiddleWare/Action.h
index c4689844..1286feba 100644
--- a/lib/MiddleWare/Action.h
+++ b/lib/MiddleWare/Action.h
@@ -32,10 +32,6 @@ class CAction : public CPlugin
{
public:
/**
- * A destructor.
- */
- virtual ~CAction() {}
- /**
* A Method which performs particular action. As the first parameter it
* takes an action directory. It could be either a directory of actual
* crash or it could be a directory contains all crashes. It depends on
diff --git a/lib/MiddleWare/Analyzer.h b/lib/MiddleWare/Analyzer.h
index 61e5018e..4fe586b8 100644
--- a/lib/MiddleWare/Analyzer.h
+++ b/lib/MiddleWare/Analyzer.h
@@ -32,10 +32,6 @@ class CAnalyzer : public CPlugin
{
public:
/**
- * A destructor.
- */
- virtual ~CAnalyzer() {}
- /**
* A method, which gets a local UUID of particular crash. The local
* UUID is usualy computed from data which are stored in debugdump dir.
* @param pDebugDumpPath A debugdump dir containing all necessary data.
diff --git a/lib/MiddleWare/Database.h b/lib/MiddleWare/Database.h
index b4affe9f..36238469 100644
--- a/lib/MiddleWare/Database.h
+++ b/lib/MiddleWare/Database.h
@@ -67,10 +67,6 @@ class CDatabase : public CPlugin
{
public:
/**
- * A destructor.
- */
- virtual ~CDatabase() {}
- /**
* A method, which connects to a database.
*/
virtual void Connect() = 0;
diff --git a/lib/MiddleWare/Reporter.h b/lib/MiddleWare/Reporter.h
index 87c46db1..810b3169 100644
--- a/lib/MiddleWare/Reporter.h
+++ b/lib/MiddleWare/Reporter.h
@@ -33,10 +33,6 @@ class CReporter : public CPlugin
{
public:
/**
- * A destructor.
- */
- virtual ~CReporter() {}
- /**
* A method, which reports a crash report to particular receiver.
* The plugin can takes arguments, but the plugin has to parse them
* by itself.
diff --git a/lib/Plugins/CCpp.h b/lib/Plugins/CCpp.h
index ac21e8db..b14a90fa 100644
--- a/lib/Plugins/CCpp.h
+++ b/lib/Plugins/CCpp.h
@@ -35,7 +35,6 @@ class CAnalyzerCCpp : public CAnalyzer
std::string m_sDebugInfo;
public:
CAnalyzerCCpp();
- /*virtual ~CAnalyzerCCpp();*/
virtual std::string GetLocalUUID(const std::string& pDebugDumpDir);
virtual std::string GetGlobalUUID(const std::string& pDebugDumpDir);
virtual void CreateReport(const std::string& pDebugDumpDir);
diff --git a/lib/Plugins/FileTransfer.h b/lib/Plugins/FileTransfer.h
index 2dd0151e..68ba0fb7 100644
--- a/lib/Plugins/FileTransfer.h
+++ b/lib/Plugins/FileTransfer.h
@@ -48,7 +48,6 @@ class CFileTransfer : public CAction
m_nRetryDelay(20),
m_sArchiveType(".tar.gz")
{}
- virtual ~CFileTransfer() {}
virtual void LoadSettings(const std::string& pPath);
virtual void SetSettings(const map_plugin_settings_t& pSettings);
diff --git a/lib/Plugins/Kerneloops.h b/lib/Plugins/Kerneloops.h
index 77d44191..1be58fc6 100644
--- a/lib/Plugins/Kerneloops.h
+++ b/lib/Plugins/Kerneloops.h
@@ -37,7 +37,6 @@
class CAnalyzerKerneloops : public CAnalyzer
{
public:
- virtual ~CAnalyzerKerneloops() {}
virtual std::string GetLocalUUID(const std::string& pDebugDumpDir);
virtual std::string GetGlobalUUID(const std::string& pDebugDumpDir);
virtual void CreateReport(const std::string& pDebugDumpDir) {}
diff --git a/lib/Plugins/KerneloopsReporter.h b/lib/Plugins/KerneloopsReporter.h
index 3ec8cc9b..5ef172c2 100644
--- a/lib/Plugins/KerneloopsReporter.h
+++ b/lib/Plugins/KerneloopsReporter.h
@@ -39,7 +39,6 @@ class CKerneloopsReporter : public CReporter
public:
CKerneloopsReporter();
- virtual ~CKerneloopsReporter() {}
virtual void LoadSettings(const std::string& pPath);
virtual void SetSettings(const map_plugin_settings_t& pSettings);
diff --git a/lib/Plugins/KerneloopsScanner.h b/lib/Plugins/KerneloopsScanner.h
index ff0d98b3..eba1c00b 100644
--- a/lib/Plugins/KerneloopsScanner.h
+++ b/lib/Plugins/KerneloopsScanner.h
@@ -23,7 +23,6 @@ class CKerneloopsScanner : public CAction
m_sSysLogFile("/var/log/messages"),
m_bSysLogFileScanned(false)
{}
- virtual ~CKerneloopsScanner() {}
virtual void Run(const std::string& pActionDir,
const std::string& pArgs);
virtual void LoadSettings(const std::string& pPath);
diff --git a/lib/Plugins/Logger.h b/lib/Plugins/Logger.h
index b76dbf2e..0c31dca9 100644
--- a/lib/Plugins/Logger.h
+++ b/lib/Plugins/Logger.h
@@ -33,7 +33,6 @@ class CLogger : public CReporter
bool m_bAppendLogs;
public:
CLogger();
- virtual ~CLogger() {}
virtual void LoadSettings(const std::string& pPath);
virtual void SetSettings(const map_plugin_settings_t& pSettings);
diff --git a/lib/Plugins/Mailx.h b/lib/Plugins/Mailx.h
index 414a6e93..3cd88db4 100644
--- a/lib/Plugins/Mailx.h
+++ b/lib/Plugins/Mailx.h
@@ -41,7 +41,6 @@ class CMailx : public CReporter
public:
CMailx();
- virtual ~CMailx() {}
virtual void LoadSettings(const std::string& pPath);
virtual void SetSettings(const map_plugin_settings_t& pSettings);
diff --git a/lib/Plugins/Python.h b/lib/Plugins/Python.h
index 6eaf1d14..57eefbf9 100644
--- a/lib/Plugins/Python.h
+++ b/lib/Plugins/Python.h
@@ -8,7 +8,6 @@
class CAnalyzerPython : public CAnalyzer
{
public:
- virtual ~CAnalyzerPython() {}
virtual std::string GetLocalUUID(const std::string& pDebugDumpDir);
virtual std::string GetGlobalUUID(const std::string& pDebugDumpDir);
virtual void CreateReport(const std::string& pDebugDumpDir) {}
diff --git a/lib/Plugins/RunApp.h b/lib/Plugins/RunApp.h
index 65fbe500..bec42f4d 100644
--- a/lib/Plugins/RunApp.h
+++ b/lib/Plugins/RunApp.h
@@ -33,7 +33,6 @@ class CActionRunApp : public CAction
void ParseArgs(const std::string& psArgs, vector_args_t& pArgs);
public:
- virtual ~CActionRunApp() {}
virtual void Run(const std::string& pActionDir,
const std::string& pArgs);
};
diff --git a/lib/Plugins/SOSreport.h b/lib/Plugins/SOSreport.h
index dbddafdb..2b2c99a3 100644
--- a/lib/Plugins/SOSreport.h
+++ b/lib/Plugins/SOSreport.h
@@ -33,7 +33,6 @@ class CActionSOSreport : public CAction
std::string ParseFilename(const std::string& pOutput);
public:
- virtual ~CActionSOSreport() {}
virtual void Run(const std::string& pActionDir,
const std::string& pArgs);
};
diff --git a/lib/Plugins/SQLite3.h b/lib/Plugins/SQLite3.h
index 15cb8c6f..99c3a8f8 100644
--- a/lib/Plugins/SQLite3.h
+++ b/lib/Plugins/SQLite3.h
@@ -43,7 +43,6 @@ class CSQLite3 : public CDatabase
public:
CSQLite3();
- virtual ~CSQLite3() {}
virtual void Connect();
virtual void DisConnect();
diff --git a/src/Hooks/dumpoops.cpp b/src/Hooks/dumpoops.cpp
index 6c8441e6..596c49a0 100644
--- a/src/Hooks/dumpoops.cpp
+++ b/src/Hooks/dumpoops.cpp
@@ -43,7 +43,7 @@ int main(int argc, char **argv)
errno = 0;
handle = dlopen(PLUGINS_LIB_DIR"/libKerneloopsScanner.so", RTLD_NOW);
if (!handle)
- perror_msg_and_die("can't load %s", PLUGINS_LIB_DIR"/libKerneloopsScanner.so");
+ perror_msg_and_die("can't load %s", PLUGINS_LIB_DIR"/libKerneloopsScanner.so");
#define LOADSYM(fp, name) \
do { \
fp = (typeof(fp)) (dlsym(handle, name)); \
@@ -64,8 +64,8 @@ do { \
if (cnt > 0)
{
- log("dumping oopses");
- save_oops_to_debug_dump(scanner);
+ log("dumping oopses");
+ save_oops_to_debug_dump(scanner);
}
/*dlclose(handle); - why bother? */