diff options
author | Jiri Moskovcak <jmoskovc@redhat.com> | 2009-10-08 12:47:35 +0200 |
---|---|---|
committer | Jiri Moskovcak <jmoskovc@redhat.com> | 2009-10-08 12:47:35 +0200 |
commit | a1330d4f0271e5a22f1764302b18bf5e1665a68e (patch) | |
tree | d43a2a25024791a1e1e943baf30f01ecd3ed9f28 | |
parent | f8f0951b0d29edc14d6985ecff68bc181a5ccaa5 (diff) | |
download | abrt-a1330d4f0271e5a22f1764302b18bf5e1665a68e.tar.gz abrt-a1330d4f0271e5a22f1764302b18bf5e1665a68e.tar.xz abrt-a1330d4f0271e5a22f1764302b18bf5e1665a68e.zip |
Bugzilla: removed "+1" feature
- this plugin added +1 as comment to existing bugzilla recognized
as a duplicate of a bug being reported, this feature only adds "noise"
to comments, so adding user to CC seems sufficient
-rw-r--r-- | lib/Plugins/Bugzilla.cpp | 25 | ||||
-rw-r--r-- | lib/Plugins/Bugzilla.h | 1 |
2 files changed, 1 insertions, 25 deletions
diff --git a/lib/Plugins/Bugzilla.cpp b/lib/Plugins/Bugzilla.cpp index a3c70f04..48c5eb55 100644 --- a/lib/Plugins/Bugzilla.cpp +++ b/lib/Plugins/Bugzilla.cpp @@ -147,28 +147,6 @@ bool CReporterBugzilla::CheckCCAndReporter(const std::string& pBugId) return false; } -void CReporterBugzilla::AddPlusOneComment(const std::string& pBugId) -{ - xmlrpc_c::paramList paramList; - map_xmlrpc_params_t addCommentParams; - map_xmlrpc_params_t ret; - - addCommentParams["id"] = xmlrpc_c::value_int(atoi(pBugId.c_str())); - addCommentParams["comment"] = xmlrpc_c::value_string("+1"); - - paramList.add(xmlrpc_c::value_struct(addCommentParams)); - xmlrpc_c::rpcPtr rpc(new xmlrpc_c::rpc("Bug.add_comment", paramList)); - try - { - rpc->call(m_pXmlrpcClient, m_pCarriageParm); - } - catch (std::exception& e) - { - throw CABRTException(EXCEP_PLUGIN, std::string("CReporterBugzilla::AddPlusOneComment(): ") + e.what()); - } - ret = xmlrpc_c::value_struct(rpc->getResult()); -} - void CReporterBugzilla::AddPlusOneCC(const std::string& pBugId) { xmlrpc_c::paramList paramList; @@ -424,10 +402,9 @@ std::string CReporterBugzilla::Report(const map_crash_report_t& pCrashReport, co update_client(_("Logging into bugzilla...")); Login(); m_bLoggedIn = true; - update_client(_("Check CC and add coment +1...")); + update_client(_("Checking CC...")); if (!CheckCCAndReporter(bugId) && m_bLoggedIn) { - AddPlusOneComment(bugId); AddPlusOneCC(bugId); } DeleteXMLRPCClient(); diff --git a/lib/Plugins/Bugzilla.h b/lib/Plugins/Bugzilla.h index c5098b31..f6a8976f 100644 --- a/lib/Plugins/Bugzilla.h +++ b/lib/Plugins/Bugzilla.h @@ -18,7 +18,6 @@ class CReporterBugzilla : public CReporter void Login(); void Logout(); bool CheckCCAndReporter(const std::string& pBugId); - void AddPlusOneComment(const std::string& pBugId); void AddPlusOneCC(const std::string& pBugId); std::string CheckUUIDInBugzilla(const std::string& pComponent, const std::string& pUUID); std::string NewBug(const map_crash_report_t& pCrashReport); |