From d8ab04b533a6d2fc224e1931463b91508cc6d701 Mon Sep 17 00:00:00 2001 From: Rainer Gerhards Date: Fri, 21 Aug 2009 16:48:00 +0200 Subject: bugfix: strings improperly reused [backported from v5] ... resulting in some message properties be populated with strings from previous messages. This was caused by an improper predicate check. --- runtime/prop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'runtime/prop.c') diff --git a/runtime/prop.c b/runtime/prop.c index 804f3491..d188b2ed 100644 --- a/runtime/prop.c +++ b/runtime/prop.c @@ -174,7 +174,7 @@ rsRetVal CreateOrReuseStringProp(prop_t **ppThis, uchar *psz, int len) } else { /* already exists, check if we can re-use it */ GetString(*ppThis, &pszPrev, &lenPrev); - if(len != lenPrev && ustrcmp(psz, pszPrev)) { + if(len != lenPrev || ustrcmp(psz, pszPrev)) { /* different, need to discard old & create new one */ propDestruct(ppThis); CHKiRet(CreateStringProp(ppThis, psz, len)); -- cgit