From 2eb19201b3f4be01057c1b958a077b5fb2fce107 Mon Sep 17 00:00:00 2001 From: Rainer Gerhards Date: Thu, 20 Dec 2007 08:54:51 +0000 Subject: - working on a potential race condition on the new input module interface. See newsgroup posting for details on the issue: http://groups.google.com/group/comp.programming.threads/msg/330b9675f17 a1ad6 I tried some mutex operations but came to the conclusion that this does not really help. So I have now switched to plain thread cancellation, which so far seems to be OK. Need more practical experience with other input modules to make a final decision. Thus I leave all code in and have just disabled the problematic code. --- plugins/imklog/imklog.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'plugins/imklog') diff --git a/plugins/imklog/imklog.c b/plugins/imklog/imklog.c index 157dee73..1c3c79c3 100644 --- a/plugins/imklog/imklog.c +++ b/plugins/imklog/imklog.c @@ -46,11 +46,14 @@ MODULE_TYPE_INPUT TERM_SYNC_TYPE(eTermSync_SIGNAL) /* Module static data */ -int dbgPrintSymbols = 0; DEF_IMOD_STATIC_DATA typedef struct _instanceData { } instanceData; +/* configuration settings TODO: move to instance data? */ +int dbgPrintSymbols = 0; +int symbols_twice = 0; + /* Includes. */ #include @@ -87,12 +90,11 @@ static int kmsg, static int use_syscall = 0, symbol_lookup = 1; -static char *symfile = (char *) 0, +static char *symfile = NULL, log_buffer[LOG_BUFFER_SIZE]; static enum LOGSRC {none, proc, kernel} logsrc; -int symbols_twice = 0; /* Function prototypes. */ -- cgit