summaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* bugfix: default for $OMFileFlushOnTXEnd was wrong ("off").Rainer Gerhards2010-04-071-2/+3
| | | | | | This, in default mode, caused buffered writing to be used, what means that it looked like no output were written or partial lines. Thanks to Michael Biebl for pointing out this bug.
* temporary bugfix replaced by permanent one for...Rainer Gerhards2010-03-311-1/+1
| | | | | | ...message-induced off-by-one error (potential segfault) (see 4.6.2) The analysis has been completed and a better fix been crafted and integrated.
* $OMFileAsyncWriting directive did not work properlyRainer Gerhards2010-03-251-1/+1
|
* new feature: $OMFileAsyncWriting directive addedRainer Gerhards2010-03-251-19/+22
| | | | it permits to specifiy if asynchronous writing should be done or not
* undo experimental commit dccadb677c5a6b8379f631e4c1f14c8c4089d4a6Rainer Gerhards2010-03-251-9/+0
| | | | | | | Further testing turned out that the rsyslog core works correctly and this fix is not needed. The concurrency we saw was actually caused by other actions (even processes) during directory creation. See commit 9e5b31fc44136dbcc1e443cfe7714e9daf97d844 for further details.
* bugfix: potential segfault in dynafile cacheRainer Gerhards2010-03-251-1/+1
| | | | | | | | | This bug was triggered by an open failure. The the cache was full and a new entry needed to be placed inside it, a victim for eviction was selected. That victim was freed, then the open of the new file tried. If the open failed, the victim entry was still freed, and the function exited. However, on next invocation and cache search, the victim entry was used as if it were populated, most probably resulting in a segfault.
* streamline dynafile cache entry deletion a bitRainer Gerhards2010-03-231-8/+7
| | | | | | The old code looks a bit "strange", though not necessarily incorrect. The new code looks correct and is probably less irritating during bug hunting.
* bugfix: potential re-use of free()ed file stream object in omfileRainer Gerhards2010-03-231-7/+21
| | | | | | | when dynaCache is enabled, the cache is full, a new entry needs to be allocated, thus the LRU discarded, then a new entry is opend and that fails. In that case, it looks like the discarded stream may be reused improperly (based on code analysis, test case and confirmation pending)
* previous (experimental) patch was somewhat incorrect, fixedRainer Gerhards2010-03-221-1/+1
| | | | This is what caused the new test to fail...
* exp: made omfile ensure that it is not called twice in parallel on the same ↵Rainer Gerhards2010-03-211-0/+9
| | | | | | | | | | | | file instance In theory, the rsyslog core should never call in parallel into an output module for the same instance. However, it looks like this seems to happen under (strange?) circumstances. I have now enhanced omfile so that it guards itself against being called in parallel on the same instance data. This is done to help troubleshooting and may stay as an interim solution if it proves to solve an anomaly we see in at least one installation (to trigger this problem, an extremely large traffic volume is needed).
* fixed regression from previos (yet unrelease) $omfileFlushOnTXEnd fixtemp.4.6.1.10Rainer Gerhards2010-03-191-1/+1
| | | | | | | | The previous fix fixed an issue with on/off bying used in the exact wrong semantic. It corrected the situation, but failed to fix one spot where the wrong semantics were used. This is done with this commit. Note that this is NOT a bug seen in any released version.
* new feature: "." action type added to support writing files to relative pathesRainer Gerhards2010-03-171-1/+2
| | | | (this is primarily meant as a debug aid)
* bugfix: recent patch to fix small memory leak could cause invalid free.Rainer Gerhards2010-03-161-2/+2
| | | | This could only happen during config file parsing.
* testbench: new calling interface for tcpfloodRainer Gerhards2010-03-101-0/+7
| | | | | this is a perquisite to support more flexible testing modes, which could not intelligently be implemented with the old interface
* bugfix: potential problem (loop, abort) when file write error occuredRainer Gerhards2010-03-091-2/+2
| | | | | | | | | | When a write error occured in stream.c, variable iWritten had the error code but this was handled as if it were the actual number of bytes written. That was used in pointer arithmetic later on, and thus could lead to all sorts of problems. However, this could only happen if the error was EINTR or the file in question was a tty. All other cases were handled properly. Now, iWritten is reset to zero in such cases, resulting in proper retries.
* retain old $OMFileFlushOnTXEnd semanticsRainer Gerhards2010-03-091-2/+2
| | | | | required because due to bug the default was actually different than specified (or better said: spec was inconsistent in doc as well).
* bugfix: $omfileFlushOnTXEnd was turned on when set to off and vice versaRainer Gerhards2010-03-091-1/+1
|
* streamlined BSD utmpx.h patchCristiano2010-03-041-14/+12
| | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* Fix Large File Support (LFS) support (bug #182)Yann Droneaud2010-03-041-1/+1
| | | | | | | | | - _FILE_OFFSET_BITS must be defined before including any other system headers otherwise it does nothing. - Don't define it in rsyslog.h, let it be defined in config.h, and let ./configure script enable LFS since Autoconf provides a portable macro to enable LFS support : AC_SYS_LARGEFILE
* Includes "config.h" before any other header.Yann Droneaud2010-03-043-0/+3
| | | | | | | For consistency, ./configure generated "config.h" must be the first header include through out the project. Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* bugfix: potential (but very impropable) segfaults in omfileRainer Gerhards2010-03-021-2/+14
| | | | | | | | | | | | - bugfix: potential segfault in omfile when a dynafile open failed In that case, a partial cache entry was written, and some internal pointers (iCurrElt) not correctly updated. In the next iteration, that could lead to a segfault, especially if iCurrElt then points to the then-partial record. Not very likely, but could happen in practice. - bugfix (theoretical): potential segfault in omfile under low memory condition. This is only a theoretical bug, because it would only happen when strdup() fails to allocate memory - which is highly unlikely and will probably lead to all other sorts of errors.
* solved compile problems on FreeBSD 9.0 (those caused by utmpx.h)Cristiano2010-03-021-7/+20
| | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* fixed typo that (could have) caused compilation fail under FreeBSDRainer Gerhards2010-03-011-3/+3
| | | | | Note that I now also prefer to use utmp.h if it is present - this seems to be much better under Linux.
* make $ActonFileDefaultTemplate available to ompipeRainer Gerhards2010-03-013-15/+17
| | | | | | | | | This was not honored by the new ompipe module, because it is a local file directive (it was applied to pipes as a side-effect of using the same module for pipes and files...). I now made this a global, so that semantics are the same as previously. Not really nice, but probably the best thing to do in the current situation (everything else would involve much more overhead --- leave that for the new config system).
* bugfix: fixed problem that caused compilation on FreeBSD 9.0 to fail.Rainer Gerhards2010-02-281-1/+5
| | | | | bugtracker: http://bugzilla.adiscon.com/show_bug.cgi?id=181 Thanks to Christiano for reporting.
* Description: Correct error in rsyslog.conf(5) man pageMichael Biebl2010-02-281-1/+1
| | | | | | | $InputUDPServerRun config variable does not exist, should be $UDPServerRun instead http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=571202 Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* some code cleanupRainer Gerhards2010-02-284-15/+12
|
* moved pipe code to its own moduleRainer Gerhards2010-02-285-1/+284
| | | | | | | ... based on old omfile. Michael Biebl reported that xconsole seems to have some issues with the new pipe code, so it was best to use the old code for pipes. The optimizations were done to speed up file access, so it doesn't really matter pipes do not receive them.
* message parser fixes and testbench enhancementsRainer Gerhards2010-02-221-4/+12
| | | | | | | | | - improved testbench to contain samples for totally malformed messages which miss parts of the message content - bugfix: some malformed messages could lead to a missing LF inside files or some other missing parts of the template content. - bugfix: if a message ended immediately with a hostname, the hostname was mistakenly interpreted as TAG, and localhost be used as hostname
* bugfix: message without MSG part could case a segfaultRainer Gerhards2010-02-221-4/+2
| | | | | | | [backported from v5 commit 98d1ed504ec001728955a5bcd7916f64cd85f39f] This actually was a "recent" regression, but I did not realize that it was introduced by the performance optimization in v4-devel. Shame on me for having two devel versions at the same time...
* Merge branch 'v4-stable' into v4-betaRainer Gerhards2010-02-041-0/+3
|\
| * bugfix: several smaller bugs resolved after flexelint reviewvarmojfekoj2010-02-041-0/+3
| | | | | | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | (slightly) enhanced support for FreeBSD by setting _PATH_MODDIR to the ↵Cristiano2010-02-031-1/+5
| | | | | | | | | | | | correct value on FreeBSD. Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | bugfix: -d did not enable display of debug messagesRainer Gerhards2010-01-191-0/+1
| | | | | | | | | | regression from introduction of "debug on demand" mode Thanks to Michael Biebl for reporting this bug
* | Merge branch 'v4-stable' into v4-betaRainer Gerhards2010-01-191-2/+2
|\|
| * Fix a typo regarding syslog.h and syslog(3)Michael Biebl2010-01-191-2/+2
| | | | | | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | bugfix: rsyslog hangs when writing to a named pipe which nobody was reading.Rainer Gerhards2010-01-151-6/+16
| | | | | | | | Thanks to Michael Biebl for reporting this bug.
* | fixed a memory leak when sending messages in zip-compressed formatNaoya Nakazawa2010-01-111-0/+6
| | | | | | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | Merge branch 'v4-stable' into v4-betaRainer Gerhards2009-12-041-0/+1
|\|
| * Merge branch 'v3-stable' into v4-stableRainer Gerhards2009-12-041-0/+1
| |\
| | * bugfix: potential segfault when -p command line option was usedRainer Gerhards2009-12-041-0/+1
| | | | | | | | | | | | thanks to varmojfekoj for pointing me at this bug
* | | Merge branch 'v4-stable' into v4-betaRainer Gerhards2009-11-301-1/+1
|\| |
| * | Merge branch 'v3-stable' into v4-stableRainer Gerhards2009-11-301-1/+1
| |\|
| | * bugfix: $CreateDirs variable not properly initializedRainer Gerhards2009-11-301-1/+1
| | | | | | | | | | | | default thus was random (but most often "on")
* | | Merge branch 'v4-stable' into v4-betaRainer Gerhards2009-11-171-2/+2
|\| |
| * | Merge branch 'v3-stable' into v4-stableRainer Gerhards2009-11-171-2/+2
| |\| | | | | | | | | | | | | | | | Conflicts: doc/rsyslog_conf.html runtime/net.c
| | * correcting -q/-Q patch - was invalidRainer Gerhards2009-11-121-2/+2
| | | | | | | | | | | | | | | This is the correct patch. The previous one solved the segfault, but disabled the -q/Q options.
* | | Merge branch 'v4-stable' into v4-betaRainer Gerhards2009-11-121-2/+2
|\| |
| * | Merge branch 'v3-stable' into v4-stableRainer Gerhards2009-11-121-2/+2
| |\|
| | * bugfix: segfault on startup when -q or -Q option was givenRainer Gerhards2009-11-121-2/+2
| | | | | | | | | | | | | | | bug tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=157 Thanks to Jonas Nogueira for reporting this bug.