summaryrefslogtreecommitdiffstats
path: root/runtime
Commit message (Collapse)AuthorAgeFilesLines
* (temporary?) removal of very conservative locks in stream.cRainer Gerhards2009-09-241-2/+2
| | | | | | ...after we seem to have identified the root cause of the segfault. I leave them commented out so that we can re-activate it if need arises (aka "get some practice drill first").
* bugfix: potential segfault in stream writer on destructionRainer Gerhards2009-09-241-5/+9
| | | | | | | | | | Most severely affected omfile. The problem was that some buffers were freed before the asynchronous writer thread was shut down. So the writer thread accessed invalid data, which may even already be overwritten. Symptoms (with omfile) were segfaults, grabled data and files with random names placed around the file system (most prominently into the root directory). Special thanks to Aaron for helping to track this down.
* minor: increased buffer size to be safe in all casesRainer Gerhards2009-09-221-2/+2
| | | | | if the buffer was too small, we would see more API calls, but no failure, so this is no fix!
* bugfixes: potential problems in out file zip writer.Rainer Gerhards2009-09-221-14/+31
| | | | | | Problems could lead to abort and/or memory leak. The module is now hardened in a very conservative way, which is sub-optimal from a performance point of view. This should be improved if it has proven reliable in practice.
* bugfix: potential race in object loader during use/release of object interfaceRainer Gerhards2009-09-221-3/+19
|
* fixed some minor portability issuesRainer Gerhards2009-09-142-3/+11
|
* bugfix: repeated messages were incorrectly processedRainer Gerhards2009-09-101-3/+8
| | | | | | | | | this could lead to loss of the repeated message content. As a side- effect, it could probably also be possible that some segfault occurs (quite unlikely). The root cause was that some counters introduced during the malloc optimizations were not properly duplicated in MsgDup(). Note that repeated message processing is not enabled by default.
* Merge branch 'v4-stable' into v4-betaRainer Gerhards2009-09-032-1/+47
|\ | | | | | | | | | | | | Conflicts: ChangeLog configure.ac doc/manual.html
| * bugfix: reverse lookup reduction logic in imudp do DNS queries too oftenRainer Gerhards2009-09-032-1/+47
| | | | | | | | | | | | | | | | | | A comparison was done between the current and the former source address. However, this was done on the full sockaddr_storage structure and not on the host address only. This has now been changed for IPv4 and IPv6. The end result of this bug could be a higher UDP message loss rate than necessary (note that UDP message loss can not totally be avoided due to the UDP spec)
| * bugfix: invalid double-quoted PRI, among others in outgoing messagesRainer Gerhards2009-08-251-1/+1
| | | | | | | | | | This causes grief with all receivers. Bug tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=147
| * Merge branch 'v4.3.2' (v4-beta) into v4-stablev4.4.0Rainer Gerhards2009-08-2135-448/+2346
| |\ | | | | | | | | | | | | | | | | | | | | | Conflicts: ChangeLog configure.ac doc/manual.html tests/Makefile.am
* | | bugfix: message sanitation had some issuesRainer Gerhards2009-08-262-4/+29
| | | | | | | | | | | | | | | | | | | | | | | | - control character DEL was not properly escaped - NUL and LF characters were not properly stripped if no control character replacement was to be done - NUL characters in the message body were silently dropped (this was a regeression introduced by some of the recent optimizations)
* | | bugfix: strings improperly reused [backported from v5]Rainer Gerhards2009-08-211-1/+1
| | | | | | | | | | | | | | | ... resulting in some message properties be populated with strings from previous messages. This was caused by an improper predicate check.
* | | very minor cleanupRainer Gerhards2009-08-181-1/+0
| | |
* | | bugfix: potential segfault in output file writer (omfile)Rainer Gerhards2009-08-182-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In async write mode, we use modular arithmetic to index the output buffer array. However, the counter variables accidently were signed, thus resulting in negative indizes after integer overflow. That in turn could lead to segfaults, but was depending on the memory layout of the instance in question (which in turn depended on a number of variables, like compile settings but also configuration). The counters are now unsigned (as they always should have been) and so the dangling mis-indexing does no longer happen. This bug potentially affected all installations, even if only some may actually have seen a segfault.
* | | legacy syslog parser changed so that it now accepts date stamps in wrong case.Rainer Gerhards2009-08-171-22/+34
| | | | | | | | | | | | Some devices seem to create them and I do not see any harm in supporting that.
* | | calls to prctl() need to be based on configure results (cross-platform issue)Rainer Gerhards2009-07-162-3/+5
| | | | | | | | | | | | | | | This is for another prctl() call, not present in the beta version (looks like it would make sense to stick these into a utility function)
* | | Merge branch 'v4-beta' into v4-develRainer Gerhards2009-07-161-2/+5
|\ \ \
| * | | calls to prctl() need to be based on configure results (cross-platform issue)Rainer Gerhards2009-07-161-2/+5
| | | |
* | | | Merge branch 'v4-beta' into v4-develRainer Gerhards2009-07-151-2/+2
|\| | |
| * | | CONFIG CHANGE: $HUPisRestart default is now "off".Rainer Gerhards2009-07-151-2/+2
| | | | | | | | | | | | | | | | | | | | We are doing this to support removal of restart-type HUP in v5. Elaborate doc added to explain reasoning and actions to be taken.
* | | | Merge branch 'v4-beta' into v4-develRainer Gerhards2009-07-101-1/+0
|\| | |
| * | | bugfix: potential segfault when zip-compressed syslog records were received ↵Rainer Gerhards2009-07-101-1/+0
| | | | | | | | | | | | | | | | (double free)
* | | | small performance improvement and cleanupRainer Gerhards2009-07-093-158/+172
| | | | | | | | | | | | | | | | | | | | | | | | optimized substring processing, should bring a small enhancement when forwarding with the default forwarding templates. Also did some uchar cleanup in msg.c (thus so many changes, in reality they are few...).
* | | | Merge branch 'v4-beta' into v4-develRainer Gerhards2009-07-091-1/+1
|\| | | | | | | | | | | | | | | | | | | Conflicts: tests/nettester.c
| * | | bugfix: message could be truncated after TAG, often when forwardingRainer Gerhards2009-07-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This was a result of an internal processing error if maximum field sizes had been specified in the property replacer. Also did some testbench improvements, including omstdout.
* | | | added capability to write incomplete buffers after an inactivity timeoutRainer Gerhards2009-07-072-7/+40
| | | | | | | | | | | | | | | | | | | | | | | | for the stream class and thus finally activating omfile's timeout capability in a useful way without polling and too-high performance overhead.
* | | | fixed a bug introduced today that lead to an abort in queue disk modeRainer Gerhards2009-07-073-10/+14
| | | |
* | | | Merge branch 'v4-beta' into v4-develRainer Gerhards2009-07-071-10/+15
|\| | |
| * | | bugfix: property msg was lost when working with disk queuesRainer Gerhards2009-07-071-5/+12
| | | |
| * | | bugfix: properties inputname, fromhost, fromhost-ip were lostRainer Gerhards2009-07-071-5/+3
| | | | | | | | | | | | | | | | ... when working with disk queues.
* | | | solved a race conditionRainer Gerhards2009-07-073-15/+51
| | | |
* | | | clean solution for "writing" arbrietary-size user buffers to a streamRainer Gerhards2009-07-071-42/+28
| | | |
* | | | stream now uses a singular buffer strucuture for writingRainer Gerhards2009-07-071-6/+12
| | | |
* | | | moved locking primitivesRainer Gerhards2009-07-071-3/+19
| | | |
* | | | moved zip part to writer threadRainer Gerhards2009-07-061-69/+89
| | | | | | | | | | | | | | | | | | | | | | | | ... this is necessary in preparation for the final solution (we need to have a "unified" writer). If it causes worse performance to have the zip writher togehter with the synchronous write, we may do an async write...
* | | | some minor cleanupRainer Gerhards2009-07-062-17/+18
| | | |
* | | | Merge branch 'v4-beta' into v4-develRainer Gerhards2009-07-061-2/+2
|\| | |
| * | | performance enhancement: much faster, up to twice as fastRainer Gerhards2009-07-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | (depending on configuration). This was a small change, but with big results. There is more potential to explore, but the effects were so dramatic that I think it makes sense to include this fix.
* | | | first shot at asynchronous stream writer with timeout capabilityRainer Gerhards2009-07-065-74/+171
|/ / / | | | | | | | | | | | | ... seems to work on quick testing, but needs a far more testing and improvement. Good milestone commit.
* | | bugfix: abort condition when RecvFrom was not set and message reduction was onRainer Gerhards2009-07-061-6/+12
| | | | | | | | | | | | Happend e.g. with imuxsock.
* | | bugfix: missing initialization during timestamp creationv4.5.0Rainer Gerhards2009-07-032-0/+5
| | | | | | | | | | | | | | | This could lead to timestamps written in the wrong format, but not to an abort.
* | | now put the new property-based methods to good useRainer Gerhards2009-07-014-40/+100
| | | | | | | | | | | | | | | | | | ... hopefully reducing the number of allocs/frees as well as overall memory usage in a busy system (plus that these shared properties hopefully remain in cache longer than its single-instance counterparts...)
* | | RcvFromIP now also a propertyRainer Gerhards2009-07-012-34/+69
| | | | | | | | | | | | | | | | | | This sets stage to enable use of the property-interface to speed up things (mildly), the next step to be done. I have also fixed one regression of yesterday's changes.
* | | removed a debugging-left-over, caused compilation failure on some platformsRainer Gerhards2009-07-011-1/+0
| | | | | | | | | | | | ... because LARGFILE macros were not defined consistenly
* | | introduced a new way of handling the RcvFrom propertyRainer Gerhards2009-06-309-50/+137
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... plus a fix for a long-time bug in obj-types.h. That lead to the object pointer only then to become NULL when the object was actually destructed, I discovered this issue during introduction of the pRcvFrom property in msg_t, but it potentially had other effects, too. I am not sure if some experienced instability resulted from this bug OR if its fix will cause harm to so-far "correctly" running code. The later may very well be. Thus I will change it only for the current branch and also the beta, but not in all old builds. Let's see how things evolve.
* | | finished transition to using inputName propertyRainer Gerhards2009-06-303-106/+180
| | | | | | | | | | | | | | | ... plus some celanup and adding minor missing functionality (the rule debug info again tell the property name, not just number).
* | | introduced the idea of detached propertiesRainer Gerhards2009-06-299-37/+152
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | some things inside the message can be used over a large number of messages and need to to be allocated and re-written every time. I now begin to implement this as a "prop_t" object, first use for the inputName. Some input modules are already converted, some others to go. Will do a little performance check on the new method before I go further. Also, this commit has some cleanup and a few bug fixes that prevented compiliation in debug mode (I overlooked this as I did not compile for debug, what I normally do, and the automatted test also does not do that)
* | | separate willRun and runInput calls for input modulesMichael Terry2009-06-292-0/+2
| | | | | | | | | | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | | optimization: propert names are now internally identified by integersRainer Gerhards2009-06-267-137/+296
| | |