| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| | |
Conflicts:
ChangeLog
configure.ac
|
| |
| |
| |
| |
| |
| | |
... in a tight loop, effectively disabling functionality and bearing the
risk of unresponsiveness of the whole system.
Bug tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=194
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
- bugfix: a couple of problems that imfile had on some platforms, namely
Ubuntu (not their fault, but occured there)
- bugfix: imfile utilizes 32 bit to track offset. Most importantly,
this problem can not experienced on Fedora 64 bit OS (which has
64 bit long's!)
|
|\|
| |
| |
| |
| | |
Conflicts:
runtime/conf.c
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| |
| |
| | |
...message-induced off-by-one error (potential segfault) (see 4.6.2)
The analysis has been completed and a better fix been crafted and
integrated.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Some types of malformed messages could trigger an off-by-one error
(for example, \0 or \n as the last character, and generally control
character escaption is questionable). This is due to not strictly
following a the \0 or string counted string paradigm (during the last
optimization on the cstring class). As a temporary fix, we have
introduced a proper recalculation of the size. However, a final
patch is expected in the future. See bug tracker for further details
and when the final patch will be available:
http://bugzilla.adiscon.com/show_bug.cgi?id=184
Note that the current patch is considered sufficient to solve the
situation, but it requires a bit more runtime than desirable.
|
| |
| |
| |
| |
| |
| |
| | |
If multiple files try to create a directory at (almost) the same time,
some of them may fail. This is a data race and also exists with other
processes that may create the same directory. We do now check for this
condition and gracefully handle it.
|
| |
| |
| |
| |
| |
| | |
The old code looks a bit "strange", though not necessarily incorrect.
The new code looks correct and is probably less irritating during bug
hunting.
|
| |
| |
| |
| |
| |
| |
| | |
properly initialized.
However, in practice the loader initializes them with zero, the
desired value, so there were no actual issue in almost all cases.
|
| |
| |
| |
| |
| |
| |
| |
| | |
The previous fix fixed an issue with on/off bying used in the exact wrong
semantic. It corrected the situation, but failed to fix one spot where the
wrong semantics were used. This is done with this commit.
Note that this is NOT a bug seen in any released version.
|
| |
| |
| |
| |
| |
| |
| | |
currently being accessed buffer could be overwritten with new data.
While this probably did not cause access violations, it could case loss
and/or duplication of some data (definitely a race with no deterministic
outcome)
|
| |
| |
| |
| |
| | |
predicate was not properly checked when waiting for the background file
writer
|
| |
| |
| |
| |
| | |
Internal data structures were not properly protected due to missing
mutex calls.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Previously, it could lead to garbagge output and, in extreme cases, also
to segfaults. Note: this was a problem only when debug output was
actually enabled, so it caused no problem in production use.
|
| | |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
disk queue mode did no longer work correctly. A side-effect of
this commit here is slightly cleaned-up (and more elegant) code
for circular files.
|
|/ /
| |
| |
| |
| |
| | |
note that a buffer size calculation was done wrong, but this was cosmetic
because our buffers currently all use byte size, so even though the
formula was wrong, the result was correct.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- improved testbench
- bugfix: potential data loss during file stream shutdown
- bugfix: potential problems during file stream shutdown
The shutdown/close sequence was not clean, what potentially (but
unlikely) could lead to some issues. We have not been able to describe
any fatal cases, but there was some bug potential. Sequence has now
been straighted out.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a write error occured in stream.c, variable iWritten had the error
code but this was handled as if it were the actual number of bytes
written. That was used in pointer arithmetic later on, and thus could
lead to all sorts of problems. However, this could only happen if the
error was EINTR or the file in question was a tty. All other cases were
handled properly. Now, iWritten is reset to zero in such cases, resulting
in proper retries.
|
| |
| |
| |
| |
| | |
primarily to ease migration from syslog-ng. See property replacer doc for
details. [backport from 5.5.3 because urgently needed by some]
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- _FILE_OFFSET_BITS must be defined before including any other system
headers otherwise it does nothing.
- Don't define it in rsyslog.h, let it be defined in config.h,
and let ./configure script enable LFS since Autoconf provides
a portable macro to enable LFS support : AC_SYS_LARGEFILE
|
| |
| |
| |
| |
| |
| |
| | |
For consistency, ./configure generated "config.h" must be the first
header include through out the project.
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
|\|
| |
| |
| |
| | |
Conflicts:
runtime/ctok.c
|
| |
| |
| |
| |
| | |
...and thus could not be used.
but tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=119
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was not honored by the new ompipe module, because it is a local
file directive (it was applied to pipes as a side-effect of using the
same module for pipes and files...). I now made this a global, so that
semantics are the same as previously. Not really nice, but probably
the best thing to do in the current situation (everything else would
involve much more overhead --- leave that for the new config system).
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- improved testbench to contain samples for totally malformed messages
which miss parts of the message content
- bugfix: some malformed messages could lead to a missing LF inside files
or some other missing parts of the template content.
- bugfix: if a message ended immediately with a hostname, the hostname
was mistakenly interpreted as TAG, and localhost be used as hostname
|
| |
| |
| |
| |
| |
| |
| | |
[backported from v5 commit 98d1ed504ec001728955a5bcd7916f64cd85f39f]
This actually was a "recent" regression, but I did not realize that it
was introduced by the performance optimization in v4-devel. Shame on
me for having two devel versions at the same time...
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- bugfix: property replacer returned invalid parameters under some (unusual)
conditions. In extreme cases, this could lead to garbled logs and/or
a system failure.
- bugfix: invalid length returned (often) when using regular expressions
inside the property replacer
- bugfix: submatch regex in property replacer did not honor "return 0 on
no match" config case
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
runtime/queue.c
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
(bugs require certain non-standard settings to appear)
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
This could reslult in the whole rest of a line (including comments)
to be treated as file name in "write to file" actions.
Thanks to Jack for reporting this issue.
|
| | |
| | |
| | |
| | | |
Thanks to Michael Biebl for reporting this bug.
|
| | |
| | |
| | |
| | | |
for example imudp. Thanks to Anton for reporting this bug.
|
| | |
| | |
| | |
| | | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
|\| | |
|
| |\|
| | |
| | |
| | |
| | |
| | | |
Conflicts:
doc/rsyslog_conf.html
runtime/net.c
|
| | |
| | |
| | |
| | |
| | | |
This is the correct patch. The previous one solved the segfault, but
disabled the -q/Q options.
|