summaryrefslogtreecommitdiffstats
path: root/runtime
Commit message (Collapse)AuthorAgeFilesLines
* bugfix: potential segfault on messages with empty MSG part.Rainer Gerhards2009-10-091-3/+12
| | | | This was a recently introduced regression.
* Merge branch 'v4-beta' into betaRainer Gerhards2009-10-081-1/+1
|\
| * Merge branch 'aaron' into v4-betaRainer Gerhards2009-10-081-1/+1
| |\
| | * bugfix: debug string larger than 1K were improperly displayed.Rainer Gerhards2009-10-081-1/+1
| | | | | | | | | | | | Max size is now 32K.
* | | bugfix and testbench improvementsRainer Gerhards2009-10-073-7/+33
| | | | | | | | | | | | | | | | | | | | | | | | - bugfix: solved potential (temporary) stall of messages when the queue was almost empty and few new data added (caused testbench to sometimes hang!) - fixed some race condition in testbench - added more elaborate diagnostics to parts of the testbench - solved a potential race inside the queue engine
* | | bugfix and testbench improvementRainer Gerhards2009-10-071-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | made shutdown more reliable by makeing sure that the main queue DA worker is only cancelled if this is actually unavoidable. Also moved down the deletion of rsyslogd's pid file to immediately before termination, so that absence of the file is a proper indication that rsyslogd has finished (in the past, e.g. the testbench accidently ran two intances as the pid file was deleted too early). Also some improvments to the testbench, namely to handle aborts more intelligently (but still not perfect).
* | | bugfix: potential race condition when queue worker threads were terminatedRainer Gerhards2009-10-061-1/+10
| | |
* | | Merge branch 'v4-beta' into betaRainer Gerhards2009-10-051-1/+1
|\| |
| * | Merge branch 'aaron' into v4-betaRainer Gerhards2009-10-051-1/+1
| |\|
| | * bugfix[minor]: CHKiRet improperly usedRainer Gerhards2009-10-021-1/+1
| | |
* | | Merge branch 'v4-beta' into betaRainer Gerhards2009-10-024-44/+100
|\| | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: ChangeLog configure.ac doc/manual.html runtime/rsyslog.h tcpsrv.c
| * | Merge branch 'aaron' into v4-betaRainer Gerhards2009-10-021-0/+1
| |\| | | | | | | | | | | | | Conflicts: runtime/rsyslog.h
| | * bumped version number, corrected error message code (minor nit)Rainer Gerhards2009-10-011-0/+1
| | |
| * | Merge branch 'v4-stable' into v4-beta & BUGFIXRainer Gerhards2009-10-014-41/+96
| |\ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: configure.ac doc/manual.html runtime/datetime.h runtime/parser.c runtime/rsyslog.h tools/syslogd.c v4-stable had a bug with RFC5424-formatted structured data, which showed was detected by the enhanced automatted testbench of v4-beta.
| | * bugfix: invalid handling of zero-sized messagesRainer Gerhards2009-09-291-2/+4
| | | | | | | | | | | | could lead to mis-addressing and potential memory corruption/segfault
| | * bugfix: random data could be appended to message, possibly causing segfaultsRainer Gerhards2009-09-244-42/+88
| | |
* | | Merge branch 'v4-beta' into betaRainer Gerhards2009-09-292-29/+60
|\| | | | | | | | | | | | | | | | | | | | Conflicts: ChangeLog configure.ac doc/manual.html
| * | minor cleanup & preparation for 4.5.4v4.5.4Rainer Gerhards2009-09-291-9/+0
| | |
| * | bugfix: this morning's race patch was incomplete, completing nowRainer Gerhards2009-09-241-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | we needed to release ALL resources (including file handles!) only after the the async writer thread has terminated (else it may access them). In this case, we had a file handle leak, because the handle was sometimes only opened in the async writer, but the close was attempted before the writer even started (in some cases).
| * | (temporary?) removal of very conservative locks in stream.cRainer Gerhards2009-09-241-2/+2
| | | | | | | | | | | | | | | | | | ...after we seem to have identified the root cause of the segfault. I leave them commented out so that we can re-activate it if need arises (aka "get some practice drill first").
| * | bugfix: potential segfault in stream writer on destructionRainer Gerhards2009-09-241-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most severely affected omfile. The problem was that some buffers were freed before the asynchronous writer thread was shut down. So the writer thread accessed invalid data, which may even already be overwritten. Symptoms (with omfile) were segfaults, grabled data and files with random names placed around the file system (most prominently into the root directory). Special thanks to Aaron for helping to track this down.
| * | minor: increased buffer size to be safe in all casesRainer Gerhards2009-09-221-2/+2
| | | | | | | | | | | | | | | if the buffer was too small, we would see more API calls, but no failure, so this is no fix!
| * | bugfixes: potential problems in out file zip writer.Rainer Gerhards2009-09-221-14/+31
| | | | | | | | | | | | | | | | | | Problems could lead to abort and/or memory leak. The module is now hardened in a very conservative way, which is sub-optimal from a performance point of view. This should be improved if it has proven reliable in practice.
| * | bugfix: potential race in object loader during use/release of object interfaceRainer Gerhards2009-09-221-3/+19
| | |
* | | Merge branch 'v4-beta' into betaRainer Gerhards2009-09-142-3/+11
|\| |
| * | fixed some minor portability issuesRainer Gerhards2009-09-142-3/+11
| | |
* | | Merge branch 'v4-beta' into betaRainer Gerhards2009-09-101-3/+8
|\| | | | | | | | | | | | | | Conflicts: action.c
| * | bugfix: repeated messages were incorrectly processedRainer Gerhards2009-09-101-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | this could lead to loss of the repeated message content. As a side- effect, it could probably also be possible that some segfault occurs (quite unlikely). The root cause was that some counters introduced during the malloc optimizations were not properly duplicated in MsgDup(). Note that repeated message processing is not enabled by default.
* | | Merge branch 'v4-devel' into betaRainer Gerhards2009-09-032-1/+47
|\| |
| * | Merge branch 'v4-stable' into v4-betaRainer Gerhards2009-09-032-1/+47
| |\| | | | | | | | | | | | | | | | | | | Conflicts: ChangeLog configure.ac doc/manual.html
| | * bugfix: reverse lookup reduction logic in imudp do DNS queries too oftenRainer Gerhards2009-09-032-1/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | A comparison was done between the current and the former source address. However, this was done on the full sockaddr_storage structure and not on the host address only. This has now been changed for IPv4 and IPv6. The end result of this bug could be a higher UDP message loss rate than necessary (note that UDP message loss can not totally be avoided due to the UDP spec)
| | * bugfix: invalid double-quoted PRI, among others in outgoing messagesRainer Gerhards2009-08-251-1/+1
| | | | | | | | | | | | | | | This causes grief with all receivers. Bug tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=147
| | * Merge branch 'v4.3.2' (v4-beta) into v4-stablev4.4.0Rainer Gerhards2009-08-2135-448/+2346
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: ChangeLog configure.ac doc/manual.html tests/Makefile.am
* | | | Merge branch 'beta'Rainer Gerhards2009-08-272-4/+29
|\| | |
| * | | bugfix: message sanitation had some issuesRainer Gerhards2009-08-262-4/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - control character DEL was not properly escaped - NUL and LF characters were not properly stripped if no control character replacement was to be done - NUL characters in the message body were silently dropped (this was a regeression introduced by some of the recent optimizations)
| * | | bugfix: strings improperly reused [backported from v5]Rainer Gerhards2009-08-211-1/+1
| | | | | | | | | | | | | | | | | | | | ... resulting in some message properties be populated with strings from previous messages. This was caused by an improper predicate check.
* | | | reduced number of debug messages a bit againRainer Gerhards2009-08-263-6/+0
| | | |
* | | | bugfix: strings improperly reusedRainer Gerhards2009-08-211-1/+1
| | | | | | | | | | | | | | | | | | | | ... resulting in some message properties be populated with strings from previous messages. This was caused by an improper predicate check.
* | | | Merge branch 'beta'Rainer Gerhards2009-08-192-10/+4
|\| | |
| * | | very minor cleanupRainer Gerhards2009-08-181-1/+0
| | | |
| * | | bugfix: potential segfault in output file writer (omfile)Rainer Gerhards2009-08-182-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In async write mode, we use modular arithmetic to index the output buffer array. However, the counter variables accidently were signed, thus resulting in negative indizes after integer overflow. That in turn could lead to segfaults, but was depending on the memory layout of the instance in question (which in turn depended on a number of variables, like compile settings but also configuration). The counters are now unsigned (as they always should have been) and so the dangling mis-indexing does no longer happen. This bug potentially affected all installations, even if only some may actually have seen a segfault.
* | | | fixed compile problem introduced by mergeRainer Gerhards2009-08-181-0/+1
| | | |
* | | | Merge branch 'beta'Rainer Gerhards2009-08-181-2/+8
|\ \ \ \
| * | | | bugfix? (unconfirmed, testing): segfault when writing asynchronouslyRainer Gerhards2009-08-181-2/+8
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have undone a very small optimization with using pre-malloced memory, which seems to have some issues. Now I am doing mallocs and at least in test environment this seems to solve the issue. The code now needs more review. If it runs flawlessly for some time, I may try to re-enable to pre-malloc, but not necessarily: its performance benefit is very mild (aka: I don't think it justifies introducing bigger complexities).
* | | | Merge branch 'beta'Rainer Gerhards2009-08-171-22/+34
|\| | |
| * | | legacy syslog parser changed so that it now accepts date stamps in wrong case.Rainer Gerhards2009-08-171-22/+34
| | | | | | | | | | | | | | | | Some devices seem to create them and I do not see any harm in supporting that.
* | | | bugfix: discard action did not work (did not discard messages)Rainer Gerhards2009-07-303-3/+12
| | | |
* | | | bugfix: discard action caused segfaultRainer Gerhards2009-07-301-3/+5
| | | |
* | | | internal: added ability to terminate input modules not via pthread_cancel...Rainer Gerhards2009-07-205-5/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... but an alternate approach via pthread_kill. This is somewhat safer as we do not need to think about the cancel-safeness of all libraries we use. However, not all inputs can easily supported, so this now is a feature that can be requested by the input module (the most important ones request it).
* | | | cleanup & better debug message handlingRainer Gerhards2009-07-201-66/+65
| | | | | | | | | | | | | | | | | | | | | | | | the new handling will hopefully spare a few cycles, as function calls (and most importantly parameter generation!) or now only done when debug messages are actually active.