summaryrefslogtreecommitdiffstats
path: root/runtime
Commit message (Collapse)AuthorAgeFilesLines
* Added MsgDup bugfix from v5-stable into v4-stable branchAndre Lorbach2011-08-111-1/+1
|
* bugfix: memcpy overflow can occur in allowed sender checkingMarius Tomaschewski2011-08-091-1/+1
| | | | | | | ...if a host name is resolved to IPv4-mapped-on-IPv6 address. Found by Ismail Dönmez at suse. Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* Merge branch 'v3-stable' into v4-stableAndre Lorbach2011-08-051-7/+7
|\ | | | | | | | | | | Conflicts: runtime/msg.c
| * bugfix: potential misadressing in property replacerAndre Lorbach2011-08-051-7/+7
| |
* | Merge branch 'v3-stable' into v4-stableRainer Gerhards2011-06-161-1/+1
|\| | | | | | | | | Conflicts: runtime/datetime.c
| * bugfix: timestamp was incorrectly calculated for timezones with minute offsetRainer Gerhards2011-06-161-1/+1
| | | | | | | | closes: http://bugzilla.adiscon.com/show_bug.cgi?id=271
* | bugfix: memory leak in imtcp & subsystems under some circumstancesRainer Gerhards2011-06-141-0/+3
| | | | | | | | | | This leak is tied to error conditions which lead to incorrect cleanup of some data structures. [backport from v6, limited testing under v4]
* | bugfix: invalid processing in QUEUE_FULL conditionRainer Gerhards2011-05-111-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | If the the multi-submit interface was used and a QUEUE_FULL condition occured, the failed message was properly destructed. However, the rest of the input batch, if it existed, was not processed. So this lead to potential loss of messages and a memory leak. The potential loss of messages was IMHO minor, because they would have been dropped in most cases due to the queue remaining full, but very few lucky ones from the batch may have made it. Anyhow, this has now been changed so that the rest of the batch is properly tried to be enqueued and, if not possible, destructed.
* | bugfix: memory and file descriptor leak in stream processingRainer Gerhards2011-05-031-0/+11
| | | | | | | | | | | | | | | | Leaks could occur under some circumstances if the file stream handler errored out during the open call. Among others, this could cause very big memory leaks if there were a problem with unreadable disk queue files. In regard to the memory leak, this closes: http://bugzilla.adiscon.com/show_bug.cgi?id=256
* | slightly more informative errmsg when TCP connection is abortedRainer Gerhards2011-05-021-2/+4
| |
* | bugfix: abort if imfile reads file line of more than 64KiBRainer Gerhards2011-02-101-1/+1
| | | | | | | | | | Thanks to Peter Eisentraut for reporting and analysing this problem. bug tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=221
* | imfile bugfix: potential duplication of log contentRainer Gerhards2011-01-101-13/+9
| | | | | | | | | | | | Under some circumstances an invalid truncation was detected. This code has now been removed, a file change (and thus resent) is only detected if the inode number changes.
* | forgot the actual patch with the last commit :(Rainer Gerhards2010-12-171-1/+1
| |
* | bugfix: imfile potentially duplicates linesRainer Gerhards2010-12-171-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This can happen when 0 bytes are read from the input file, and some writer appends data to the file BEFORE we check if a rollover happens. The check for rollover uses the inode and size as a criterion. So far, we checked for equality of sizes, which is not given in this scenario, but that does not indicate a rollover. From the source code comments: Note that when we check the size, we MUST NOT check for equality. The reason is that the file may have been written right after we did try to read (so the file size has increased). That is NOT in indicator of a rollover (this is an actual bug scenario we experienced). So we need to check if the new size is smaller than what we already have seen!
* | some cleanup based on clang static analyzer resultsRainer Gerhards2010-12-166-15/+8
| |
* | Merge branch 'v3-stable' into v4-stableRainer Gerhards2010-12-162-3/+3
|\| | | | | | | | | Conflicts: ChangeLog
| * improved some code based on clang static analyzer resultsRainer Gerhards2010-12-162-3/+3
| |
* | Merge branch 'v3-stable' into v4-stableRainer Gerhards2010-11-241-0/+17
|\| | | | | | | | | | | Conflicts: ChangeLog configure.ac
| * bugfix(important): problem in TLS handling could cause rsyslog to loopv3.22.3Rainer Gerhards2010-11-241-0/+17
| | | | | | | | | | | | ... in a tight loop, effectively disabling functionality and bearing the risk of unresponsiveness of the whole system. Bug tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=194
* | fixing some compile problems on FreeBSDRainer Gerhards2010-10-193-5/+12
| |
* | imfile: bugfixes in regard to large files (> 2GB)Rainer Gerhards2010-10-151-8/+8
| | | | | | | | | | | | | | | | - bugfix: a couple of problems that imfile had on some platforms, namely Ubuntu (not their fault, but occured there) - bugfix: imfile utilizes 32 bit to track offset. Most importantly, this problem can not experienced on Fedora 64 bit OS (which has 64 bit long's!)
* | Merge branch 'v3-stable' into v4-stableRainer Gerhards2010-08-051-1/+1
|\| | | | | | | | | Conflicts: runtime/conf.c
| * program name filter ! in the configuration cannot be resetKiss Gabor (Bitman)2010-08-051-2/+1
| | | | | | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | bugfix: segfault on HUP when "HUPIsRestart" was set to "on"varmojfekoj2010-07-051-0/+1
| | | | | | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | temporary bugfix replaced by permanent one for...Rainer Gerhards2010-03-312-9/+9
| | | | | | | | | | | | ...message-induced off-by-one error (potential segfault) (see 4.6.2) The analysis has been completed and a better fix been crafted and integrated.
* | bugfix(temporary): message-induced off-by-one error (potential segfault)Rainer Gerhards2010-03-251-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Some types of malformed messages could trigger an off-by-one error (for example, \0 or \n as the last character, and generally control character escaption is questionable). This is due to not strictly following a the \0 or string counted string paradigm (during the last optimization on the cstring class). As a temporary fix, we have introduced a proper recalculation of the size. However, a final patch is expected in the future. See bug tracker for further details and when the final patch will be available: http://bugzilla.adiscon.com/show_bug.cgi?id=184 Note that the current patch is considered sufficient to solve the situation, but it requires a bit more runtime than desirable.
* | bugfix: race condition during directory creationRainer Gerhards2010-03-251-6/+26
| | | | | | | | | | | | | | If multiple files try to create a directory at (almost) the same time, some of them may fail. This is a data race and also exists with other processes that may create the same directory. We do now check for this condition and gracefully handle it.
* | streamline dynafile cache entry deletion a bitRainer Gerhards2010-03-231-1/+1
| | | | | | | | | | | | The old code looks a bit "strange", though not necessarily incorrect. The new code looks correct and is probably less irritating during bug hunting.
* | bugfix(minor): BSD_SO_COMPAT query function had some global vars not ↵Rainer Gerhards2010-03-221-2/+2
| | | | | | | | | | | | | | properly initialized. However, in practice the loader initializes them with zero, the desired value, so there were no actual issue in almost all cases.
* | fixed regression from previos (yet unrelease) $omfileFlushOnTXEnd fixtemp.4.6.1.10Rainer Gerhards2010-03-191-0/+3
| | | | | | | | | | | | | | | | The previous fix fixed an issue with on/off bying used in the exact wrong semantic. It corrected the situation, but failed to fix one spot where the wrong semantics were used. This is done with this commit. Note that this is NOT a bug seen in any released version.
* | bugfix: invalid buffer write in (file) stream classRainer Gerhards2010-03-191-1/+2
| | | | | | | | | | | | | | currently being accessed buffer could be overwritten with new data. While this probably did not cause access violations, it could case loss and/or duplication of some data (definitely a race with no deterministic outcome)
* | bugfix: potential hang condition during filestream closeRainer Gerhards2010-03-191-4/+6
| | | | | | | | | | predicate was not properly checked when waiting for the background file writer
* | bugfix: improper synchronization when "$OMFileFlushOnTXEnd on" was usedRainer Gerhards2010-03-191-11/+35
| | | | | | | | | | Internal data structures were not properly protected due to missing mutex calls.
* | some cleanup, some additional comments and a bit more debug outputRainer Gerhards2010-03-181-2/+11
| |
* | bugfix(cosmetic): tried to close non-open fd, resulting in close(-1)Rainer Gerhards2010-03-161-2/+7
| |
* | reduced runtime requirements of inactive debug code a slight bitRainer Gerhards2010-03-161-10/+10
| |
* | enhanced dbgoprint() buffer sizeRainer Gerhards2010-03-161-1/+1
| |
* | bugfix(minor): handling of extremely large strings in dbgprintf() fixedRainer Gerhards2010-03-151-0/+9
| | | | | | | | | | | | Previously, it could lead to garbagge output and, in extreme cases, also to segfaults. Note: this was a problem only when debug output was actually enabled, so it caused no problem in production use.
* | added more tests to testbench and improved testing toolsRainer Gerhards2010-03-111-1/+1
| |
* | Merge branch 'v4-stable' into v4-stable-nextRainer Gerhards2010-03-102-5/+11
|\ \
| * | fixed regression introduced with previous commitRainer Gerhards2010-03-102-5/+11
| | | | | | | | | | | | | | | | | | disk queue mode did no longer work correctly. A side-effect of this commit here is slightly cleaned-up (and more elegant) code for circular files.
* | | some cosmetic changesRainer Gerhards2010-03-101-9/+9
|/ / | | | | | | | | | | note that a buffer size calculation was done wrong, but this was cosmetic because our buffers currently all use byte size, so even though the formula was wrong, the result was correct.
* | bugfixes and testbench improvementRainer Gerhards2010-03-101-8/+9
| | | | | | | | | | | | | | | | | | | | - improved testbench - bugfix: potential data loss during file stream shutdown - bugfix: potential problems during file stream shutdown The shutdown/close sequence was not clean, what potentially (but unlikely) could lead to some issues. We have not been able to describe any fatal cases, but there was some bug potential. Sequence has now been straighted out.
* | bugfix: potential problem (loop, abort) when file write error occuredRainer Gerhards2010-03-091-0/+1
| | | | | | | | | | | | | | | | | | | | When a write error occured in stream.c, variable iWritten had the error code but this was handled as if it were the actual number of bytes written. That was used in pointer arithmetic later on, and thus could lead to all sorts of problems. However, this could only happen if the error was EINTR or the file in question was a tty. All other cases were handled properly. Now, iWritten is reset to zero in such cases, resulting in proper retries.
* | added new property replacer option "date-rfc3164-buggyday"Rainer Gerhards2010-03-083-7/+17
| | | | | | | | | | primarily to ease migration from syslog-ng. See property replacer doc for details. [backport from 5.5.3 because urgently needed by some]
* | Fix Large File Support (LFS) support (bug #182)Yann Droneaud2010-03-041-9/+0
| | | | | | | | | | | | | | | | | | - _FILE_OFFSET_BITS must be defined before including any other system headers otherwise it does nothing. - Don't define it in rsyslog.h, let it be defined in config.h, and let ./configure script enable LFS since Autoconf provides a portable macro to enable LFS support : AC_SYS_LARGEFILE
* | Includes "config.h" before any other header.Yann Droneaud2010-03-041-1/+1
| | | | | | | | | | | | | | For consistency, ./configure generated "config.h" must be the first header include through out the project. Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | Merge branch 'v3-stable' into v4-stableRainer Gerhards2010-03-011-7/+30
|\| | | | | | | | | Conflicts: runtime/ctok.c
| * bugfix: comment char ('#') in literal terminated script parsingRainer Gerhards2010-03-011-7/+30
| | | | | | | | | | ...and thus could not be used. but tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=119
* | cleanup: removed debug messages that accidently made it into the commitRainer Gerhards2010-03-012-2/+1
| |
generated by cgit (git 2.34.1) at 2024-05-21 18:19:43 +0000