| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Previously, it could lead to garbagge output and, in extreme cases, also
to segfaults. Note: this was a problem only when debug output was
actually enabled, so it caused no problem in production use.
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| | |
disk queue mode did no longer work correctly. A side-effect of
this commit here is slightly cleaned-up (and more elegant) code
for circular files.
|
|/
|
|
|
|
| |
note that a buffer size calculation was done wrong, but this was cosmetic
because our buffers currently all use byte size, so even though the
formula was wrong, the result was correct.
|
|
|
|
|
|
|
|
|
|
| |
- improved testbench
- bugfix: potential data loss during file stream shutdown
- bugfix: potential problems during file stream shutdown
The shutdown/close sequence was not clean, what potentially (but
unlikely) could lead to some issues. We have not been able to describe
any fatal cases, but there was some bug potential. Sequence has now
been straighted out.
|
|
|
|
|
|
|
|
|
|
| |
When a write error occured in stream.c, variable iWritten had the error
code but this was handled as if it were the actual number of bytes
written. That was used in pointer arithmetic later on, and thus could
lead to all sorts of problems. However, this could only happen if the
error was EINTR or the file in question was a tty. All other cases were
handled properly. Now, iWritten is reset to zero in such cases, resulting
in proper retries.
|
|
|
|
|
| |
primarily to ease migration from syslog-ng. See property replacer doc for
details. [backport from 5.5.3 because urgently needed by some]
|
|
|
|
|
|
|
|
|
| |
- _FILE_OFFSET_BITS must be defined before including any other system
headers otherwise it does nothing.
- Don't define it in rsyslog.h, let it be defined in config.h,
and let ./configure script enable LFS since Autoconf provides
a portable macro to enable LFS support : AC_SYS_LARGEFILE
|
|
|
|
|
|
|
| |
For consistency, ./configure generated "config.h" must be the first
header include through out the project.
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
|\
| |
| |
| |
| | |
Conflicts:
runtime/ctok.c
|
| |
| |
| |
| |
| | |
...and thus could not be used.
but tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=119
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was not honored by the new ompipe module, because it is a local
file directive (it was applied to pipes as a side-effect of using the
same module for pipes and files...). I now made this a global, so that
semantics are the same as previously. Not really nice, but probably
the best thing to do in the current situation (everything else would
involve much more overhead --- leave that for the new config system).
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- improved testbench to contain samples for totally malformed messages
which miss parts of the message content
- bugfix: some malformed messages could lead to a missing LF inside files
or some other missing parts of the template content.
- bugfix: if a message ended immediately with a hostname, the hostname
was mistakenly interpreted as TAG, and localhost be used as hostname
|
| |
| |
| |
| |
| |
| |
| | |
[backported from v5 commit 98d1ed504ec001728955a5bcd7916f64cd85f39f]
This actually was a "recent" regression, but I did not realize that it
was introduced by the performance optimization in v4-devel. Shame on
me for having two devel versions at the same time...
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- bugfix: property replacer returned invalid parameters under some (unusual)
conditions. In extreme cases, this could lead to garbled logs and/or
a system failure.
- bugfix: invalid length returned (often) when using regular expressions
inside the property replacer
- bugfix: submatch regex in property replacer did not honor "return 0 on
no match" config case
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
runtime/queue.c
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
(bugs require certain non-standard settings to appear)
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
This could reslult in the whole rest of a line (including comments)
to be treated as file name in "write to file" actions.
Thanks to Jack for reporting this issue.
|
| | |
| | |
| | |
| | | |
Thanks to Michael Biebl for reporting this bug.
|
| | |
| | |
| | |
| | | |
for example imudp. Thanks to Anton for reporting this bug.
|
| | |
| | |
| | |
| | | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
|\| | |
|
| |\|
| | |
| | |
| | |
| | |
| | | |
Conflicts:
doc/rsyslog_conf.html
runtime/net.c
|
| | |
| | |
| | |
| | |
| | | |
This is the correct patch. The previous one solved the segfault, but
disabled the -q/Q options.
|
|\| | |
|
| |\| |
|
| | |
| | |
| | |
| | |
| | | |
bug tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=157
Thanks to Jonas Nogueira for reporting this bug.
|
| | |
| | |
| | |
| | |
| | |
| | | |
in which debug output can be generated only after the process has started,
but not right from the beginning. This is assumed to be useful for
hard-to-find bugs. Also improved the doc on the debug system.
|
| | |
| | |
| | |
| | | |
this was a regression from the omfile rewrite in 4.5.0
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
ChangeLog
configure.ac
doc/manual.html
plugins/imrelp/imrelp.c
|
| |\| |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
improperly handled.
This was a regression of one of the last bugfixes, so no previously released
version contained this bug (thus it does not show up in the ChangeLog).
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | | |
Max size is now 32K.
|
|\| | | |
|
| | | | |
|
|\| | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
runtime/rsyslog.h
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| / /
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
configure.ac
doc/manual.html
runtime/datetime.h
runtime/parser.c
runtime/rsyslog.h
tools/syslogd.c
v4-stable had a bug with RFC5424-formatted structured data, which showed
was detected by the enhanced automatted testbench of v4-beta.
|
| | |
| | |
| | |
| | | |
could lead to mis-addressing and potential memory corruption/segfault
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
we needed to release ALL resources (including file handles!) only
after the the async writer thread has terminated (else it may access
them). In this case, we had a file handle leak, because the handle was
sometimes only opened in the async writer, but the close was attempted
before the writer even started (in some cases).
|