| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | | | | |
|
| |\| | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
runtime/rsyslog.h
|
| | | | | |
|
| |\ \ \ \
| |/ / /
|/| / /
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
configure.ac
doc/manual.html
runtime/datetime.h
runtime/parser.c
runtime/rsyslog.h
tools/syslogd.c
v4-stable had a bug with RFC5424-formatted structured data, which showed
was detected by the enhanced automatted testbench of v4-beta.
|
| | | |
| | |
| | |
| | | |
could lead to mis-addressing and potential memory corruption/segfault
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
we needed to release ALL resources (including file handles!) only
after the the async writer thread has terminated (else it may access
them). In this case, we had a file handle leak, because the handle was
sometimes only opened in the async writer, but the close was attempted
before the writer even started (in some cases).
|
| | | |
| | |
| | |
| | |
| | |
| | | |
...after we seem to have identified the root cause of the segfault.
I leave them commented out so that we can re-activate it if need
arises (aka "get some practice drill first").
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Most severely affected omfile. The problem was that some buffers were
freed before the asynchronous writer thread was shut down. So the
writer thread accessed invalid data, which may even already be
overwritten. Symptoms (with omfile) were segfaults, grabled data
and files with random names placed around the file system (most
prominently into the root directory). Special thanks to Aaron for
helping to track this down.
|
| | | |
| | |
| | |
| | |
| | | |
if the buffer was too small, we would see more API calls, but no
failure, so this is no fix!
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Problems could lead to abort and/or memory leak. The module is now hardened in a very
conservative way, which is sub-optimal from a performance point of view. This should
be improved if it has proven reliable in practice.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
this could lead to loss of the repeated message content. As a side-
effect, it could probably also be possible that some segfault occurs
(quite unlikely). The root cause was that some counters introduced
during the malloc optimizations were not properly duplicated in
MsgDup(). Note that repeated message processing is not enabled
by default.
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
ChangeLog
configure.ac
doc/manual.html
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A comparison was done between the current and the former source address.
However, this was done on the full sockaddr_storage structure and not
on the host address only. This has now been changed for IPv4 and IPv6.
The end result of this bug could be a higher UDP message loss rate than
necessary (note that UDP message loss can not totally be avoided due
to the UDP spec)
|
| | | |
| | |
| | |
| | |
| | | |
This causes grief with all receivers.
Bug tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=147
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
ChangeLog
configure.ac
doc/manual.html
tests/Makefile.am
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- control character DEL was not properly escaped
- NUL and LF characters were not properly stripped if no control
character replacement was to be done
- NUL characters in the message body were silently dropped (this was
a regeression introduced by some of the recent optimizations)
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
... resulting in some message properties be populated with strings from
previous messages. This was caused by an improper predicate check.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In async write mode, we use modular arithmetic to index the output
buffer array. However, the counter variables accidently were signed,
thus resulting in negative indizes after integer overflow. That in turn
could lead to segfaults, but was depending on the memory layout of
the instance in question (which in turn depended on a number of
variables, like compile settings but also configuration). The counters
are now unsigned (as they always should have been) and so the dangling
mis-indexing does no longer happen. This bug potentially affected all
installations, even if only some may actually have seen a segfault.
|
| | | | |
| | | |
| | | |
| | | | |
Some devices seem to create them and I do not see any harm in supporting that.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This is for another prctl() call, not present in the beta version (looks like it
would make sense to stick these into a utility function)
|
| |\ \ \ \ |
|
| | | | | | |
|
| |\| | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We are doing this to support removal of restart-type HUP in v5.
Elaborate doc added to explain reasoning and actions to be taken.
|
| |\| | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
(double free)
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
optimized substring processing, should bring a small enhancement when
forwarding with the default forwarding templates. Also did some uchar
cleanup in msg.c (thus so many changes, in reality they are few...).
|
| |\| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
tests/nettester.c
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This was a result of an internal processing error if maximum field
sizes had been specified in the property replacer.
Also did some testbench improvements, including omstdout.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
for the stream class and thus finally activating omfile's timeout
capability in a useful way without polling and too-high performance
overhead.
|
| | | | | | |
|
| |\| | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
... when working with disk queues.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
... this is necessary in preparation for the final solution (we need
to have a "unified" writer). If it causes worse performance to have the
zip writher togehter with the synchronous write, we may do an async write...
|
| | | | | | |
|
| |\| | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
(depending on configuration). This was a small change, but with big
results. There is more potential to explore, but the effects were so
dramatic that I think it makes sense to include this fix.
|
| |/ / / /
| | | |
| | | |
| | | |
| | | | |
... seems to work on quick testing, but needs a far more testing
and improvement. Good milestone commit.
|
| | | | |
| | | |
| | | |
| | | | |
Happend e.g. with imuxsock.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This could lead to timestamps written in the wrong format, but not to
an abort.
|
