summaryrefslogtreecommitdiffstats
path: root/action.c
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'v4-stable' into v5-stableRainer Gerhards2011-12-011-1/+1
|\ | | | | | | | | Conflicts: action.c
| * Merge branch 'v3-stable' into v4-stableRainer Gerhards2011-12-011-1/+1
| |\
| | * bugfix: action resume interval incorrectly handled, thus took longer to resumeTomas Heinrich2011-12-011-1/+1
| | | | | | | | | | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | | Merge branch 'v5-stable' of git+ssh://git.adiscon.com/git/rsyslog into v5-stableRainer Gerhards2011-10-171-1/+0
|\ \ \ | | | | | | | | | | | | | | | | Conflicts: ChangeLog
| * | | Merge branch 'v4-stable' into v5-stableRainer Gerhards2011-10-131-1/+0
| |\| |
| | * | bugfix: $ActionExecOnlyOnce interval did not work properlyTomas Heinrich2011-10-131-1/+0
| | | | | | | | | | | | | | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | | | bugfix: ActionQueue could malfunction due to index errorVlad Grigorescu2011-10-171-9/+9
|/ / / | | | | | | | | | Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | | bugfix: mark message processing did not work correctlyRainer Gerhards2011-08-311-25/+23
| | |
* | | removed debug code from action.c and runtime/queue.c after testingAndre Lorbach2011-08-181-17/+0
| | |
* | | bugfix: fixed incorrect state handling for Discard Action (transactions)Andre Lorbach2011-08-181-2/+32
| | |
* | | bugfix: problems in failover action handlingRainer Gerhards2011-06-201-8/+12
| | | | | | | | | | | | closes: http://bugzilla.adiscon.com/show_bug.cgi?id=254
* | | failover problem was not totally solved, now (hopefully ;))Rainer Gerhards2011-06-161-27/+59
| | | | | | | | | | | | I overlooked a border case, which came up on a larger testbench run.
* | | bugfix: problems in failover action handlingRainer Gerhards2011-06-161-47/+93
| | | | | | | | | | | | closes: http://bugzilla.adiscon.com/show_bug.cgi?id=270 (not yet confirmed!)
* | | bugfix: error return from strgen caused abort, now causes action to be ignoredRainer Gerhards2011-03-291-1/+2
| | | | | | | | | | | | ...(just like a failed filter)
* | | Merge branch 'v5-stable' into v5-betaRainer Gerhards2011-03-161-30/+109
|\ \ \ | | | | | | | | | | | | | | | | Conflicts: tests/Makefile.am
| * | | fixed a regression of last patch and some cleanupRainer Gerhards2011-03-161-14/+4
| | | |
| * | | bugfix: failover did not work correctly if repeated msg reduction was onRainer Gerhards2011-03-161-30/+119
| | | | | | | | | | | | | | | | affected directive was: $ActionExecOnlyWhenPreviousIsSuspended on
| * | | bugfix(kind of): tell users that config graph can currently not be generatedRainer Gerhards2011-03-081-1/+2
| | | | | | | | | | | | | | | | closes: http://bugzilla.adiscon.com/show_bug.cgi?id=232
* | | | bugfix: discard action did not work under some circumstancesRainer Gerhards2011-03-071-1/+2
| | | | | | | | | | | | | | | | fixes: http://bugzilla.adiscon.com/show_bug.cgi?id=217
* | | | bugfix: minor race condition in action.c - considered cosmeticRainer Gerhards2011-02-171-12/+13
|/ / / | | | | | | | | | | | | | | | This is considered cosmetic as multiple threads tried to write exactly the same value into the same memory location without sync. The method has been changed so this can no longer happen.
* | | bug fixes in action processingRainer Gerhards2010-12-171-49/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | - bugfix: action processor released mememory too early, resulting in potential issue in retry cases (but very unlikely due to another bug, which I also fixed -- only after the fix this problem here became actually visible). - bugfix: batches which had actions in error were not properly retried in all cases
* | | used a bit more stack (irrelevant) to gain a bit more performance...Rainer Gerhards2010-12-161-1/+2
| | | | | | | | | | | | ... for large batches
* | | bugfix: batch processing flagged invalid message as "bad" under some ↵Rainer Gerhards2010-12-161-2/+2
| | | | | | | | | | | | | | | | | | circumstances also fixed some cosmetic nits
* | | bugfix: replacements for atomic operations for non-int sized types had problems.Rainer Gerhards2010-11-251-1/+1
| | | | | | | | | | | | | | | At least one instance of that problem could potentially lead to abort (inside omfile).
* | | fixing a potentially uninitialized variablev5.6.0Rainer Gerhards2010-10-191-1/+1
| | |
* | | break potential infinite loop in actionDoRetrySteffen Sledz2010-08-051-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | If a module always returns RS_RET_OK (like ompipe does) the actionDoRetry loop may not have leaved faked ACT_STATE_SUSP state in case iResumeOKinRow had ever reached a count of 1000. Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
* | | added missing support for systems without atomic instructionsRainer Gerhards2010-06-241-1/+3
| | |
* | | bugfix: "$ActionExecOnlyWhenPreviousIsSuspended on" was brokenRainer Gerhards2010-06-241-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | Note that, as it looks, the directive was already broken in previous v5 versions. So while I solved what looked like a (intentional) regression from the performance tuning, I actually solved a previous regression as well ;) I have also added new test cases to the testbench in order to capture such problems in the future. This version does now look pretty good in shape.
* | | fixed a couple of regressionsRainer Gerhards2010-06-231-74/+101
| | | | | | | | | | | | | | | | | | | | | | | | by implementing some code that was missing so far ;) as well as finding some real bugs. I also did some general cleanup, removing debug strings and such. This code should be fairly OK to use, except when "exec only when previous action was suspended" is used -- this is NOT yet re-implemented in the tuned engine.
* | | fixed problem in action message induced failure handlingRainer Gerhards2010-06-211-2/+2
| | |
* | | minor cleanupRainer Gerhards2010-06-211-3/+0
| | |
* | | fixed a problem with ACT_MESSAGE_PASSING type of doAction interfaceRainer Gerhards2010-06-151-25/+12
| | |
* | | milestone(BUGGY): batch now pushed down to actionRainer Gerhards2010-06-151-46/+140
| | | | | | | | | | | | | | | | | | | | | at least in important cases (not for non-direct action queues and some other minor things). This version is definitely buggy, but may be tried with success on a non-production system. I will continue to work on the correctness, but needed to commit now to get a baseline.
* | | some cleanupRainer Gerhards2010-06-101-57/+17
| | | | | | | | | | | | | | | as well as some work in preparation of storing doAction params inside the batch
* | | fixed regression for omruleset use caseRainer Gerhards2010-06-101-5/+15
| | | | | | | | | | | | | | | I did not revert to using the action ppMsg data element, as one of the next steps is to remove it by an overall much better solution.
* | | Merge branch 'concurrent-output' into tmpRainer Gerhards2010-06-101-52/+65
|\ \ \
| * | | main msg q consumer now preprocesses messages before doing rule processingRainer Gerhards2010-06-091-14/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | things like ACL check and message parsing. This leads to a greater level of concurrent processing. Beware, though, that this commit duplicates some messages. May be a regression from this or an earlier commit. I will soon sort out.
| * | | added support for high-performance action queue submission if not all mark ↵Rainer Gerhards2010-06-081-38/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | messages should be logged this was previously not properly handeld. This is also the first occurence of a (real) CAS loop inside rsyslog. Note that the performance is now very well in the default configuration, and mark message directives are still correctly being handled. So this code looks close to final, but needs to have some bug cleanup as the testsuite shows.
* | | | fixing msg duplication & loss regression, causes slowdownRainer Gerhards2010-06-101-6/+6
|/ / / | | | | | | | | | | | | | | | | | | | | | messages could get lost or be duplicated due to non-proper sync of transactions. This is a notable slowdown again, but we know how to get back concurrency, it just takes "some" more programming. It is important now to come back to correct code, so that we can base further improvements on that.
* | | performance enhancement: implemented stage 1 firehose mode for actionsRainer Gerhards2010-06-081-12/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... plus some other tests, namely string generation in parallel to action processing. The code is not yet solid and not fully compatible to older versions. But it is good enough for an early commit and some early testing/gaining of experience. The optimization was done based on the fine-grained partitioning paradigm worked on the past couple of weeks -- seems to work out really great :)
* | | bugfix: regression caused more locking action in msg.c than necessaryRainer Gerhards2010-06-081-1/+0
| | | | | | | | | | | | also: bugfix: mutexes used to similate atomic instructions were not destructed
* | | added new cancel-reduced action thread termination methodRainer Gerhards2010-05-171-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | We now manage to cancel threads that block inside a retry loop to terminate without the need to cancel the thread. Avoiding cancellation helps keep the system complexity minimal and thus provides for better stability. This also solves some issues with improper shutdown when inside an action retry loop.
* | | Merge branch 'v5-stable'Rainer Gerhards2010-04-261-4/+23
|\ \ \
| * | | cosmetic: removed left-over debug messageRainer Gerhards2010-04-261-1/+0
| | | |
| * | | bugfix(kind of): output plugin retry behaviour could cause engine to loopRainer Gerhards2010-04-261-4/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The rsyslog engine did not guard itself against output modules that do not properly convey back the tryResume() behaviour. This then leads to what looks like an endless loop. I consider this to be a bug of the engine not only because it should be hardened against plugin misbehaviour, but also because plugins may not be totally able to avoid this situation (depending on the type of and processing done by the plugin).
* | | | Merge branch 'v4-devel' into masterRainer Gerhards2010-04-231-11/+11
|\ \ \ \ | | |/ / | |/| | | | | | | | | | | | | | Conflicts: runtime/rsyslog.h runtime/wtp.c
| * | | solved alignment errors on Solaris SparcRainer Gerhards2010-04-221-10/+10
| | | |
* | | | Merge branch 'beta' into masterRainer Gerhards2010-04-091-1/+1
|\ \ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: ChangeLog configure.ac plugins/imudp/imudp.c runtime/stream.h tests/Makefile.am tests/diag.sh tools/omfile.c
| * | | Merge branch 'v4-stable' into v5-stableRainer Gerhards2010-03-291-1/+1
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: ChangeLog configure.ac doc/manual.html runtime/debug.c runtime/stream.c tests/Makefile.am tests/diskqueue.sh tests/nettester.c tools/omfile.c
| | * | bugfix: potential re-use of free()ed file stream object in omfileRainer Gerhards2010-03-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | when dynaCache is enabled, the cache is full, a new entry needs to be allocated, thus the LRU discarded, then a new entry is opend and that fails. In that case, it looks like the discarded stream may be reused improperly (based on code analysis, test case and confirmation pending)