| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| |
| | |
currently being accessed buffer could be overwritten with new data.
While this probably did not cause access violations, it could case loss
and/or duplication of some data (definitely a race with no deterministic
outcome)
|
| |
| |
| |
| |
| | |
predicate was not properly checked when waiting for the background file
writer
|
| | |
|
| |
| |
| |
| |
| | |
Internal data structures were not properly protected due to missing
mutex calls.
|
| |
| |
| |
| |
| | |
... it turns out that this is sometimes extremely useful when debugging
real-world problems at user sites.
|
| | |
|
| |
| |
| |
| |
| |
| | |
Note that this introduces a test case that breaks the current code. This
commit does NOT yet provide the necessary code patch. Thus "make check"
does currently hang.
|
| |
| |
| |
| |
| |
| | |
Note that this introduces a test case that breaks the current code. This
commit does NOT yet provide the necessary code patch. Thus make check
does currently hang.
|
| |
| |
| |
| | |
(this is primarily meant as a debug aid)
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
This could only happen during config file parsing.
|
| |
| |
| |
| |
| | |
this is an excerpt from some of the more intensen manual tests
I am doing, stripped down to be useful inside the testbench.
|
| | |
|
| |
| |
| |
| |
| |
| | |
Previously, it could lead to garbagge output and, in extreme cases, also
to segfaults. Note: this was a problem only when debug output was
actually enabled, so it caused no problem in production use.
|
| |
| |
| |
| | |
also improved testing tools to support new testcase structure
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
this is a perquisite to support more flexible testing modes, which
could not intelligently be implemented with the old interface
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | | |
disk queue mode did no longer work correctly. A side-effect of
this commit here is slightly cleaned-up (and more elegant) code
for circular files.
|
|/ /
| |
| |
| |
| |
| | |
note that a buffer size calculation was done wrong, but this was cosmetic
because our buffers currently all use byte size, so even though the
formula was wrong, the result was correct.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- improved testbench
- bugfix: potential data loss during file stream shutdown
- bugfix: potential problems during file stream shutdown
The shutdown/close sequence was not clean, what potentially (but
unlikely) could lead to some issues. We have not been able to describe
any fatal cases, but there was some bug potential. Sequence has now
been straighted out.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a write error occured in stream.c, variable iWritten had the error
code but this was handled as if it were the actual number of bytes
written. That was used in pointer arithmetic later on, and thus could
lead to all sorts of problems. However, this could only happen if the
error was EINTR or the file in question was a tty. All other cases were
handled properly. Now, iWritten is reset to zero in such cases, resulting
in proper retries.
|
| |
| |
| |
| |
| | |
required because due to bug the default was actually different than
specified (or better said: spec was inconsistent in doc as well).
|
| | |
|
| |
| |
| |
| |
| | |
primarily to ease migration from syslog-ng. See property replacer doc for
details. [backport from 5.5.3 because urgently needed by some]
|
| | |
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| | |
including proper credits to Mandriva team.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- _FILE_OFFSET_BITS must be defined before including any other system
headers otherwise it does nothing.
- Don't define it in rsyslog.h, let it be defined in config.h,
and let ./configure script enable LFS since Autoconf provides
a portable macro to enable LFS support : AC_SYS_LARGEFILE
|
| |
| |
| |
| |
| |
| |
| | |
For consistency, ./configure generated "config.h" must be the first
header include through out the project.
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| |
| |
| |
| |
| | |
on some platforms (namely Debian sid). This smells like a bug in zlib.
Thanks to Michael Biebl for reporting the issue.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- bugfix: potential segfault in omfile when a dynafile open failed
In that case, a partial cache entry was written, and some internal
pointers (iCurrElt) not correctly updated. In the next iteration, that
could lead to a segfault, especially if iCurrElt then points to the
then-partial record. Not very likely, but could happen in practice.
- bugfix (theoretical): potential segfault in omfile under low memory
condition. This is only a theoretical bug, because it would only
happen when strdup() fails to allocate memory - which is highly
unlikely and will probably lead to all other sorts of errors.
|
| |
| |
| |
| | |
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | |
|
|\|
| |
| |
| |
| | |
Conflicts:
runtime/ctok.c
|
| |
| |
| |
| |
| | |
...and thus could not be used.
but tracker: http://bugzilla.adiscon.com/show_bug.cgi?id=119
|
| | |
|
| |
| |
| |
| |
| | |
Note that I now also prefer to use utmp.h if it is present - this seems
to be much better under Linux.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was not honored by the new ompipe module, because it is a local
file directive (it was applied to pipes as a side-effect of using the
same module for pipes and files...). I now made this a global, so that
semantics are the same as previously. Not really nice, but probably
the best thing to do in the current situation (everything else would
involve much more overhead --- leave that for the new config system).
|
| |
| |
| |
| |
| | |
bugtracker: http://bugzilla.adiscon.com/show_bug.cgi?id=181
Thanks to Christiano for reporting.
|
| |
| |
| |
| |
| |
| |
| | |
$InputUDPServerRun config variable does not exist, should be $UDPServerRun
instead http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=571202
Signed-off-by: Rainer Gerhards <rgerhards@adiscon.com>
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
... based on old omfile. Michael Biebl reported that xconsole seems
to have some issues with the new pipe code, so it was best to use
the old code for pipes. The optimizations were done to speed up file
access, so it doesn't really matter pipes do not receive them.
|
| |
| |
| |
| | |
while the rest of the entry correctly said it was stable.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- improved testbench to contain samples for totally malformed messages
which miss parts of the message content
- bugfix: some malformed messages could lead to a missing LF inside files
or some other missing parts of the template content.
- bugfix: if a message ended immediately with a hostname, the hostname
was mistakenly interpreted as TAG, and localhost be used as hostname
|