diff options
| -rw-r--r-- | runtime/atomic.h | 7 | ||||
| -rw-r--r-- | tools/syslogd.c | 5 |
2 files changed, 12 insertions, 0 deletions
diff --git a/runtime/atomic.h b/runtime/atomic.h index ec7acb8c..fdf64214 100644 --- a/runtime/atomic.h +++ b/runtime/atomic.h @@ -47,6 +47,13 @@ # define ATOMIC_FETCH_32BIT(data) ((unsigned) __sync_fetch_and_and(&(data), 0xffffffff)) # define ATOMIC_STORE_1_TO_32BIT(data) __sync_lock_test_and_set(&(data), 1) #else + /* note that we gained parctical proof that theoretical problems DO occur + * if we do not properly address them. See this blog post for details: + * http://blog.gerhards.net/2009/01/rsyslog-data-race-analysis.html + * The bottom line is that if there are no atomics available, we should NOT + * simply go ahead and do without them - use mutexes or other things. The + * code needs to be checked against all those cases. -- rgerhards, 2009-01-30 + */ # warning "atomic builtins not available, using nul operations - rsyslogd will probably be racy!" # define ATOMIC_INC(data) (++(data)) # define ATOMIC_DEC(data) (--(data)) diff --git a/tools/syslogd.c b/tools/syslogd.c index 853a97f7..9ced4562 100644 --- a/tools/syslogd.c +++ b/tools/syslogd.c @@ -2910,6 +2910,11 @@ static void printVersion(void) #else printf("\tFEATURE_DEBUG (debug build, slow code):\tNo\n"); #endif +#ifdef HAVE_ATOMIC_BUILTINS + printf("\tAtomic operations supported:\t\tYes\n"); +#else + printf("\tAtomic operations supported:\t\tNo\n"); +#endif #ifdef RTINST printf("\tRuntime Instrumentation (slow code):\tYes\n"); #else |