diff options
| author | Rainer Gerhards <rgerhards@adiscon.com> | 2009-01-30 15:40:53 +0100 |
|---|---|---|
| committer | Rainer Gerhards <rgerhards@adiscon.com> | 2009-01-30 15:40:53 +0100 |
| commit | 25245cc682bd1a4854cc8b33e301bb4f0cb48fc6 (patch) | |
| tree | 8242733fdc3bdf3199786cd271e8fd839dabbfbb /runtime | |
| parent | b54797da054a74144f10dfeb0daeca99decd9b12 (diff) | |
| download | rsyslog-25245cc682bd1a4854cc8b33e301bb4f0cb48fc6.tar.gz rsyslog-25245cc682bd1a4854cc8b33e301bb4f0cb48fc6.tar.xz rsyslog-25245cc682bd1a4854cc8b33e301bb4f0cb48fc6.zip | |
added info if atomic ops are available to rsyslogd -v output
Diffstat (limited to 'runtime')
| -rw-r--r-- | runtime/atomic.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/runtime/atomic.h b/runtime/atomic.h index 2c20e0c3..10dbac90 100644 --- a/runtime/atomic.h +++ b/runtime/atomic.h @@ -46,6 +46,13 @@ # define ATOMIC_FETCH_32BIT(data) ((unsigned) __sync_fetch_and_and(&(data), 0xffffffff)) # define ATOMIC_STORE_1_TO_32BIT(data) __sync_lock_test_and_set(&(data), 1) #else + /* note that we gained parctical proof that theoretical problems DO occur + * if we do not properly address them. See this blog post for details: + * http://blog.gerhards.net/2009/01/rsyslog-data-race-analysis.html + * The bottom line is that if there are no atomics available, we should NOT + * simply go ahead and do without them - use mutexes or other things. The + * code needs to be checked against all those cases. -- rgerhards, 2009-01-30 + */ # warning "atomic builtins not available, using nul operations - rsyslogd will probably be racy!" # define ATOMIC_INC(data) (++(data)) # define ATOMIC_DEC_AND_FETCH(data) (--(data)) |