summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRainer Gerhards <rgerhards@adiscon.com>2008-10-09 13:00:36 +0200
committerRainer Gerhards <rgerhards@adiscon.com>2008-10-09 13:00:36 +0200
commit25b0036fcb6ea54251fcb82e245366bbbaa71e58 (patch)
tree0066a559a4f2fc1ef25425a7fe9ebd0d775d6da8
parent39000a62024510cd62607200e6100e3cd7c05005 (diff)
parentd5a3d4b3a7151906a4eec59ec20fc7c90cefde8c (diff)
downloadrsyslog-25b0036fcb6ea54251fcb82e245366bbbaa71e58.tar.gz
rsyslog-25b0036fcb6ea54251fcb82e245366bbbaa71e58.tar.xz
rsyslog-25b0036fcb6ea54251fcb82e245366bbbaa71e58.zip
Merge branch 'beta'
-rw-r--r--ChangeLog3
-rw-r--r--runtime/queue.c2
2 files changed, 4 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 7e9580d9..24442f8f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -285,6 +285,9 @@ Version 3.18.5 (rgerhards), 2008-10-??
because getnameinfo() is not cancel-safe, but was not guarded against
being cancelled. pthread_cancel() is routinely being called during
HUP processing.
+- bugfix[minor]: if queue size reached light_delay mark, enqueuing
+ could potentially be blocked for a longer period of time, which
+ was not the behaviour desired.
- doc bugfix: $ActionExecOnlyWhenPreviousIsSuspended was still misspelled
as $...OnlyIfPrev... in some parts of the documentation. Thanks to
Lorenzo M. Catucci for reporting this bug.
diff --git a/runtime/queue.c b/runtime/queue.c
index 76c2f10f..9dd92019 100644
--- a/runtime/queue.c
+++ b/runtime/queue.c
@@ -2145,7 +2145,7 @@ queueEnqObj(queue_t *pThis, flowControl_t flowCtlType, void *pUsr)
pthread_cond_wait(&pThis->belowFullDlyWtrMrk, pThis->mut); /* TODO error check? But what do then? */
}
} else if(flowCtlType == eFLOWCTL_LIGHT_DELAY) {
- while(pThis->iQueueSize >= pThis->iLightDlyMrk) {
+ if(pThis->iQueueSize >= pThis->iLightDlyMrk) {
dbgoprint((obj_t*) pThis, "enqueueMsg: LightDelay mark reached for light delayble message - blocking a bit.\n");
timeoutComp(&t, 1000); /* 1000 millisconds = 1 second TODO: make configurable */
pthread_cond_timedwait(&pThis->belowLightDlyWtrMrk, pThis->mut, &t); /* TODO error check? But what do then? */