summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRainer Gerhards <rgerhards@adiscon.com>2008-04-03 13:57:18 +0000
committerRainer Gerhards <rgerhards@adiscon.com>2008-04-03 13:57:18 +0000
commit61931c57c39de8d2dbeb0a6a6d27e2762e1821d4 (patch)
tree689e6fd93c1eeb801d70b32baecf71ac8feb307a
parent6b982c8e5dbfd54eff7e22291d7f63400ff3c555 (diff)
downloadrsyslog-61931c57c39de8d2dbeb0a6a6d27e2762e1821d4.tar.gz
rsyslog-61931c57c39de8d2dbeb0a6a6d27e2762e1821d4.tar.xz
rsyslog-61931c57c39de8d2dbeb0a6a6d27e2762e1821d4.zip
bugfix: some memory leak when queue is runing in disk mode
-rw-r--r--ChangeLog1
-rw-r--r--obj.c12
2 files changed, 11 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 21f330e7..40774e36 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -9,6 +9,7 @@ Version 3.15.1 (rgerhards), 2008-04-??
happens during startup)
- bugfix: memory leaks in script engine
- bugfix: $hostname and $fromhost in RainerScript did not work
+- bugfix: some memory leak when queue is runing in disk mode
---------------------------------------------------------------------------
Version 3.15.0 (rgerhards), 2008-04-01
- major new feature: imrelp/omrelp support reliable delivery of syslog
diff --git a/obj.c b/obj.c
index 0baaf7a1..d408c4bb 100644
--- a/obj.c
+++ b/obj.c
@@ -731,7 +731,7 @@ finalize_it:
static rsRetVal objDeserializeProperties(obj_t *pObj, objInfo_t *pObjInfo, strm_t *pStrm)
{
DEFiRet;
- var_t *pVar;
+ var_t *pVar = NULL;
ISOBJ_assert(pObj);
ISOBJ_TYPE_assert(pStrm, strm);
@@ -743,15 +743,23 @@ static rsRetVal objDeserializeProperties(obj_t *pObj, objInfo_t *pObjInfo, strm_
iRet = objDeserializeProperty(pVar, pStrm);
while(iRet == RS_RET_OK) {
CHKiRet(pObjInfo->objMethods[objMethod_SETPROPERTY](pObj, pVar));
+ /* re-init var object - TODO: method of var! */
+ rsCStrDestruct(&pVar->pcsName); /* no longer needed */
+ if(pVar->varType == VARTYPE_STR) {
+ if(pVar->val.pStr != NULL)
+ rsCStrDestruct(&pVar->val.pStr);
+ }
iRet = objDeserializeProperty(pVar, pStrm);
}
- var.Destruct(&pVar);
if(iRet != RS_RET_NO_PROPLINE)
FINALIZE;
CHKiRet(objDeserializeTrailer(pStrm)); /* do trailer checks */
finalize_it:
+ if(pVar != NULL)
+ var.Destruct(&pVar);
+
RETiRet;
}