From 5b22de807871c25ed68071a64422f4c336fdc8d4 Mon Sep 17 00:00:00 2001 From: Miloslav Trmač Date: Wed, 18 Jul 2012 15:59:00 +0200 Subject: Fix a memory leak on error paths MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Miloslav Trmač --- lib/umberlog.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/umberlog.c b/lib/umberlog.c index 722a4e8..b61b053 100644 --- a/lib/umberlog.c +++ b/lib/umberlog.c @@ -371,13 +371,12 @@ _ul_vformat (ul_buffer_t *buffer, int format_version, /* "&ap" may not be possible for function parameters, so make a copy. */ va_copy (ap, ap_orig); - value = _ul_vasprintf_and_advance (msg_format, &ap); - if (!value) - goto err; - if (ul_buffer_reset (buffer) != 0) goto err; + value = _ul_vasprintf_and_advance (msg_format, &ap); + if (!value) + goto err; buffer = ul_buffer_append (buffer, "msg", value); free (value); -- cgit