summaryrefslogtreecommitdiffstats
path: root/net/unix/af_unix.c
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2010-09-01 00:50:51 +0000
committerGreg Kroah-Hartman <gregkh@suse.de>2010-09-26 17:18:11 -0700
commit76dcdc683e9ab26c0227d9f40b390edba9fca621 (patch)
tree2cbd32efb0b63065633eb5acd4a076132ab409e9 /net/unix/af_unix.c
parent5d92da4418de42f1f85920f84d81a66bb559727e (diff)
downloadkernel-crypto-76dcdc683e9ab26c0227d9f40b390edba9fca621.tar.gz
kernel-crypto-76dcdc683e9ab26c0227d9f40b390edba9fca621.tar.xz
kernel-crypto-76dcdc683e9ab26c0227d9f40b390edba9fca621.zip
gro: fix different skb headrooms
[ Upstream commit 3d3be4333fdf6faa080947b331a6a19bce1a4f57 ] Packets entering GRO might have different headrooms, even for a given flow (because of implementation details in drivers, like copybreak). We cant force drivers to deliver packets with a fixed headroom. 1) fix skb_segment() skb_segment() makes the false assumption headrooms of fragments are same than the head. When CHECKSUM_PARTIAL is used, this can give csum_start errors, and crash later in skb_copy_and_csum_dev() 2) allocate a minimal skb for head of frag_list skb_gro_receive() uses netdev_alloc_skb(headroom + skb_gro_offset(p)) to allocate a fresh skb. This adds NET_SKB_PAD to a padding already provided by netdevice, depending on various things, like copybreak. Use alloc_skb() to allocate an exact padding, to reduce cache line needs: NET_SKB_PAD + NET_IP_ALIGN bugzilla : https://bugzilla.kernel.org/show_bug.cgi?id=16626 Many thanks to Plamen Petrov, testing many debugging patches ! With help of Jarek Poplawski. Reported-by: Plamen Petrov <pvp-lsts@fs.uni-ruse.bg> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> CC: Jarek Poplawski <jarkao2@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions