diff options
| author | Oleg Nesterov <oleg@tv-sign.ru> | 2007-08-10 15:21:17 -0700 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2007-08-13 22:52:09 -0700 |
| commit | d725fdc8027a4cd961f58d92917fbb91b171abfa (patch) | |
| tree | 5e437314aa2f2c6e59705c4deb45e50959317099 /net/dccp | |
| parent | b5890d8ba47741425fe3c0d753e1b57bc0561b7b (diff) | |
| download | kernel-crypto-d725fdc8027a4cd961f58d92917fbb91b171abfa.tar.gz kernel-crypto-d725fdc8027a4cd961f58d92917fbb91b171abfa.tar.xz kernel-crypto-d725fdc8027a4cd961f58d92917fbb91b171abfa.zip | |
[DCCP]: fix theoretical ccids_{read,write}_lock() race
Make sure that spin_unlock_wait() is properly ordered wrt atomic_inc().
(akpm: can't we convert this code to use rwlocks?)
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dccp')
| -rw-r--r-- | net/dccp/ccid.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/dccp/ccid.c b/net/dccp/ccid.c index ccbf72c793b..c45088b5e6f 100644 --- a/net/dccp/ccid.c +++ b/net/dccp/ccid.c @@ -40,6 +40,7 @@ static inline void ccids_write_unlock(void) static inline void ccids_read_lock(void) { atomic_inc(&ccids_lockct); + smp_mb__after_atomic_inc(); spin_unlock_wait(&ccids_lock); } |