summaryrefslogtreecommitdiffstats
path: root/drivers/gpu
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2010-04-01 15:13:57 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2010-04-26 07:47:46 -0700
commit1628711eab4c0e5b82416b609e38e67a92006c13 (patch)
tree5ec9200be42715ba3c4a6c94cfbc81086a89f642 /drivers/gpu
parent898b5ece63b796443073f505a4403a35906f1b0b (diff)
downloadkernel-crypto-1628711eab4c0e5b82416b609e38e67a92006c13.tar.gz
kernel-crypto-1628711eab4c0e5b82416b609e38e67a92006c13.tar.xz
kernel-crypto-1628711eab4c0e5b82416b609e38e67a92006c13.zip
oom: fix the unsafe usage of badness() in proc_oom_score()
commit b95c35e76b29ba812e5dabdd91592e25ec640e93 upstream. proc_oom_score(task) has a reference to task_struct, but that is all. If this task was already released before we take tasklist_lock - we can't use task->group_leader, it points to nowhere - it is not safe to call badness() even if this task is ->group_leader, has_intersects_mems_allowed() assumes it is safe to iterate over ->thread_group list. - even worse, badness() can hit ->signal == NULL Add the pid_alive() check to ensure __unhash_process() was not called. Also, use "task" instead of task->group_leader. badness() should return the same result for any sub-thread. Currently this is not true, but this should be changed anyway. Signed-off-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/gpu')
0 files changed, 0 insertions, 0 deletions