summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2009-05-24 18:45:17 -0400
committerSteve French <sfrench@us.ibm.com>2009-05-26 21:09:14 +0000
commit46a7574caf5bc533c24b315800ed323c187614f5 (patch)
tree2afb4ee1af82a06fa16a9ae4b14dedeec7addbce
parente2a1b9ee2335c35e0e34c88a024481b194b3c9cc (diff)
downloadkernel-crypto-46a7574caf5bc533c24b315800ed323c187614f5.tar.gz
kernel-crypto-46a7574caf5bc533c24b315800ed323c187614f5.tar.xz
kernel-crypto-46a7574caf5bc533c24b315800ed323c187614f5.zip
cifs: fix artificial limit on reading symlinks
There's no reason to limit the size of a symlink that we can read to 4000 bytes. That may be nowhere near PATH_MAX if the server is sending UCS2 strings. CIFS should be able to read in a symlink up to the size of the buffer. The size of the header has already been accounted for when creating the slabcache, so CIFSMaxBufSize should be the correct size to pass in. Fixes samba bug #6384. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
-rw-r--r--fs/cifs/cifssmb.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index d06260251c3..aece2a8c1a7 100644
--- a/fs/cifs/cifssmb.c
+++ b/fs/cifs/cifssmb.c
@@ -2427,8 +2427,7 @@ querySymLinkRetry:
params = 2 /* level */ + 4 /* rsrvd */ + name_len /* incl null */ ;
pSMB->TotalDataCount = 0;
pSMB->MaxParameterCount = cpu_to_le16(2);
- /* BB find exact max data count below from sess structure BB */
- pSMB->MaxDataCount = cpu_to_le16(4000);
+ pSMB->MaxDataCount = cpu_to_le16(CIFSMaxBufSize);
pSMB->MaxSetupCount = 0;
pSMB->Reserved = 0;
pSMB->Flags = 0;