summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVlad Yasevich <vladislav.yasevich@hp.com>2010-09-15 10:00:26 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2010-09-26 17:18:42 -0700
commit21a32e679ffa7491e89bfbefa0d36413ca9cb64c (patch)
tree8784ba7f7dfa5ff4384d2dd98b1924595c57d4b5
parent2178c26dbdca2ac63c0e4183aa9e570e2ffe593e (diff)
downloadkernel-crypto-21a32e679ffa7491e89bfbefa0d36413ca9cb64c.tar.gz
kernel-crypto-21a32e679ffa7491e89bfbefa0d36413ca9cb64c.tar.xz
kernel-crypto-21a32e679ffa7491e89bfbefa0d36413ca9cb64c.zip
sctp: Do not reset the packet during sctp_packet_config().
commit 4bdab43323b459900578b200a4b8cf9713ac8fab upstream. sctp_packet_config() is called when getting the packet ready for appending of chunks. The function should not touch the current state, since it's possible to ping-pong between two transports when sending, and that can result packet corruption followed by skb overlfow crash. Reported-by: Thomas Dreibholz <dreibh@iem.uni-due.de> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--net/sctp/output.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sctp/output.c b/net/sctp/output.c
index a646681f5ac..bcc4590ccaf 100644
--- a/net/sctp/output.c
+++ b/net/sctp/output.c
@@ -92,7 +92,6 @@ struct sctp_packet *sctp_packet_config(struct sctp_packet *packet,
SCTP_DEBUG_PRINTK("%s: packet:%p vtag:0x%x\n", __func__,
packet, vtag);
- sctp_packet_reset(packet);
packet->vtag = vtag;
if (ecn_capable && sctp_packet_empty(packet)) {