summaryrefslogtreecommitdiffstats
path: root/sechecker/modules/spurious_audit.c
blob: 21698dfe002e863805603e78e4d099100c678ac1 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
/**
 *  @file
 *  Implementation of the spurious audit rule module.
 *
 *  @author Kevin Carr kcarr@tresys.com
 *  @author Jeremy A. Mowery jmowery@tresys.com
 *  @author Jason Tang jtang@tresys.com
 *  @author Ryan Jordan rjordan@tresys.com
 *
 *  Copyright (C) 2005-2007 Tresys Technology, LLC
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with this program; if not, write to the Free Software
 *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 */

#include "sechecker.h"
#include "spurious_audit.h"
#include <apol/policy-query.h>

#include <stdio.h>
#include <string.h>
#include <errno.h>

/* This string is the name of the module and should match the stem
 * of the file name; it should also match the prefix of all functions
 * defined in this module and the private data storage structure */
static const char *const mod_name = "spurious_audit";

/* The register function registers all of a module's functions
 * with the library.  */
int spurious_audit_register(sechk_lib_t * lib)
{
	sechk_module_t *mod = NULL;
	sechk_fn_t *fn_struct = NULL;

	if (!lib) {
		ERR(NULL, "%s", "no library");
		errno = EINVAL;
		return -1;
	}

	/* Modules are declared by the config file and their name and options
	 * are stored in the module array.  The name is looked up to determine
	 * where to store the function structures */
	mod = sechk_lib_get_module(mod_name, lib);
	if (!mod) {
		ERR(NULL, "%s%s%s", "module unknown, \"", mod_name, "\"");
		errno = ENOENT;
		return -1;
	}

	mod->parent_lib = lib;

	/* assign the descriptions */
	mod->brief_description = "audit rules with no effect";
	mod->detailed_description =
		"--------------------------------------------------------------------------------\n"
		"This module finds audit rules in the policy which do not affect the auditing of\n"
		"the policy.  This could happen in the following situations:\n"
		"\n"
		"   1) there is an allow rule with the same key and permissions for a dontaudit\n"
		"      rule\n"
		"   2) there is an auditallow rule without an allow rule with the same key or\n"
		"      with permissions that do not appear in an allow rule with the same key.\n";
	mod->opt_description =
		"  Module requirements:\n" "    none\n" "  Module dependencies:\n" "    none\n" "  Module options:\n" "    none\n";
	mod->severity = SECHK_SEV_LOW;

	/* register functions */
	fn_struct = sechk_fn_new();
	if (!fn_struct) {
		ERR(lib->policy, "%s", strerror(errno));
		errno = ENOMEM;
		return -1;
	}
	fn_struct->name = strdup(SECHK_MOD_FN_INIT);
	if (!fn_struct->name) {
		ERR(lib->policy, "%s", strerror(ENOMEM));
		errno = ENOMEM;
		return -1;
	}
	fn_struct->fn = spurious_audit_init;
	apol_vector_append(mod->functions, (void *)fn_struct);

	fn_struct = sechk_fn_new();
	if (!fn_struct) {
		ERR(lib->policy, "%s", strerror(errno));
		errno = ENOMEM;
		return -1;
	}
	fn_struct->name = strdup(SECHK_MOD_FN_RUN);
	if (!fn_struct->name) {
		ERR(lib->policy, "%s", strerror(ENOMEM));
		errno = ENOMEM;
		return -1;
	}
	fn_struct->fn = spurious_audit_run;
	apol_vector_append(mod->functions, (void *)fn_struct);

	mod->data_free = NULL;

	fn_struct = sechk_fn_new();
	if (!fn_struct) {
		ERR(lib->policy, "%s", strerror(errno));
		errno = ENOMEM;
		return -1;
	}
	fn_struct->name = strdup(SECHK_MOD_FN_PRINT);
	if (!fn_struct->name) {
		ERR(lib->policy, "%s", strerror(ENOMEM));
		errno = ENOMEM;
		return -1;
	}
	fn_struct->fn = spurious_audit_print;
	apol_vector_append(mod->functions, (void *)fn_struct);

	return 0;
}

/* The init function creates the module's private data storage object
 * and initializes its values based on the options parsed in the config
 * file. */
int spurious_audit_init(sechk_module_t * mod, apol_policy_t * policy, void *arg __attribute__ ((unused)))
{
	if (!mod || !policy) {
		ERR(policy, "%s", strerror(EINVAL));
		errno = EINVAL;
		return -1;
	}
	if (strcmp(mod_name, mod->name)) {
		ERR(policy, "%s%s%s", "wrong module (", mod->name, ")");
		errno = EINVAL;
		return -1;
	}

	mod->data = NULL;

	return 0;
}

/* The run function performs the check. This function runs only once
 * even if called multiple times. This function allocates the result
 * structure and fills in all relavant item and proof data. */
int spurious_audit_run(sechk_module_t * mod, apol_policy_t * policy, void *arg __attribute__ ((unused)))
{
	sechk_result_t *res = NULL;
	sechk_item_t *item = NULL;
	sechk_proof_t *proof = NULL;
	int error, rule_found;
	apol_avrule_query_t *query = 0;
	apol_vector_t *allow_rules = NULL, *auditallow_rules = NULL;
	apol_vector_t *dontaudit_rules = NULL, *perm_vector1 = NULL;
	apol_vector_t *perm_vector2 = NULL, *perm_intersection = NULL;
	apol_vector_t *tmp_v = NULL;
	size_t i, j, k, l, tmp_counter;
	const qpol_avrule_t *rule1, *rule2;
	const qpol_type_t *source, *target;
	const qpol_class_t *object;
	qpol_iterator_t *perm_iter1, *perm_iter2;
	qpol_policy_t *q = apol_policy_get_qpol(policy);
	char *string1, *string2, *tmp;
	const char *src_name, *tgt_name, *obj_name, *perms;

	error = rule_found = 0;
	allow_rules = auditallow_rules = dontaudit_rules = perm_vector1 = perm_vector2 = perm_intersection = NULL;
	rule1 = rule2 = 0;
	source = target = NULL;
	perm_iter1 = perm_iter2 = NULL;
	string1 = string2 = tmp = NULL;
	src_name = tgt_name = obj_name = perms = NULL;

	if (!mod || !policy) {
		ERR(NULL, "%s", strerror(EINVAL));
		errno = EINVAL;
		return -1;
	}
	if (strcmp(mod_name, mod->name)) {
		ERR(policy, "%s%s%s", "wrong module (", mod->name, ")");
		errno = EINVAL;
		return -1;
	}

	/* if already run return */
	if (mod->result)
		return 0;

	res = sechk_result_new();
	if (!res) {
		error = errno;
		ERR(policy, "%s", strerror(error));
		errno = error;
		return -1;
	}
	res->test_name = strdup(mod_name);
	if (!res->test_name) {
		error = errno;
		ERR(policy, "%s", strerror(error));
		goto spurious_audit_run_fail;
	}
	res->item_type = SECHK_ITEM_AVRULE;

	query = apol_avrule_query_create();
	if (!query) {
		error = errno;
		ERR(policy, "%s", strerror(error));
		goto spurious_audit_run_fail;
	}

	apol_avrule_query_set_rules(policy, query, QPOL_RULE_AUDITALLOW);
	if (apol_avrule_get_by_query(policy, query, &auditallow_rules)) {
		error = errno;
		ERR(policy, "%s", strerror(error));
		goto spurious_audit_run_fail;
	}

	apol_avrule_query_set_rules(policy, query, QPOL_RULE_DONTAUDIT);
	if (apol_avrule_get_by_query(policy, query, &dontaudit_rules)) {
		error = errno;
		ERR(policy, "%s", strerror(error));
		goto spurious_audit_run_fail;
	}

	/* First error case: Allow && Don't Audit */
	for (i = 0; i < apol_vector_get_size(dontaudit_rules); i++) {
		/* get first (DONT_AUDIT) rule */
		rule1 = (qpol_avrule_t *) apol_vector_get_element(dontaudit_rules, i);
		if (!rule1) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}

		/* get source, target, object for Don't Audit rule */
		if (qpol_avrule_get_source_type(q, rule1, &source)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		if (qpol_avrule_get_target_type(q, rule1, &target)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		if (qpol_avrule_get_object_class(q, rule1, &object)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}

		/* extract name strings from source, target, object */
		if (qpol_type_get_name(q, source, &src_name)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		if (qpol_type_get_name(q, target, &tgt_name)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		if (qpol_class_get_name(q, object, &obj_name)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}

		/* configure Allow rule query to match above Don't Audit rule */
		apol_avrule_query_set_rules(policy, query, QPOL_RULE_ALLOW);
		apol_avrule_query_set_source(policy, query, src_name, 1);
		apol_avrule_query_set_target(policy, query, tgt_name, 1);
		apol_avrule_query_append_class(policy, query, NULL);
		apol_avrule_query_append_class(policy, query, obj_name);

		/* get vector of matching ALLOW rules */
		if (apol_avrule_get_by_query(policy, query, &allow_rules)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}

		if (apol_vector_get_size(allow_rules) != 0) {
			/* Bad News: Allow && Don't Audit */
			for (j = 0; j < apol_vector_get_size(allow_rules); j++) {
				/* get second (Allow) rule */
				rule2 = (qpol_avrule_t *) apol_vector_get_element(allow_rules, j);
				if (!rule2) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}

				/* get permission iterators for both rules, and make vectors from them */
				if (qpol_avrule_get_perm_iter(q, rule1, &perm_iter1)) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
				perm_vector1 = apol_vector_create_from_iter(perm_iter1, free);
				if (!perm_vector1) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}

				if (qpol_avrule_get_perm_iter(q, rule2, &perm_iter2)) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
				perm_vector2 = apol_vector_create_from_iter(perm_iter2, free);
				if (!perm_vector2) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}

				/* create intersection of permissions */
				perm_intersection = apol_vector_create_from_intersection(perm_vector1,
											 perm_vector2, apol_str_strcmp, NULL);
				if (!perm_intersection) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}

				if (apol_vector_get_size(perm_intersection) != 0) {
					proof = sechk_proof_new(NULL);
					if (!proof) {
						error = errno;
						ERR(policy, "%s", strerror(error));
						goto spurious_audit_run_fail;
					}
					proof->elem = (void *)rule2;	/* proof is the allow rule */
					proof->type = SECHK_ITEM_AVRULE;
					/* text will show the permissions that conflict */
					tmp_counter = 0;
					for (k = 0; k < apol_vector_get_size(perm_intersection); k++) {
						apol_str_append(&(proof->text), &tmp_counter,
								(char *)apol_vector_get_element(perm_intersection, k));
						if (k != (apol_vector_get_size(perm_intersection) - 1))
							apol_str_append(&(proof->text), &tmp_counter, ", ");
					}
					if (!item) {
						item = sechk_item_new(NULL);
						if (!item) {
							error = errno;
							ERR(policy, "%s", strerror(error));
							goto spurious_audit_run_fail;
						}
						item->item = (void *)rule1;	/* item is the dontaudit rule */
					}
					if (!item->proof) {
						item->proof = apol_vector_create(sechk_proof_free);
						if (!item->proof) {
							error = errno;
							ERR(policy, "%s", strerror(error));
							goto spurious_audit_run_fail;
						}
					}
					apol_vector_append(item->proof, (void *)proof);

				} else {
					/* these two rules don't overlap, no problem */
				}
				/* clean up */
				rule2 = NULL;
				apol_vector_destroy(&perm_vector1);
				apol_vector_destroy(&perm_vector2);
				apol_vector_destroy(&perm_intersection);
				qpol_iterator_destroy(&perm_iter1);
				qpol_iterator_destroy(&perm_iter2);
			}
			apol_vector_destroy(&allow_rules);
			if (!res->items) {
				res->items = apol_vector_create(sechk_item_free);
				if (!res->items) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
			}
			if (item)
				apol_vector_append(res->items, (void *)item);

			item = NULL;
		}
		apol_vector_destroy(&allow_rules);
	}
	apol_vector_destroy(&dontaudit_rules);

	/* Second error case: AuditAllow w/out Allow */
	for (i = 0; i < apol_vector_get_size(auditallow_rules); i++) {
		/* get first (AuditAllow) rule */
		rule1 = (qpol_avrule_t *) apol_vector_get_element(auditallow_rules, i);
		if (!rule1) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		/* get first rule's source, target, object class */
		if (qpol_avrule_get_source_type(q, rule1, &source)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		if (qpol_avrule_get_target_type(q, rule1, &target)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		if (qpol_avrule_get_object_class(q, rule1, &object)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		/* extract name strings from source, target, object */
		if (qpol_type_get_name(q, source, &src_name)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		if (qpol_type_get_name(q, target, &tgt_name)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		if (qpol_class_get_name(q, object, &obj_name)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}

		/* configure ALLOW rule query to match above rule */
		apol_avrule_query_set_rules(policy, query, QPOL_RULE_ALLOW);
		apol_avrule_query_set_source(policy, query, src_name, 1);
		apol_avrule_query_set_target(policy, query, tgt_name, 1);
		apol_avrule_query_append_class(policy, query, obj_name);

		if (apol_avrule_get_by_query(policy, query, &allow_rules)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}

		if (!apol_vector_get_size(allow_rules)) {
			/* No ALLOW rule for given AUDIT_ALLOW rule */

			/* Make proof: missing allow rule */
			proof = sechk_proof_new(NULL);
			if (!proof) {
				error = errno;
				ERR(policy, "%s", strerror(error));
				goto spurious_audit_run_fail;
			}
			proof->elem = NULL;
			proof->type = SECHK_ITEM_AVRULE;

			/* grab permisisons of auditallow rule, and make text */
			if (qpol_avrule_get_perm_iter(q, rule1, &perm_iter1)) {
				error = errno;
				ERR(policy, "%s", strerror(error));
				goto spurious_audit_run_fail;
			}
			perm_vector1 = apol_vector_create_from_iter(perm_iter1, free);
			if (!perm_vector1) {
				error = errno;
				ERR(policy, "%s", strerror(error));
				goto spurious_audit_run_fail;
			}

			tmp_counter = 0;
			for (j = 0; j < apol_vector_get_size(perm_vector1); j++) {
				if (apol_str_append(&(proof->text), &tmp_counter, (char *)apol_vector_get_element(perm_vector1, j))) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
				if (j != (apol_vector_get_size(perm_vector1) - 1)) {
					if (apol_str_append(&(proof->text), &tmp_counter, " ")) {
						error = errno;
						ERR(policy, "%s", strerror(error));
						goto spurious_audit_run_fail;
					}
				}
			}
			apol_vector_destroy(&perm_vector1);
			qpol_iterator_destroy(&perm_iter1);

			/* Make item: inconsistent auditallow rule */
			if (!item) {
				item = sechk_item_new(NULL);
				if (!item) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
			}
			item->item = (void *)rule1;
			if (!item->proof) {
				item->proof = apol_vector_create(sechk_proof_free);
				if (!item->proof) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
			}
			apol_vector_append(item->proof, (void *)proof);

			/* Add item to test result */
			if (!res->items) {
				res->items = apol_vector_create(sechk_item_free);
				if (!res->items) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
			}
			if (item)
				apol_vector_append(res->items, (void *)item);
			item = NULL;
			apol_vector_destroy(&allow_rules);
			continue;
		}

		/* Here we have AuditAllow rule and Allow rule(s) with same key */
		/* Checking to make sure they have the same permissions */

		/* Make vector of AuditAllow permissions */
		if (qpol_avrule_get_perm_iter(q, rule1, &perm_iter1)) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}
		perm_vector1 = apol_vector_create_from_iter(perm_iter1, free);
		if (!perm_vector1) {
			error = errno;
			ERR(policy, "%s", strerror(error));
			goto spurious_audit_run_fail;
		}

		/* Get permissions vector for Allow rule(s) */
		for (j = 0; j < apol_vector_get_size(allow_rules); j++) {
			/* get Allow rule */
			rule2 = (qpol_avrule_t *) apol_vector_get_element(allow_rules, j);
			if (!rule2) {
				error = errno;
				ERR(policy, "%s", strerror(error));
				goto spurious_audit_run_fail;
			}

			if (qpol_avrule_get_perm_iter(q, rule2, &perm_iter2)) {
				error = errno;
				ERR(policy, "%s", strerror(error));
				goto spurious_audit_run_fail;
			}

			if (!perm_vector2) {
				perm_vector2 = apol_vector_create(free);
				if (!perm_vector2) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
			}

			/* concatenate permissions from this rule, check for errors, all in one go */
			if (apol_vector_cat(perm_vector2, (tmp_v = apol_vector_create_from_iter(perm_iter2, NULL)))) {
				error = errno;
				ERR(policy, "%s", strerror(error));
				apol_vector_destroy(&tmp_v);
				goto spurious_audit_run_fail;
			}
			apol_vector_destroy(&tmp_v);
		}

		/* Find intersection of permission, put into a vector */
		perm_intersection = apol_vector_create_from_intersection(perm_vector1, perm_vector2, apol_str_strcmp, NULL);

		if (apol_vector_get_size(perm_intersection) != apol_vector_get_size(perm_vector1)) {
			/* Auditallow rule audits things that are not allowed */

			/* item for result is the AuditAllow rule */
			if (!item) {
				item = sechk_item_new(NULL);
				if (!item) {
					error = errno;
					ERR(policy, "%s", strerror(error));;
					goto spurious_audit_run_fail;
				}
			}
			item->item = (void *)rule1;
			/* proof is the lack of Allow rule */
			proof = sechk_proof_new(NULL);
			if (!proof) {
				error = errno;
				ERR(policy, "%s", strerror(error));
				goto spurious_audit_run_fail;
			}
			proof->elem = NULL;
			proof->type = SECHK_ITEM_AVRULE;

			/* the next series of if statements prints the following:
			 * missing: allow <src_name> <tgt_name> : <obj_name> { perms }; */
			tmp_counter = 0;
			for (j = 0; j < apol_vector_get_size(perm_vector1); j++) {
				string1 = (char *)apol_vector_get_element(perm_vector1, j);
				if (apol_vector_get_index(perm_intersection, (void *)string1, apol_str_strcmp, NULL, &l) < 0) {
					if (apol_str_append(&(proof->text), &tmp_counter, string1)) {
						error = errno;
						ERR(policy, "%s", strerror(error));
						goto spurious_audit_run_fail;
					}
					if (apol_str_append(&(proof->text), &tmp_counter, " ")) {
						error = errno;
						ERR(policy, "%s", strerror(error));
						goto spurious_audit_run_fail;
					}
				}
				string1 = NULL;
			}

			if (!item->proof) {
				item->proof = apol_vector_create(sechk_proof_free);
				if (!item->proof) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
			}
			apol_vector_append(item->proof, (void *)proof);
			proof = NULL;
			if (!res->items) {
				res->items = apol_vector_create(sechk_item_free);
				if (!res->items) {
					error = errno;
					ERR(policy, "%s", strerror(error));
					goto spurious_audit_run_fail;
				}
			}
			apol_vector_append(res->items, (void *)item);
			item = NULL;
		}

		/* clean up */
		apol_vector_destroy(&perm_vector1);
		apol_vector_destroy(&perm_vector2);
		apol_vector_destroy(&perm_intersection);
		apol_vector_destroy(&allow_rules);
		qpol_iterator_destroy(&perm_iter1);
		qpol_iterator_destroy(&perm_iter2);
	}

	apol_vector_destroy(&auditallow_rules);
	apol_avrule_query_destroy(&query);

	mod->result = res;

	/* If module finds something that would be considered a fail
	 * on the policy return 1 here */
	if (apol_vector_get_size(res->items) > 0)
		return 1;

	return 0;

      spurious_audit_run_fail:
	sechk_proof_free(proof);
	sechk_item_free(item);
	sechk_result_destroy(&res);
	apol_vector_destroy(&allow_rules);
	apol_vector_destroy(&auditallow_rules);
	apol_vector_destroy(&dontaudit_rules);
	apol_vector_destroy(&perm_vector1);
	apol_vector_destroy(&perm_vector2);
	apol_vector_destroy(&perm_intersection);
	qpol_iterator_destroy(&perm_iter1);
	qpol_iterator_destroy(&perm_iter2);
	apol_avrule_query_destroy(&query);
	free(tmp);
	tmp = NULL;
	sechk_result_destroy(&res);
	errno = error;
	return -1;
}

/* The print function generates the text and prints the
 * results to stdout. */
int spurious_audit_print(sechk_module_t * mod, apol_policy_t * policy, void *arg __attribute__ ((unused)))
{
	unsigned char outformat = 0x00;
	sechk_item_t *item = NULL;
	sechk_proof_t *proof = NULL;
	size_t i = 0, j = 0;
	uint32_t ruletype;
	qpol_policy_t *q = apol_policy_get_qpol(policy);
	char *tmp;

	if (!mod || !policy) {
		ERR(NULL, "%s", strerror(EINVAL));
		errno = EINVAL;
		return -1;
	}
	if (strcmp(mod_name, mod->name)) {
		ERR(policy, "%s%s%s", "wrong module (", mod->name, ")");
		errno = EINVAL;
		return -1;
	}

	outformat = mod->outputformat;

	if (!mod->result) {
		ERR(policy, "%s%s%s", "module ", mod->name, "has not been run");
		errno = EINVAL;
		return -1;
	}

	if (!outformat || (outformat & SECHK_OUT_QUIET))
		return 0;	       /* not an error - no output is requested */

	if (outformat & SECHK_OUT_STATS) {
		i = apol_vector_get_size(mod->result->items);
		printf("Found %zd rule%s.\n", i, (i == 1) ? "" : "s");
	}
	/* The list report component is a display of all items
	 * found without any supporting proof. */
	if (outformat & SECHK_OUT_LIST) {
		printf("\n");
		for (i = 0; i < apol_vector_get_size(mod->result->items); i++) {
			item = apol_vector_get_element(mod->result->items, i);
			printf("%s\n", (tmp = apol_avrule_render(policy, (qpol_avrule_t *) item->item)));
			free(tmp);
		}
		printf("\n");
	}
	/* The proof report component is a display of a list of items
	 * with an indented list of proof statements supporting the result
	 * of the check for that item. */
	if (outformat & SECHK_OUT_PROOF) {
		printf("\n");
		for (i = 0; i < apol_vector_get_size(mod->result->items); i++) {
			item = apol_vector_get_element(mod->result->items, i);
			printf("%s\n", (tmp = apol_avrule_render(policy, (qpol_avrule_t *) item->item)));

			qpol_avrule_get_rule_type(q, (qpol_avrule_t *) item->item, &ruletype);
			if (ruletype == QPOL_RULE_DONTAUDIT) {
				for (j = 0; j < apol_vector_get_size(item->proof); j++) {
					proof = apol_vector_get_element(item->proof, j);
					printf("\tinconsistent: ");
					printf("%s\n", apol_avrule_render(policy, (qpol_avrule_t *) proof->elem));
					printf("\tinconsistent permissions:\n");
					printf("\t%s\n", proof->text);
				}
			} else if (ruletype == QPOL_RULE_AUDITALLOW) {
				printf("\tmissing: ");
				printf("%s\n", strstr(apol_avrule_render(policy, (qpol_avrule_t *) item->item), "allow"));
				printf("\tmissing permissions:\n");
				for (j = 0; j < apol_vector_get_size(item->proof); j++) {
					proof = apol_vector_get_element(item->proof, j);
					printf("\t%s\n", proof->text);
				}
			}
			printf("\n");
		}
		printf("\n");
	}

	return 0;
}