sssd.git/src/python, branch master

UTIL: Remove python wrapper sss_python_unicode_from_string

2015-02-25T07:38:29+00:00

The function PyUnicode_FromString is available in python >= 2.6

Reviewed-by: Stephen Gallagher

UTIL: Remove python wrapper sss_python_set_check

2015-02-25T07:38:25+00:00

The macro PySet_Check is defined in python >= 2.6

Reviewed-by: Stephen Gallagher

UTIL: Remove python wrapper sss_python_set_add

2015-02-25T07:38:23+00:00

The function PySet_Add is available in python >= 2.6

Reviewed-by: Stephen Gallagher

UTIL: Remove python wrapper sss_python_set_new

2015-02-25T07:38:20+00:00

The function PySet_New is available in python >= 2.6

Reviewed-by: Stephen Gallagher

Fix warning: equality comparison with extraneous parentheses

2015-02-11T19:38:42+00:00

Example of warning:
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  error: equality comparison with extraneous parentheses
  [-Werror,-Wparentheses-equality]
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
         ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  note: remove extraneous parentheses around the comparison
  to silence this warning
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
        ~             ^                 ~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  note: use '=' to turn this equality comparison into an assignment
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
                      ^~
                      =

The reason is definition of some macros which were used in if conditions.

Reviewed-by: Michal Židek

pysss: Fix double free

2015-01-29T10:58:43+00:00

The talloc context is removed in destructor.

==1695== Invalid read of size 4
==1695==    at 0x1243D0CD: talloc_chunk_from_ptr (talloc.c:372)
==1695==    by 0x1243D0CD: _talloc_free (talloc.c:1559)
==1695==    by 0x117B18C3: PySssLocalObject_dealloc (pysss.c:836)
==1695==    by 0x117B1AEE: PySssLocalObject_new (pysss.c:898)
==1695==    by 0x4ED5522: type_call (typeobject.c:729)
==1695==    by 0x4E7F902: PyObject_Call (abstract.c:2529)
==1695==    by 0x4F15584: do_call (ceval.c:4328)
==1695==    by 0x4F15584: call_function (ceval.c:4133)
==1695==    by 0x4F15584: PyEval_EvalFrameEx (ceval.c:2753)
==1695==    by 0x4F16BE5: fast_function (ceval.c:4196)
==1695==    by 0x4F16BE5: call_function (ceval.c:4131)
==1695==    by 0x4F16BE5: PyEval_EvalFrameEx (ceval.c:2753)
==1695==    by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342)
==1695==    by 0x4EA46BC: function_call (funcobject.c:526)
==1695==    by 0x4E7F902: PyObject_Call (abstract.c:2529)
==1695==    by 0x4F1504F: ext_do_call (ceval.c:4423)
==1695==    by 0x4F1504F: PyEval_EvalFrameEx (ceval.c:2792)
==1695==    by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342)
==1695==  Address 0x112d4560 is 64 bytes inside a block of size 96 free'd
==1695==    at 0x4C2ACE9: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==1695==    by 0x1243D2F2: _talloc_free_internal (talloc.c:1057)
==1695==    by 0x1243D2F2: _talloc_free (talloc.c:1581)
==1695==    by 0x117B1ABF: PySssLocalObject_new (pysss.c:876)
==1695==    by 0x4ED5522: type_call (typeobject.c:729)
==1695==    by 0x4E7F902: PyObject_Call (abstract.c:2529)
==1695==    by 0x4F15584: do_call (ceval.c:4328)
==1695==    by 0x4F15584: call_function (ceval.c:4133)
==1695==    by 0x4F15584: PyEval_EvalFrameEx (ceval.c:2753)
==1695==    by 0x4F16BE5: fast_function (ceval.c:4196)
==1695==    by 0x4F16BE5: call_function (ceval.c:4131)
==1695==    by 0x4F16BE5: PyEval_EvalFrameEx (ceval.c:2753)
==1695==    by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342)
==1695==    by 0x4EA46BC: function_call (funcobject.c:526)
==1695==    by 0x4E7F902: PyObject_Call (abstract.c:2529)
==1695==    by 0x4F1504F: ext_do_call (ceval.c:4423)
==1695==    by 0x4F1504F: PyEval_EvalFrameEx (ceval.c:2792)
==1695==    by 0x4F183FF: PyEval_EvalCodeEx (ceval.c:3342)

Reviewed-by: Pavel Reichl

Python3 support in SSSD

2015-01-13T09:25:37+00:00

https://fedorahosted.org/sssd/ticket/2017

pyhbac,pysss: fix reference leaks

2014-10-22T14:40:25+00:00

Resolves:
https://fedorahosted.org/sssd/ticket/1195

Reviewed-by: Jakub Hrozek

pysss: test return value of realloc.

2014-09-05T15:34:04+00:00

It is not very likely that realloc will return NULL, but it's better
to be defensive.

src/python/pysss.c:774: var_assigned: Assigning: "groups" = null return value from "realloc".
src/python/pysss.c:788: dereference: Dereferencing a null pointer "groups".

Reviewed-by: Pavel Reichl

Remove unused structures.

2014-02-26T18:29:46+00:00

Reported by: cppcheck

'struct py_sss_transaction', 'struct resolve_get_domain_stat',
'struct sync_op_res' were defined in implementation modules, but they were not
used anywhere.

Reviewed-by: Michal Žídek