diff options
| author | Adam Romanek <romanek.adam@gmail.com> | 2020-07-15 13:11:33 +0200 |
|---|---|---|
| committer | Adam Romanek <romanek.adam@gmail.com> | 2020-07-15 13:11:33 +0200 |
| commit | 703a76650f746bad713fef55389a616f0067255a (patch) | |
| tree | 5786b501c02ea1ced86019d4ea0163a913c524e7 /tests/properties/fixtures/authorization_matrix.xml | |
| parent | 28e43831e9facb5bdd1169f3af845aad5bf0c717 (diff) | |
| download | python-jenkins-job-builder-703a76650f746bad713fef55389a616f0067255a.tar.gz python-jenkins-job-builder-703a76650f746bad713fef55389a616f0067255a.tar.xz python-jenkins-job-builder-703a76650f746bad713fef55389a616f0067255a.zip | |
Fix Authorization Matrix property - inheritance strategy
Up until now <inheritanceStrategy> tag was only added to jobs-in-a-folder
and folder configs. In JJB the tag's class is always set to
"InheritParentStrategy" which according to the docs means the "item will
inherit its parent items permissions". Apparently <inheritanceStrategy>
tag needs to be present on top-level jobs also. For top-level jobs
setting the tag's class value to "InheritParentStrategy" means the job
"will inherit the global security security settings" and this is the
default behavior.
The code has simplified a bit - if it's a folder then we use a different
property name for authorization matrix property, other than that the
code is the same for all three "variants": folder, job-in-a-folder and
job-outside-a-folder (top-level job).
Also this change fixes the missing <inheritanceStrategy> tag for
job-in-a-folder, where the folder name was specified as part of the
"name" key instead of the standalone "folder" key. With this change we
no longer check if a job is in a folder or not, so it's implicitly
fixed. Added a test case to catch potential regressions in the future.
The copyright notice reflects this and the previous contribution in this
module.
Change-Id: I84b22c09c8a107aab2b4eca20feffc9b61675a92
Diffstat (limited to 'tests/properties/fixtures/authorization_matrix.xml')
| -rw-r--r-- | tests/properties/fixtures/authorization_matrix.xml | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/properties/fixtures/authorization_matrix.xml b/tests/properties/fixtures/authorization_matrix.xml index f3fd8177..6404b142 100644 --- a/tests/properties/fixtures/authorization_matrix.xml +++ b/tests/properties/fixtures/authorization_matrix.xml @@ -2,6 +2,7 @@ <project> <properties> <hudson.security.AuthorizationMatrixProperty> + <inheritanceStrategy class="org.jenkinsci.plugins.matrixauth.inheritance.InheritParentStrategy"/> <permission>hudson.model.Item.Delete:admin</permission> <permission>hudson.model.Item.Configure:admin</permission> <permission>hudson.model.Item.Read:admin</permission> |