summaryrefslogtreecommitdiffstats
path: root/jenkins_jobs
diff options
context:
space:
mode:
authorDavid Aguilar <davvid@gmail.com>2020-06-20 15:21:53 -0700
committerDavid Aguilar <davvid@gmail.com>2020-06-23 23:35:05 -0700
commitbc585293b2e09d64484ebf6a8811266cf8c2cde8 (patch)
treecebd3c2ed1e1ae91ce3dd7ba3574478c552767d6 /jenkins_jobs
parent52caa12068b750cb3174c7d434bb0ba0aace82ee (diff)
downloadpython-jenkins-job-builder-bc585293b2e09d64484ebf6a8811266cf8c2cde8.tar.gz
python-jenkins-job-builder-bc585293b2e09d64484ebf6a8811266cf8c2cde8.tar.xz
python-jenkins-job-builder-bc585293b2e09d64484ebf6a8811266cf8c2cde8.zip
publishers: deprecate "evenIfDownstreamUnstable" in join-trigger
Only emit the joinTrigger evenIfDownstreamUnstable property when it has been configured. This property is no longer presented in newer version of the join plugin, and has been replaced with a result threshold. Mark the boolean as deprecated. Change-Id: If87517330ebbef17146b20f47689a29f8417b20e Signed-off-by: David Aguilar <davvid@gmail.com>
Diffstat (limited to 'jenkins_jobs')
-rwxr-xr-xjenkins_jobs/modules/publishers.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/jenkins_jobs/modules/publishers.py b/jenkins_jobs/modules/publishers.py
index a9254d62..fc28baed 100755
--- a/jenkins_jobs/modules/publishers.py
+++ b/jenkins_jobs/modules/publishers.py
@@ -3493,11 +3493,11 @@ def join_trigger(registry, xml_parent, data):
Trigger a job after all the immediate downstream jobs have completed.
Requires the Jenkins :jenkins-plugins:`Join Plugin <join>`.
- :arg bool even-if-unstable: if true jobs will trigger even if some
- downstream jobs are marked as unstable (default false)
:arg list projects: list of projects to trigger
:arg list publishers: list of triggers from publishers module that
defines projects that need to be triggered
+ :arg bool even-if-unstable: if true jobs will trigger even if some
+ downstream jobs are marked as unstable (default false) (DEPRECATED)
Example:
@@ -3515,8 +3515,9 @@ def join_trigger(registry, xml_parent, data):
for edited_node in create_publishers(registry, pub):
publishers.append(edited_node)
- unstable = str(data.get("even-if-unstable", "false")).lower()
- XML.SubElement(jointrigger, "evenIfDownstreamUnstable").text = unstable
+ unstable = str(data.get("even-if-unstable", "")).lower()
+ if unstable:
+ XML.SubElement(jointrigger, "evenIfDownstreamUnstable").text = unstable
def jabber(registry, xml_parent, data):