diff options
| author | Joseph Kostreva <joseph.kostreva@garmin.com> | 2019-08-22 13:09:36 -0500 |
|---|---|---|
| committer | James Harris <james.harris@garmin.com> | 2019-11-06 10:03:30 -0600 |
| commit | 8c29f8931c3412ce1a4c5b772cf8aaf13690684f (patch) | |
| tree | 7d9c5e37a1a0776e614ab4dc147f929aba85f0ab | |
| parent | 8c19ca0cd20a1b039c15c70bb313a07d5784ddd1 (diff) | |
| download | python-jenkins-job-builder-8c29f8931c3412ce1a4c5b772cf8aaf13690684f.tar.gz python-jenkins-job-builder-8c29f8931c3412ce1a4c5b772cf8aaf13690684f.tar.xz python-jenkins-job-builder-8c29f8931c3412ce1a4c5b772cf8aaf13690684f.zip | |
Add Private and WIP change support for gerrit
Updated gerrit trigger support to include the new exclude private and
exclude wip changes.
Change-Id: I75d8113941e4e455ec34fab23d347816c2ef699b
| -rw-r--r-- | jenkins_jobs/modules/triggers.py | 14 | ||||
| -rw-r--r-- | tests/triggers/fixtures/gerrit004.xml | 2 | ||||
| -rw-r--r-- | tests/triggers/fixtures/gerrit004.yaml | 2 | ||||
| -rw-r--r-- | tests/triggers/fixtures/gerrit008.xml | 2 | ||||
| -rw-r--r-- | tests/triggers/fixtures/gerrit008.yaml | 2 |
5 files changed, 22 insertions, 0 deletions
diff --git a/jenkins_jobs/modules/triggers.py b/jenkins_jobs/modules/triggers.py index 5831f4ba..21d9a7a3 100644 --- a/jenkins_jobs/modules/triggers.py +++ b/jenkins_jobs/modules/triggers.py @@ -155,6 +155,8 @@ def build_gerrit_triggers(xml_parent, data): "patchset-uploaded-event": "PluginPatchsetCreatedEvent", "patchset-created-event": "PluginPatchsetCreatedEvent", "ref-updated-event": "PluginRefUpdatedEvent", + "private-state-changed-event": "PluginPrivateStateChangedEvent", + "wip-state-changed-event": "PluginWipStateChangedEvent", } tag_namespace = ( "com.sonyericsson.hudson.plugins.gerrit.trigger." "hudsontrigger.events" @@ -193,6 +195,8 @@ def build_gerrit_triggers(xml_parent, data): ("exclude-drafts", "excludeDrafts", False), ("exclude-trivial-rebase", "excludeTrivialRebase", False), ("exclude-no-code-change", "excludeNoCodeChange", False), + ("exclude-private", "excludePrivateState", False), + ("exclude-wip", "excludeWipState", False), ] helpers.convert_mapping_to_xml(pc, pce, mapping, fail_required=True) @@ -260,7 +264,13 @@ def gerrit(registry, xml_parent, data): (default false) * **exclude-no-code-change** (`bool`) -- exclude no code change (default false) + * **exclude-private** (`bool`) -- exclude private change + (default false) + * **exclude-wip** (`bool`) -- exclude wip change + (default false) + exclude-private|exclude-wip needs + Gerrit Trigger v2.29.0 Exclude drafts|trivial-rebase|no-code-change needs Gerrit Trigger v2.12.0 @@ -276,6 +286,10 @@ def gerrit(registry, xml_parent, data): Gerrit Trigger Plugin version >= 2.8.0 * **draft-published-event** -- Trigger on draft published event. * **ref-updated-event** -- Trigger on ref-updated. + Gerrit Trigger Plugin version >= 2.29.0 + * **private-state-changed-event** -- Trigger on private state changed event. + * **wip-state-changed-event** -- Trigger on wip state changed event. + Gerrit Trigger Plugin version >= 2.8.0 * **comment-added-event** (`dict`) -- Trigger on comment added. :Comment added: diff --git a/tests/triggers/fixtures/gerrit004.xml b/tests/triggers/fixtures/gerrit004.xml index 324ad9ad..4afca1cd 100644 --- a/tests/triggers/fixtures/gerrit004.xml +++ b/tests/triggers/fixtures/gerrit004.xml @@ -54,6 +54,8 @@ <excludeDrafts>true</excludeDrafts> <excludeTrivialRebase>true</excludeTrivialRebase> <excludeNoCodeChange>true</excludeNoCodeChange> + <excludePrivateState>true</excludePrivateState> + <excludeWipState>true</excludeWipState> </com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginPatchsetCreatedEvent> <com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginCommentAddedEvent> <verdictCategory>APRV</verdictCategory> diff --git a/tests/triggers/fixtures/gerrit004.yaml b/tests/triggers/fixtures/gerrit004.yaml index 2eb955f6..df64b592 100644 --- a/tests/triggers/fixtures/gerrit004.yaml +++ b/tests/triggers/fixtures/gerrit004.yaml @@ -5,6 +5,8 @@ triggers: exclude-drafts: true exclude-trivial-rebase: true exclude-no-code-change: true + exclude-private: true + exclude-wip: true - comment-added-event: approval-category: 'APRV' approval-value: 1 diff --git a/tests/triggers/fixtures/gerrit008.xml b/tests/triggers/fixtures/gerrit008.xml index bd06843a..d1761489 100644 --- a/tests/triggers/fixtures/gerrit008.xml +++ b/tests/triggers/fixtures/gerrit008.xml @@ -60,6 +60,8 @@ <excludeDrafts>true</excludeDrafts> <excludeTrivialRebase>true</excludeTrivialRebase> <excludeNoCodeChange>true</excludeNoCodeChange> + <excludePrivateState>true</excludePrivateState> + <excludeWipState>true</excludeWipState> </com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginPatchsetCreatedEvent> <com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginCommentAddedEvent> <verdictCategory>APRV</verdictCategory> diff --git a/tests/triggers/fixtures/gerrit008.yaml b/tests/triggers/fixtures/gerrit008.yaml index 38897f37..48fcc0b2 100644 --- a/tests/triggers/fixtures/gerrit008.yaml +++ b/tests/triggers/fixtures/gerrit008.yaml @@ -5,6 +5,8 @@ triggers: exclude-drafts: true exclude-trivial-rebase: true exclude-no-code-change: true + exclude-private: true + exclude-wip: true - comment-added-event: approval-category: 'APRV' approval-value: 1 |