diff options
Diffstat (limited to 'votca-xtp/review.txt')
| -rw-r--r-- | votca-xtp/review.txt | 330 |
1 files changed, 0 insertions, 330 deletions
diff --git a/votca-xtp/review.txt b/votca-xtp/review.txt deleted file mode 100644 index e7444c8..0000000 --- a/votca-xtp/review.txt +++ /dev/null @@ -1,330 +0,0 @@ - -This is a review *template*. Besides handling the [ ]-marked tests you are -also supposed to fix the template before pasting into bugzilla: -- Add issues you find to the list of issues on top. If there isn't such - a list, create one. -- Add your own remarks to the template checks. -- Add new lines marked [!] or [?] when you discover new things not - listed by fedora-review. -- Change or remove any text in the template which is plain wrong. In this - case you could also file a bug against fedora-review -- Remove the "[ ] Manual check required", you will not have any such lines - in what you paste. -- Remove attachments which you deem not really useful (the rpmlint - ones are mandatory, though) -- Remove this text - - - -Package Review -============== - -Legend: -[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated -[ ] = Manual review needed - - - -===== MUST items ===== - -C/C++: -[ ]: Package does not contain kernel modules. -[ ]: Package contains no static executables. -[x]: Header files in -devel subpackage, if present. -[x]: ldconfig called in %post and %postun if required. -[x]: Package does not contain any libtool archives (.la) -[x]: Rpath absent or only used for internal libs. -[x]: Development (unversioned) .so files in -devel subpackage, if present. - -Generic: -[ ]: Package is licensed with an open-source compatible license and meets - other legal requirements as defined in the legal section of Packaging - Guidelines. -[ ]: License field in the package spec file matches the actual license. - Note: Checking patched sources after %prep for licenses. Licenses - found: "Apache (v2.0)", "Unknown or generated". 136 files have unknown - license. Detailed output of licensecheck in /travis/votca-xtp/review- - votca-xtp/licensecheck.txt -[ ]: License file installed when any subpackage combination is installed. -[ ]: Package must own all directories that it creates. - Note: Directories without known owners: /usr/share/votca -[ ]: %build honors applicable compiler flags or justifies otherwise. -[ ]: Package contains no bundled libraries without FPC exception. -[ ]: Changelog in prescribed format. -[ ]: Sources contain only permissible code or content. -[ ]: Package contains desktop file if it is a GUI application. -[ ]: Development files must be in a -devel package -[ ]: Package uses nothing in %doc for runtime. -[ ]: Package consistently uses macros (instead of hard-coded directory - names). -[ ]: Package is named according to the Package Naming Guidelines. -[ ]: Package does not generate any conflict. -[ ]: Package obeys FHS, except libexecdir and /usr/target. -[ ]: If the package is a rename of another package, proper Obsoletes and - Provides are present. -[ ]: Requires correct, justified where necessary. -[ ]: Spec file is legible and written in American English. -[ ]: Package contains systemd file(s) if in need. -[ ]: Useful -debuginfo package or justification otherwise. -[ ]: Package is not known to require an ExcludeArch tag. -[ ]: Package complies to the Packaging Guidelines -[x]: Package successfully compiles and builds into binary rpms on at least - one supported primary architecture. -[x]: Package installs properly. -[x]: Rpmlint is run on all rpms the build produces. - Note: There are rpmlint messages (see attachment). -[x]: If (and only if) the source package includes the text of the - license(s) in its own file, then that file, containing the text of the - license(s) for the package is included in %license. -[x]: Package requires other packages for directories it uses. -[x]: Package does not own files or directories owned by other packages. -[x]: All build dependencies are listed in BuildRequires, except for any - that are listed in the exceptions section of Packaging Guidelines. -[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT -[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the - beginning of %install. -[x]: Macros in Summary, %description expandable at SRPM build time. -[x]: Dist tag is present. -[x]: Package does not contain duplicates in %files. -[x]: Permissions on files are set properly. -[x]: Package use %makeinstall only when make install DESTDIR=... doesn't - work. -[x]: Package is named using only allowed ASCII characters. -[x]: Package does not use a name that already exists. -[x]: Package is not relocatable. -[x]: Sources used to build the package match the upstream source, as - provided in the spec URL. -[x]: Spec file name must match the spec package %{name}, in the format - %{name}.spec. -[x]: File names are valid UTF-8. -[x]: Large documentation must go in a -doc subpackage. Large could be size - (~1MB) or number of files. - Note: Documentation size is 0 bytes in 0 files. -[x]: Packages must not store files under /srv, /opt or /usr/local - -===== SHOULD items ===== - -Generic: -[ ]: If the source package does not include license text(s) as a separate - file from upstream, the packager SHOULD query upstream to include it. -[ ]: Final provides and requires are sane (see attachments). -[ ]: Fully versioned dependency in subpackages if applicable. - Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in votca- - xtp-libs , votca-xtp-devel , votca-xtp-common , votca-xtp-doc , votca- - xtp-debuginfo -[ ]: Package functions as described. -[ ]: Latest version is packaged. -[ ]: Package does not include license text files separate from upstream. -[ ]: Scriptlets must be sane, if used. -[ ]: Description and summary sections in the package spec file contains - translations for supported Non-English languages, if available. -[ ]: Package should compile and build into binary rpms on all supported - architectures. -[ ]: %check is present and all tests pass. -[ ]: Packages should try to preserve timestamps of original installed - files. -[ ]: Spec use %global instead of %define unless justified. - Note: %define requiring justification: %define _smp_mflags -j1 -[x]: Reviewer should test that the package builds in mock. -[x]: Buildroot is not present -[x]: Package has no %clean section with rm -rf %{buildroot} (or - $RPM_BUILD_ROOT) -[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. -[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file -[x]: The placement of pkgconfig(.pc) files are correct. -[x]: Sources can be downloaded from URI in Source: tag -[x]: SourceX is a working URL. - -===== EXTRA items ===== - -Generic: -[x]: Rpmlint is run on debuginfo package(s). - Note: No rpmlint messages. -[x]: Rpmlint is run on all installed packages. - Note: There are rpmlint messages (see attachment). -[x]: Large data in /usr/share should live in a noarch subpackage if package - is arched. -[x]: Spec file according to URL is the same as in SRPM. - - -Rpmlint -------- -Checking: votca-xtp-1.4-0.2rc1.fc26.x86_64.rpm - votca-xtp-libs-1.4-0.2rc1.fc26.x86_64.rpm - votca-xtp-devel-1.4-0.2rc1.fc26.x86_64.rpm - votca-xtp-common-1.4-0.2rc1.fc26.noarch.rpm - votca-xtp-doc-1.4-0.2rc1.fc26.noarch.rpm - votca-xtp-debuginfo-1.4-0.2rc1.fc26.x86_64.rpm - votca-xtp-1.4-0.2rc1.fc26.src.rpm -votca-xtp.x86_64: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp.x86_64: W: no-documentation -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_update_exciton -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_run -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_tools -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_map -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_parallel -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_dump -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_kmc_run -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_basisset -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_testsuite -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_update -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_overlap -votca-xtp-libs.x86_64: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libvotca_xtp.so.4 exit@GLIBC_2.2.5 -votca-xtp-libs.x86_64: W: no-documentation -votca-xtp-devel.x86_64: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp-devel.x86_64: W: only-non-binary-in-usr-lib -votca-xtp-devel.x86_64: W: no-documentation -votca-xtp-common.noarch: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp-common.noarch: W: no-documentation -votca-xtp-doc.noarch: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp.src: W: spelling-error %description -l en_US graining -> gaining, raining, training -7 packages and 0 specfiles checked; 0 errors, 23 warnings. - - - - -Rpmlint (debuginfo) -------------------- -Checking: votca-xtp-debuginfo-1.4-0.2rc1.fc26.x86_64.rpm -1 packages and 0 specfiles checked; 0 errors, 0 warnings. - - - - - -Rpmlint (installed packages) ----------------------------- -votca-xtp-doc.noarch: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp-common.noarch: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp-common.noarch: W: no-documentation -votca-xtp.x86_64: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp.x86_64: W: no-documentation -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_run -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_basisset -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_parallel -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_dump -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_update_exciton -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_map -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_kmc_run -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_overlap -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_tools -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_testsuite -votca-xtp.x86_64: W: no-manual-page-for-binary xtp_update -votca-xtp-libs.x86_64: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libvotca_xtp.so.4 exit@GLIBC_2.2.5 -votca-xtp-libs.x86_64: W: no-documentation -votca-xtp-devel.x86_64: W: spelling-error %description -l en_US graining -> gaining, raining, training -votca-xtp-devel.x86_64: W: only-non-binary-in-usr-lib -votca-xtp-devel.x86_64: W: no-documentation -6 packages and 0 specfiles checked; 0 errors, 22 warnings. - - - -Requires --------- -votca-xtp-doc (rpmlib, GLIBC filtered): - votca-csg-common - -votca-xtp-debuginfo (rpmlib, GLIBC filtered): - -votca-xtp-common (rpmlib, GLIBC filtered): - -votca-xtp (rpmlib, GLIBC filtered): - /usr/bin/python2 - libboost_filesystem.so.1.60.0()(64bit) - libboost_program_options.so.1.60.0()(64bit) - libboost_serialization.so.1.60.0()(64bit) - libboost_timer.so.1.60.0()(64bit) - libc.so.6()(64bit) - libgcc_s.so.1()(64bit) - libgcc_s.so.1(GCC_3.0)(64bit) - libgomp.so.1()(64bit) - libm.so.6()(64bit) - libpthread.so.0()(64bit) - libstdc++.so.6()(64bit) - libstdc++.so.6(CXXABI_1.3)(64bit) - libstdc++.so.6(CXXABI_1.3.1)(64bit) - libstdc++.so.6(CXXABI_1.3.9)(64bit) - libvotca_csg.so.4()(64bit) - libvotca_tools.so.4()(64bit) - libvotca_xtp.so.4()(64bit) - rtld(GNU_HASH) - votca-xtp-common - votca-xtp-libs(x86-64) - -votca-xtp-libs (rpmlib, GLIBC filtered): - /sbin/ldconfig - libboost_filesystem.so.1.60.0()(64bit) - libboost_program_options.so.1.60.0()(64bit) - libboost_serialization.so.1.60.0()(64bit) - libboost_timer.so.1.60.0()(64bit) - libc.so.6()(64bit) - libgcc_s.so.1()(64bit) - libgcc_s.so.1(GCC_3.0)(64bit) - libgomp.so.1()(64bit) - libgomp.so.1(GOMP_1.0)(64bit) - libgomp.so.1(GOMP_4.0)(64bit) - libgomp.so.1(OMP_1.0)(64bit) - libm.so.6()(64bit) - libpthread.so.0()(64bit) - libstdc++.so.6()(64bit) - libstdc++.so.6(CXXABI_1.3)(64bit) - libstdc++.so.6(CXXABI_1.3.1)(64bit) - libstdc++.so.6(CXXABI_1.3.8)(64bit) - libstdc++.so.6(CXXABI_1.3.9)(64bit) - libvotca_csg.so.4()(64bit) - libvotca_tools.so.4()(64bit) - rtld(GNU_HASH) - -votca-xtp-devel (rpmlib, GLIBC filtered): - /usr/bin/pkg-config - libvotca_xtp.so.4()(64bit) - votca-csg-devel(x86-64) - votca-xtp-libs(x86-64) - - - -Provides --------- -votca-xtp-doc: - votca-xtp-doc - -votca-xtp-debuginfo: - votca-xtp-debuginfo - votca-xtp-debuginfo(x86-64) - -votca-xtp-common: - votca-xtp-common - -votca-xtp: - votca-xtp - votca-xtp(x86-64) - -votca-xtp-libs: - libvotca_xtp.so.4()(64bit) - votca-xtp-libs - votca-xtp-libs(x86-64) - -votca-xtp-devel: - votca-xtp-devel - votca-xtp-devel(x86-64) - - - -Source checksums ----------------- -https://github.com/votca/xtp/archive/v1.4_rc1.tar.gz#/votca-xtp-1.4_rc1.tar.gz : - CHECKSUM(SHA256) this package : b3c839b0cd372399a9de3e06a2d1aedb926ccde4d2df3b9600bc1470ddb0b7df - CHECKSUM(SHA256) upstream package : b3c839b0cd372399a9de3e06a2d1aedb926ccde4d2df3b9600bc1470ddb0b7df -https://github.com/votca/xtp/releases/download/v1.4_rc1/votca-xtp-manual-1.4_rc1.pdf : - CHECKSUM(SHA256) this package : 641a0ee0f95a31f01cf8efccfecf00fea6b353206ded3b06bfd0147c1216df99 - CHECKSUM(SHA256) upstream package : 641a0ee0f95a31f01cf8efccfecf00fea6b353206ded3b06bfd0147c1216df99 - - -Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 -Command line :/usr/bin/fedora-review -v --mock-config fedora-rawhide-x86_64 -n votca-xtp -Buildroot used: fedora-rawhide-x86_64 -Active plugins: Generic, Shell-api, C/C++ -Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP -Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 |