summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKen'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>2009-03-31 11:05:26 +0900
committerDhaval Giani <dhaval@linux.vnet.ibm.com>2009-03-31 11:33:10 +0530
commitc47ee042c61d050b70e6b90aa50848d82e77b041 (patch)
treebb24ee110401ec0e1e75afb38d29f0da5e99ab4c
parentdd1602c51180a63d2c75c049d7296c96cc1f51e9 (diff)
downloadlibcg-c47ee042c61d050b70e6b90aa50848d82e77b041.tar.gz
libcg-c47ee042c61d050b70e6b90aa50848d82e77b041.tar.xz
libcg-c47ee042c61d050b70e6b90aa50848d82e77b041.zip
Add free() call for error handling.
I reviewed the libcgroup code in the viewpoint of memory-leak and found a lack of free(). This patch adds a free() call for error handling. Signed-off-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp> Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
-rw-r--r--src/api.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/api.c b/src/api.c
index d31cf4d..2d57351 100644
--- a/src/api.c
+++ b/src/api.c
@@ -590,8 +590,8 @@ int cgroup_init()
ret = ECGOTHER;
goto unlock_exit;
}
- buf = fgets(buf, FILENAME_MAX, proc_cgroup);
- if (!buf) {
+ if (!fgets(buf, FILENAME_MAX, proc_cgroup)) {
+ free(buf);
last_errno = errno;
ret = ECGOTHER;
goto unlock_exit;