diff options
| author | Dhaval Giani <dhaval.giani@gmail.com> | 2010-03-26 15:04:34 +0100 |
|---|---|---|
| committer | Dhaval Giani <dhaval.giani@gmail.com> | 2010-03-26 15:10:41 +0100 |
| commit | 11873a5083b1943f6a410b1e3621815bd4226b5d (patch) | |
| tree | 7010a9f474decaf8a3df3de94a5d5eb65cb41f1a | |
| parent | 9172bf678dd0e93daa158e4fe03cd81c43f3dcaa (diff) | |
| download | libcg-11873a5083b1943f6a410b1e3621815bd4226b5d.tar.gz libcg-11873a5083b1943f6a410b1e3621815bd4226b5d.tar.xz libcg-11873a5083b1943f6a410b1e3621815bd4226b5d.zip | |
libcgroup: Dont assign values to variables inside if conditions
Signed-off-by: Dhaval Giani <dhaval.giani@gmail.com>
| -rw-r--r-- | src/api.c | 6 |
1 files changed, 4 insertions, 2 deletions
@@ -439,7 +439,8 @@ static int cgroup_parse_rules(bool cache, uid_t muid, if (strncmp(user, "@", 1) == 0) { /* New GID rule. */ itr = &(user[1]); - if ((grp = getgrnam(itr))) { + grp = getgrnam(itr); + if (grp) { uid = CGRULE_INVALID; gid = grp->gr_gid; } else { @@ -455,7 +456,8 @@ static int cgroup_parse_rules(bool cache, uid_t muid, gid = CGRULE_WILD; } else if (*itr != '%') { /* New UID rule. */ - if ((pwd = getpwnam(user))) { + pwd = getpwnam(user); + if (pwd) { uid = pwd->pw_uid; gid = CGRULE_INVALID; } else { |